Add tests for WebSocket Compression #126
Merged
+53
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds test parameters to be able to enable and disable compression along with WebSocketExtension settings for the handshaker.
8 tasks
mkurz
reviewed
Feb 22, 2022
| assertTrue(headers.contains("sec-websocket-extensions")); | ||
| assertEquals(headers.get("sec-websocket-extensions"), "permessage-deflate"); | ||
| } else { | ||
| assertTrue(!headers.contains("sec-websocket-extensions") || |
There was a problem hiding this comment.
Shouldn't we use and (&&) instead of or (||)?
There was a problem hiding this comment.
It's more future proofing, intuitively, either the server does not have extensions enabled or it does have extensions but compression is not.
EDIT: Because of this it is possible that it does have extensions enabled (with no compression) in that case the first condition would fail and second would succeed. That is why it is || so either of the conditions hold true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to create a new PR, because the commits got detached on the previous fork.
Related to: playframework/playframework#11169
Purpose
Adding tests for with and without compression enabled. Hopefully it covers all possible scenarios regarding compression.
The actual implementation unfortunately could not be placed in this repository due to the chain of Netty's codecs where
WebSocketServerCompressionHandlerneeds to be added is right after the HTTP Codecs.