feat: basic support for shorts #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansu
reviewed
Feb 3, 2022
iansu
approved these changes
Feb 3, 2022
Collaborator
|
@shadowspawn bother you for a rebase, I'm excited to land this one so that I can write more tests against |
shadowspawn
force-pushed
the
feature/basic-short
branch
from
40e1b38 to
5ab942c
Compare
bcoe
approved these changes
Feb 4, 2022
Collaborator
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
thanks for doing this work, I'm going to write some tests based on it now 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a start on support for short options.
Handle single character short, and lookup long option in
shortconfiguration if present.(Keeping code local to minimise conflicts at present. Changes still overlap with #40.)
First phase of implementing #2.