MissingReturnRule - make missing return with native return type non-ignorable

Author: ondrejmirtes

conf/config.level0.neon

@@ -172,7 +172,6 @@ services:
 		arguments:
 			checkExplicitMixedMissingReturn: %checkExplicitMixedMissingReturn%
 			checkPhpDocMissingReturn: %checkPhpDocMissingReturn%
-			bleedingEdge: %featureToggles.bleedingEdge%
 		tags:
 			- phpstan.rules.rule
 

src/Rules/Missing/MissingReturnRule.php

@@ -28,17 +28,13 @@ class MissingReturnRule implements Rule
 
 	private bool $checkPhpDocMissingReturn;
 
-	private bool $bleedingEdge;
-
 	public function __construct(
 		bool $checkExplicitMixedMissingReturn,
-		bool $checkPhpDocMissingReturn,
-		bool $bleedingEdge = false
+		bool $checkPhpDocMissingReturn
 	)
 	{
 		$this->checkExplicitMixedMissingReturn = $checkExplicitMixedMissingReturn;
 		$this->checkPhpDocMissingReturn = $checkPhpDocMissingReturn;
-		$this->bleedingEdge = $bleedingEdge;
 	}
 
 	public function getNodeType(): string
@@ -112,7 +108,7 @@ public function processNode(Node $node, Scope $scope): array
 		if ($returnType instanceof NeverType && $returnType->isExplicit()) {
 			$errorBuilder = RuleErrorBuilder::message(sprintf('%s should always throw an exception or terminate script execution but doesn\'t do that.', $description))->line($node->getNode()->getStartLine());
 
-			if ($this->bleedingEdge && $node->hasNativeReturnTypehint()) {
+			if ($node->hasNativeReturnTypehint()) {
 				$errorBuilder->nonIgnorable();
 			}
 
@@ -137,7 +133,7 @@ public function processNode(Node $node, Scope $scope): array
 			sprintf('%s should return %s but return statement is missing.', $description, $returnType->describe(VerbosityLevel::typeOnly()))
 		)->line($node->getNode()->getStartLine());
 
-		if ($this->bleedingEdge && $node->hasNativeReturnTypehint()) {
+		if ($node->hasNativeReturnTypehint()) {
 			$errorBuilder->nonIgnorable();
 		}