IssetCheck - remove bleeding edge condition so that undefined variables are always reported

Author: ondrejmirtes

conf/config.neon

@@ -864,7 +864,6 @@ services:
 	-
 		class: PHPStan\Rules\IssetCheck
 		arguments:
-			bleedingEdge: %featureToggles.bleedingEdge%
 			checkAdvancedIsset: %checkAdvancedIsset%
 
 	-

src/Rules/IssetCheck.php

@@ -20,19 +20,15 @@ class IssetCheck
 
 	private bool $checkAdvancedIsset;
 
-	private bool $bleedingEdge;
-
 	public function __construct(
 		PropertyDescriptor $propertyDescriptor,
 		PropertyReflectionFinder $propertyReflectionFinder,
-		bool $checkAdvancedIsset,
-		bool $bleedingEdge
+		bool $checkAdvancedIsset
 	)
 	{
 		$this->propertyDescriptor = $propertyDescriptor;
 		$this->propertyReflectionFinder = $propertyReflectionFinder;
 		$this->checkAdvancedIsset = $checkAdvancedIsset;
-		$this->bleedingEdge = $bleedingEdge;
 	}
 
 	/**
@@ -46,10 +42,7 @@ public function check(Expr $expr, Scope $scope, string $operatorDescription, cal
 				return null;
 			}
 
-			if (
-				$error === null
-				&& $this->bleedingEdge
-			) {
+			if ($error === null) {
 				if ($hasVariable->yes()) {
 					if ($expr->name === '_SESSION') {
 						return null;

tests/PHPStan/Rules/Variables/EmptyRuleTest.php

@@ -15,7 +15,7 @@ class EmptyRuleTest extends RuleTestCase
 
 	protected function getRule(): \PHPStan\Rules\Rule
 	{
-		return new EmptyRule(new IssetCheck(new PropertyDescriptor(), new PropertyReflectionFinder(), true, true));
+		return new EmptyRule(new IssetCheck(new PropertyDescriptor(), new PropertyReflectionFinder(), true));
 	}
 
 	public function testRule(): void

tests/PHPStan/Rules/Variables/IssetRuleTest.php

@@ -16,7 +16,7 @@ class IssetRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new IssetRule(new IssetCheck(new PropertyDescriptor(), new PropertyReflectionFinder(), true, true));
+		return new IssetRule(new IssetCheck(new PropertyDescriptor(), new PropertyReflectionFinder(), true));
 	}
 
 	public function testRule(): void

tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php

@@ -14,7 +14,7 @@ class NullCoalesceRuleTest extends \PHPStan\Testing\RuleTestCase
 
 	protected function getRule(): \PHPStan\Rules\Rule
 	{
-		return new NullCoalesceRule(new IssetCheck(new PropertyDescriptor(), new PropertyReflectionFinder(), true, true));
+		return new NullCoalesceRule(new IssetCheck(new PropertyDescriptor(), new PropertyReflectionFinder(), true));
 	}
 
 	public function testCoalesceRule(): void