[BCB] acceptsWithReason renamed to accepts

Author: ondrejmirtes

UPGRADING.md

@@ -290,3 +290,6 @@ Instead of `PHPStanTestCase::createBroker()`, call `PHPStanTestCase::createRefle
 * Remove `tempResultCachePath` config parameter, use `resultCachePath` instead
 * `LevelsTestCase::dataTopics()` data provider made static
 * `PHPStan\Node\Printer\Printer` no longer autowired as `PhpParser\PrettyPrinter\Standard`, use `PHPStan\Node\Printer\Printer` in the typehint
+* Remove `Type::acceptsWithReason()`, `Type:accepts()` return type changed from `TrinaryLogic` to [`AcceptsResult`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.AcceptsResult.html)
+* Remove `CompoundType::isAcceptedWithReasonBy()`, `CompoundType::isAcceptedBy()` return type changed from `TrinaryLogic` to [`AcceptsResult`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.AcceptsResult.html)
+* `RuleLevelHelper::accepts()` return type changed from `bool` to [`RuleLevelHelperAcceptsResult`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.AcceptsResult.html)

src/Rules/Constants/ValueAssignedToClassConstantRule.php

@@ -63,7 +63,7 @@ private function processSingleConstant(ClassReflection $classReflection, string
 				return [];
 			}
 
-			$accepts = $nativeType->acceptsWithReason($valueExprType, true);
+			$accepts = $nativeType->accepts($valueExprType, true);
 			if ($accepts->yes()) {
 				return [];
 			}
@@ -107,7 +107,7 @@ private function processSingleConstant(ClassReflection $classReflection, string
 		}
 
 		$type = $constantReflection->getValueType();
-		$accepts = $type->acceptsWithReason($valueExprType, true);
+		$accepts = $type->accepts($valueExprType, true);
 		if ($accepts->yes()) {
 			return [];
 		}

src/Rules/FunctionCallParametersCheck.php

@@ -312,7 +312,7 @@ public function check(
 				$parameterType = TypeUtils::resolveLateResolvableTypes($parameter->getType());
 
 				if (!$parameter->passedByReference()->createsNewVariable() || !$isBuiltin) {
-					$accepts = $this->ruleLevelHelper->acceptsWithReason($parameterType, $argumentValueType, $scope->isDeclareStrictTypes());
+					$accepts = $this->ruleLevelHelper->accepts($parameterType, $argumentValueType, $scope->isDeclareStrictTypes());
 
 					if (!$accepts->result) {
 						$verbosityLevel = VerbosityLevel::getRecommendedLevelByType($parameterType, $argumentValueType);

src/Rules/FunctionReturnTypeCheck.php

@@ -90,7 +90,7 @@ public function checkReturnType(
 			];
 		}
 
-		$accepts = $this->ruleLevelHelper->acceptsWithReason($returnType, $returnValueType, $scope->isDeclareStrictTypes());
+		$accepts = $this->ruleLevelHelper->accepts($returnType, $returnValueType, $scope->isDeclareStrictTypes());
 		if (!$accepts->result) {
 			return [
 				RuleErrorBuilder::message(sprintf(

src/Rules/Functions/IncompatibleArrowFunctionDefaultParameterTypeRule.php

@@ -44,7 +44,7 @@ public function processNode(Node $node, Scope $scope): array
 			$parameterType = $parameters[$paramI]->getType();
 			$parameterType = TemplateTypeHelper::resolveToBounds($parameterType);
 
-			$accepts = $parameterType->acceptsWithReason($defaultValueType, true);
+			$accepts = $parameterType->accepts($defaultValueType, true);
 			if ($accepts->yes()) {
 				continue;
 			}

src/Rules/Functions/IncompatibleClosureDefaultParameterTypeRule.php

@@ -44,7 +44,7 @@ public function processNode(Node $node, Scope $scope): array
 			$parameterType = $parameters[$paramI]->getType();
 			$parameterType = TemplateTypeHelper::resolveToBounds($parameterType);
 
-			$accepts = $parameterType->acceptsWithReason($defaultValueType, true);
+			$accepts = $parameterType->accepts($defaultValueType, true);
 			if ($accepts->yes()) {
 				continue;
 			}

src/Rules/Functions/IncompatibleDefaultParameterTypeRule.php

@@ -43,7 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 			$parameterType = $function->getParameters()[$paramI]->getType();
 			$parameterType = TemplateTypeHelper::resolveToBounds($parameterType);
 
-			$accepts = $parameterType->acceptsWithReason($defaultValueType, true);
+			$accepts = $parameterType->accepts($defaultValueType, true);
 			if ($accepts->yes()) {
 				continue;
 			}

src/Rules/Generators/YieldFromTypeRule.php

@@ -78,7 +78,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$messages = [];
-		$acceptsKey = $this->ruleLevelHelper->acceptsWithReason($returnType->getIterableKeyType(), $exprType->getIterableKeyType(), $scope->isDeclareStrictTypes());
+		$acceptsKey = $this->ruleLevelHelper->accepts($returnType->getIterableKeyType(), $exprType->getIterableKeyType(), $scope->isDeclareStrictTypes());
 		if (!$acceptsKey->result) {
 			$verbosityLevel = VerbosityLevel::getRecommendedLevelByType($returnType->getIterableKeyType(), $exprType->getIterableKeyType());
 			$messages[] = RuleErrorBuilder::message(sprintf(
@@ -92,7 +92,7 @@ public function processNode(Node $node, Scope $scope): array
 				->build();
 		}
 
-		$acceptsValue = $this->ruleLevelHelper->acceptsWithReason($returnType->getIterableValueType(), $exprType->getIterableValueType(), $scope->isDeclareStrictTypes());
+		$acceptsValue = $this->ruleLevelHelper->accepts($returnType->getIterableValueType(), $exprType->getIterableValueType(), $scope->isDeclareStrictTypes());
 		if (!$acceptsValue->result) {
 			$verbosityLevel = VerbosityLevel::getRecommendedLevelByType($returnType->getIterableValueType(), $exprType->getIterableValueType());
 			$messages[] = RuleErrorBuilder::message(sprintf(

src/Rules/Generators/YieldTypeRule.php

@@ -53,7 +53,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$messages = [];
-		$acceptsKey = $this->ruleLevelHelper->acceptsWithReason($returnType->getIterableKeyType(), $keyType, $scope->isDeclareStrictTypes());
+		$acceptsKey = $this->ruleLevelHelper->accepts($returnType->getIterableKeyType(), $keyType, $scope->isDeclareStrictTypes());
 		if (!$acceptsKey->result) {
 			$verbosityLevel = VerbosityLevel::getRecommendedLevelByType($returnType->getIterableKeyType(), $keyType);
 			$messages[] = RuleErrorBuilder::message(sprintf(
@@ -72,7 +72,7 @@ public function processNode(Node $node, Scope $scope): array
 			$valueType = $scope->getType($node->value);
 		}
 
-		$acceptsValue = $this->ruleLevelHelper->acceptsWithReason($returnType->getIterableValueType(), $valueType, $scope->isDeclareStrictTypes());
+		$acceptsValue = $this->ruleLevelHelper->accepts($returnType->getIterableValueType(), $valueType, $scope->isDeclareStrictTypes());
 		if (!$acceptsValue->result) {
 			$verbosityLevel = VerbosityLevel::getRecommendedLevelByType($returnType->getIterableValueType(), $valueType);
 			$messages[] = RuleErrorBuilder::message(sprintf(

src/Rules/Methods/IncompatibleDefaultParameterTypeRule.php

@@ -44,7 +44,7 @@ public function processNode(Node $node, Scope $scope): array
 			$parameterType = $parameter->getType();
 			$parameterType = TemplateTypeHelper::resolveToBounds($parameterType);
 
-			$accepts = $parameterType->acceptsWithReason($defaultValueType, true);
+			$accepts = $parameterType->accepts($defaultValueType, true);
 			if ($accepts->yes()) {
 				continue;
 			}