Fix password_hash return type

Author: VincentLanglet

resources/functionMap.php

@@ -8249,7 +8249,7 @@
 'parsekit_func_arginfo' => ['array', 'function'=>'mixed'],
 'passthru' => ['void', 'command'=>'string', '&w_return_value='=>'int'],
 'password_get_info' => ['array', 'hash'=>'string'],
-'password_hash' => ['non-empty-string|false', 'password'=>'string', 'algo'=>'int', 'options='=>'array'],
+'password_hash' => ['__benevolent<non-empty-string|false|null>', 'password'=>'string', 'algo'=>'int', 'options='=>'array'],
 'password_make_salt' => ['bool', 'password'=>'string', 'hash'=>'string'],
 'password_needs_rehash' => ['bool', 'hash'=>'string', 'algo'=>'int', 'options='=>'array'],
 'password_verify' => ['bool', 'password'=>'string', 'hash'=>'string'],

resources/functionMap_php74delta.php

@@ -41,7 +41,7 @@
 		'get_mangled_object_vars' => ['array', 'obj'=>'object'],
 		'mb_str_split' => ['list<string>|false', 'str'=>'string', 'split_length='=>'int', 'encoding='=>'string'],
 		'password_algos' => ['list<string>'],
-		'password_hash' => ['string|false', 'password'=>'string', 'algo'=>'string|null', 'options='=>'array'],
+		'password_hash' => ['__benevolent<string|false|null>', 'password'=>'string', 'algo'=>'string|null', 'options='=>'array'],
 		'password_needs_rehash' => ['bool', 'hash'=>'string', 'algo'=>'string|null', 'options='=>'array'],
 		'preg_replace_callback' => ['string|array|null', 'regex'=>'string|array', 'callback'=>'callable(array<int|string, string>):string', 'subject'=>'string|array', 'limit='=>'int', '&w_count='=>'int', 'flags='=>'int'],
 		'preg_replace_callback_array' => ['string|array|null', 'pattern'=>'array<string,callable>', 'subject'=>'string|array', 'limit='=>'int', '&w_count='=>'int', 'flags='=>'int'],

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -882,4 +882,25 @@ public function testBug8776Part2(): void
 		$this->analyse([__DIR__ . '/data/bug-8776-2.php'], []);
 	}
 
+	public function testBug5978(): void
+	{
+		if (PHP_VERSION_ID >= 80000) {
+			$expectedErrors = [
+				[
+					'Strict comparison using === between string and false will always evaluate to false.',
+					7,
+				],
+				[
+					'Strict comparison using === between string and null will always evaluate to false.',
+					7,
+				],
+			];
+		} else {
+			$expectedErrors = [];
+		}
+
+		$this->checkAlwaysTrueStrictComparison = true;
+		$this->analyse([__DIR__ . '/data/bug-5978.php'], $expectedErrors);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-5978.php

@@ -0,0 +1,12 @@
+<?php declare(strict_types = 1);
+
+namespace Bug5969;
+
+function hash(string $input) : string {
+	$hash = password_hash($input, PASSWORD_DEFAULT);
+	if ($hash === false || $hash === null) {
+		throw new \Exception("Could not generate hash");
+	}
+
+	return $hash;
+}