cover ExtendedMethodReflection by bc-promise

Author: staabm

src/Reflection/Assertions.php

@@ -10,6 +10,9 @@
 use function array_merge;
 use function count;
 
+/**
+ * @api
+ */
 class Assertions
 {
 

src/Reflection/ExtendedMethodReflection.php

@@ -14,6 +14,8 @@
  * and its methods in their code.
  *
  * Methods on ExtendedMethodReflection are subject to change.
+ *
+ * @api
  */
 interface ExtendedMethodReflection extends MethodReflection
 {

src/Rules/Api/ApiClassImplementsRule.php

@@ -5,12 +5,10 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleError;
 use PHPStan\Rules\RuleErrorBuilder;
-use PHPStan\Type\Type;
 use function array_merge;
 use function count;
 use function in_array;
@@ -67,12 +65,7 @@ private function checkName(Scope $scope, Node\Name $name): array
 			'https://github.com/phpstan/phpstan/discussions',
 		))->build();
 
-		if (in_array($implementedClassReflection->getName(), [
-			Type::class,
-			ReflectionProvider::class,
-			Scope::class,
-			FunctionReflection::class,
-		], true)) {
+		if (in_array($implementedClassReflection->getName(), BcUncoveredInterface::CLASSES, true)) {
 			return [$ruleError];
 		}
 

src/Rules/Api/ApiInterfaceExtendsRule.php

@@ -9,7 +9,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleError;
 use PHPStan\Rules\RuleErrorBuilder;
-use PHPStan\Type\Type;
 use function array_merge;
 use function count;
 use function in_array;
@@ -66,10 +65,7 @@ private function checkName(Scope $scope, Node\Name $name): array
 			'https://github.com/phpstan/phpstan/discussions',
 		))->build();
 
-		if (in_array($extendedInterfaceReflection->getName(), [
-			Type::class,
-			ReflectionProvider::class,
-		], true)) {
+		if (in_array($extendedInterfaceReflection->getName(), BcUncoveredInterface::CLASSES, true)) {
 			return [$ruleError];
 		}
 

src/Rules/Api/BcUncoveredInterface.php

@@ -0,0 +1,22 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Api;
+
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\ExtendedMethodReflection;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\ReflectionProvider;
+use PHPStan\Type\Type;
+
+final class BcUncoveredInterface
+{
+
+	public const CLASSES = [
+		Type::class,
+		ReflectionProvider::class,
+		Scope::class,
+		FunctionReflection::class,
+		ExtendedMethodReflection::class,
+	];
+
+}

tests/PHPStan/Rules/Api/ApiClassImplementsRuleTest.php

@@ -32,27 +32,32 @@ public function testRuleOutOfPhpStan(): void
 		$this->analyse([__DIR__ . '/data/class-implements-out-of-phpstan.php'], [
 			[
 				'Implementing PHPStan\DependencyInjection\Type\DynamicThrowTypeExtensionProvider is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				18,
+				19,
 				$tip,
 			],
 			[
 				'Implementing PHPStan\Type\Type is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				52,
+				53,
 				$tip,
 			],
 			[
 				'Implementing PHPStan\Reflection\ReflectionProvider is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				327,
+				328,
 				$tip,
 			],
 			[
 				'Implementing PHPStan\Analyser\Scope is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				332,
+				333,
 				$tip,
 			],
 			[
 				'Implementing PHPStan\Reflection\FunctionReflection is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				337,
+				338,
+				$tip,
+			],
+			[
+				'Implementing PHPStan\Reflection\ExtendedMethodReflection is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
+				342,
 				$tip,
 			],
 		]);

tests/PHPStan/Rules/Api/ApiInterfaceExtendsRuleTest.php

@@ -32,17 +32,22 @@ public function testRuleOutOfPhpStan(): void
 		$this->analyse([__DIR__ . '/data/interface-extends-out-of-phpstan.php'], [
 			[
 				'Extending PHPStan\DependencyInjection\Type\DynamicThrowTypeExtensionProvider is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				9,
+				10,
 				$tip,
 			],
 			[
 				'Extending PHPStan\Type\Type is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				19,
+				20,
 				$tip,
 			],
 			[
 				'Extending PHPStan\Reflection\ReflectionProvider is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
-				24,
+				25,
+				$tip,
+			],
+			[
+				'Extending PHPStan\Reflection\ExtendedMethodReflection is not covered by backward compatibility promise. The interface might change in a minor PHPStan version.',
+				30,
 				$tip,
 			],
 		]);

tests/PHPStan/Rules/Api/data/class-implements-out-of-phpstan.php

@@ -6,6 +6,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\DependencyInjection\Type\DynamicThrowTypeExtensionProvider;
 use PHPStan\Reflection\ClassMemberAccessAnswerer;
+use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\DynamicFunctionThrowTypeExtension;
@@ -335,6 +336,8 @@ abstract class MyScope implements Scope
 }
 
 abstract class MyFunctionReflection implements FunctionReflection
-{
+{}
 
-}
+
+abstract class MyMethodReflection implements ExtendedMethodReflection
+{}

tests/PHPStan/Rules/Api/data/interface-extends-out-of-phpstan.php

@@ -3,6 +3,7 @@
 namespace App\InterfaceExtends;
 
 use PHPStan\DependencyInjection\Type\DynamicThrowTypeExtensionProvider;
+use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\DynamicFunctionThrowTypeExtension;
 
@@ -25,3 +26,8 @@ interface Dolor extends ReflectionProvider
 {
 
 }
+
+interface Ipsum extends ExtendedMethodReflection
+{
+
+}