Useful PhpMethodReflection native type refactoring from #3966

Author: ondrejmirtes

src/Reflection/Php/PhpMethodReflection.php

@@ -302,30 +302,9 @@ public function isPublic(): bool
 	private function getReturnType(): Type
 	{
 		if ($this->returnType === null) {
-			$name = strtolower($this->getName());
-			$returnType = $this->reflection->getReturnType();
-			if ($returnType === null) {
-				if (in_array($name, ['__construct', '__destruct', '__unset', '__wakeup', '__clone'], true)) {
-					return $this->returnType = TypehintHelper::decideType(new VoidType(), $this->phpDocReturnType);
-				}
-				if ($name === '__tostring') {
-					return $this->returnType = TypehintHelper::decideType(new StringType(), $this->phpDocReturnType);
-				}
-				if ($name === '__isset') {
-					return $this->returnType = TypehintHelper::decideType(new BooleanType(), $this->phpDocReturnType);
-				}
-				if ($name === '__sleep') {
-					return $this->returnType = TypehintHelper::decideType(new ArrayType(new IntegerType(), new StringType()), $this->phpDocReturnType);
-				}
-				if ($name === '__set_state') {
-					return $this->returnType = TypehintHelper::decideType(new ObjectWithoutClassType(), $this->phpDocReturnType);
-				}
-			}
-
-			$this->returnType = TypehintHelper::decideTypeFromReflection(
-				$returnType,
+			$this->returnType = TypehintHelper::decideType(
+				$this->getNativeReturnType(),
 				$this->phpDocReturnType,
-				$this->declaringClass,
 			);
 		}
 
@@ -344,8 +323,28 @@ private function getPhpDocReturnType(): Type
 	private function getNativeReturnType(): Type
 	{
 		if ($this->nativeReturnType === null) {
+			$returnType = $this->reflection->getReturnType();
+			if ($returnType === null) {
+				$name = strtolower($this->getName());
+				if (in_array($this->getName(), ['__construct', '__destruct', '__unset', '__wakeup', '__clone'], true)) {
+					return $this->nativeReturnType = new VoidType();
+				}
+				if ($name === '__tostring') {
+					return $this->nativeReturnType = new StringType();
+				}
+				if ($name === '__isset') {
+					return $this->nativeReturnType = new BooleanType();
+				}
+				if ($name === '__sleep') {
+					return $this->nativeReturnType = new ArrayType(new IntegerType(), new StringType());
+				}
+				if ($name === '__set_state') {
+					return $this->nativeReturnType = new ObjectWithoutClassType();
+				}
+			}
+
 			$this->nativeReturnType = TypehintHelper::decideTypeFromReflection(
-				$this->reflection->getReturnType(),
+				$returnType,
 				null,
 				$this->declaringClass,
 			);

src/Type/TypehintHelper.php

@@ -68,8 +68,6 @@ public static function decideTypeFromReflection(
 		$type = ParserNodeTypeToPHPStanType::resolve($typeNode, $selfClass);
 		if ($reflectionType->allowsNull()) {
 			$type = TypeCombinator::addNull($type);
-		} elseif ($phpDocType !== null) {
-			$phpDocType = TypeCombinator::removeNull($phpDocType);
 		}
 
 		return self::decideType($type, $phpDocType);
@@ -80,6 +78,9 @@ public static function decideType(
 		?Type $phpDocType,
 	): Type
 	{
+		if ($phpDocType !== null && $type->isNull()->no()) {
+			$phpDocType = TypeCombinator::removeNull($phpDocType);
+		}
 		if ($type instanceof BenevolentUnionType) {
 			return $type;
 		}