Use repositoryClass as default

Author: mcfedr

extension.neon

@@ -2,7 +2,7 @@ parameters:
 	doctrine:
 		repositoryClass: Doctrine\ORM\EntityRepository
 		allCollectionsSelectable: true
-		objectManagerLoader: ~
+		objectManagerLoader: null
 
 conditionalTags:
 	PHPStan\Reflection\Doctrine\DoctrineSelectableClassReflectionExtension:
@@ -33,11 +33,10 @@ services:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
 	-
 		class: PHPStan\Type\Doctrine\ManagerRegistryGetRepositoryDynamicReturnTypeExtension
-		arguments:
-			repositoryClass: %doctrine.repositoryClass%
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
 	-
 		class: PHPStan\Type\Doctrine\ObjectMetadataResolver
 		arguments:
 			objectManagerLoader: %doctrine.objectManagerLoader%
+			repositoryClass: %doctrine.repositoryClass%

src/Type/Doctrine/GetRepositoryDynamicReturnTypeExtension.php

@@ -45,10 +45,6 @@ public function getTypeFromMethodCall(
 		$objectName = $argType->getValue();
 		$repositoryClass = $this->metadataResolver->getRepositoryClass($objectName);
 
-		if ($repositoryClass === null) {
-			return new MixedType();
-		}
-
 		return new ObjectRepositoryType($objectName, $repositoryClass);
 	}
 

src/Type/Doctrine/ObjectMetadataResolver.php

@@ -12,12 +12,18 @@
 final class ObjectMetadataResolver
 {
 
-	/** @var ObjectManager */
+	/** @var ?ObjectManager */
 	private $objectManager;
 
-	public function __construct(string $objectManagerLoader)
+	/** @var string */
+	private $repositoryClass;
+
+	public function __construct(?string $objectManagerLoader, string $repositoryClass)
 	{
-		$this->objectManager = $this->getObjectManager($objectManagerLoader);
+		if ($objectManagerLoader !== null) {
+			$this->objectManager = $this->getObjectManager($objectManagerLoader);
+		}
+		$this->repositoryClass = $repositoryClass;
 	}
 
 	private function getObjectManager(string $objectManagerLoader): ObjectManager
@@ -29,8 +35,12 @@ private function getObjectManager(string $objectManagerLoader): ObjectManager
 		return require $objectManagerLoader;
 	}
 
-	public function getRepositoryClass(string $className): ?string
+	public function getRepositoryClass(string $className): string
 	{
+		if ($this->objectManager === null) {
+			return $this->repositoryClass;
+		}
+
 		$metadata = $this->objectManager->getClassMetadata($className);
 
 		if ($metadata instanceof ORMMetadata) {
@@ -41,7 +51,7 @@ public function getRepositoryClass(string $className): ?string
 			return $metadata->customRepositoryClassName ?? 'Doctrine\ODM\MongoDB\DocumentRepository';
 		}
 
-		return null;
+		return $this->repositoryClass;
 	}
 
 }