Skip to content

Commit 9106d75

Browse files
committed
ISSUE-12: configs + style
1 parent 3046e3a commit 9106d75

File tree

5 files changed

+17
-14
lines changed

5 files changed

+17
-14
lines changed

src/Domain/Messaging/Message/SubscriberConfirmationMessage.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ class SubscriberConfirmationMessage
1313
private string $uniqueId;
1414
private bool $htmlEmail;
1515

16+
/**
17+
* @SuppressWarnings("BooleanArgumentFlag")
18+
*/
1619
public function __construct(
1720
string $email,
1821
string $uniqueId,

src/Domain/Messaging/MessageHandler/SubscriberConfirmationMessageHandler.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ public function __invoke(SubscriberConfirmationMessage $message): void
3535
$textContent = "Thank you for subscribing!\n\n"
3636
. "Please confirm your subscription by clicking the link below:\n"
3737
. $confirmationLink . "\n\n"
38-
. "If you did not request this subscription, please ignore this email.";
38+
. 'If you did not request this subscription, please ignore this email.';
3939

4040
$htmlContent = '';
4141
if ($message->hasHtmlEmail()) {
42-
$htmlContent = "<p>Thank you for subscribing!</p>"
43-
. "<p>Please confirm your subscription by clicking the link below:</p>"
44-
. "<p><a href=\"" . $confirmationLink . "\">Confirm Subscription</a></p>"
45-
. "<p>If you did not request this subscription, please ignore this email.</p>";
42+
$htmlContent = '<p>Thank you for subscribing!</p>'
43+
. '<p>Please confirm your subscription by clicking the link below:</p>'
44+
. '<p><a href="' . $confirmationLink . '">Confirm Subscription</a></p>'
45+
. '<p>If you did not request this subscription, please ignore this email.</p>';
4646
}
4747

4848
$email = (new Email())

src/Domain/Messaging/Service/EmailService.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,5 +122,4 @@ public function sendBulkEmailSync(
122122
$this->sendEmailSync($email, [], [], [], $attachments);
123123
}
124124
}
125-
126125
}

src/Domain/Subscription/Service/Manager/SubscriberManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class SubscriberManager
2121
private MessageBusInterface $messageBus;
2222

2323
public function __construct(
24-
SubscriberRepository $subscriberRepository,
24+
SubscriberRepository $subscriberRepository,
2525
EntityManagerInterface $entityManager,
2626
MessageBusInterface $messageBus
2727
) {

tests/Unit/Domain/Messaging/MessageHandler/SubscriberConfirmationMessageHandlerTest.php

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ public function testInvokeWithTextEmail(): void
3434
->with($this->callback(function (Email $email) use ($subscriberEmail, $uniqueId) {
3535
$this->assertEquals([$subscriberEmail], $this->getEmailAddresses($email->getTo()));
3636
$this->assertEquals('Please confirm your subscription', $email->getSubject());
37-
37+
3838
$textContent = $email->getTextBody();
3939
$this->assertStringContainsString('Thank you for subscribing', $textContent);
4040
$this->assertStringContainsString($this->confirmationUrl . $uniqueId, $textContent);
41-
41+
4242
$this->assertEmpty($email->getHtmlBody());
43-
43+
4444
return true;
4545
}));
4646

@@ -58,15 +58,16 @@ public function testInvokeWithHtmlEmail(): void
5858
->with($this->callback(function (Email $email) use ($subscriberEmail, $uniqueId) {
5959
$this->assertEquals([$subscriberEmail], $this->getEmailAddresses($email->getTo()));
6060
$this->assertEquals('Please confirm your subscription', $email->getSubject());
61-
61+
6262
$textContent = $email->getTextBody();
6363
$this->assertStringContainsString('Thank you for subscribing', $textContent);
6464
$this->assertStringContainsString($this->confirmationUrl . $uniqueId, $textContent);
65-
65+
6666
$htmlContent = $email->getHtmlBody();
6767
$this->assertStringContainsString('<p>Thank you for subscribing!</p>', $htmlContent);
68-
$this->assertStringContainsString('<a href="' . $this->confirmationUrl . $uniqueId . '">', $htmlContent);
69-
68+
$linkStart = '<a href="' . $this->confirmationUrl . $uniqueId . '">';
69+
$this->assertStringContainsString($linkStart, $htmlContent);
70+
7071
return true;
7172
}));
7273

0 commit comments

Comments
 (0)