Skip to content

Update addAuthenticationHeader usage where used (Composer 2.9 update) #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asgrim opened this issue May 14, 2025 · 2 comments · May be fixed by #248
Open

Update addAuthenticationHeader usage where used (Composer 2.9 update) #244

asgrim opened this issue May 14, 2025 · 2 comments · May be fixed by #248
Assignees
Labels
maintainer investigating This ticket is being investigated by maintainers. Please check with us before contributing PRs etc!

Comments

@asgrim
Copy link
Collaborator

asgrim commented May 14, 2025

Seems that composer/composer#12406 is introducing a new addAuthenticationOptions method (to replace addAuthenticationHeader) which adds support for authenticating using a client cert. This is currently scheduled for Composer 2.9 (tbc)

Check into our codebase and update to use the new method when upgrading to Composer 2.9

@asgrim asgrim self-assigned this May 14, 2025
@asgrim asgrim added the maintainer investigating This ticket is being investigated by maintainers. Please check with us before contributing PRs etc! label May 14, 2025
@rtm-ctrlz
Copy link

As an author of those changes I made a fork of php/pie with a branch containing updated AuthHelper usage, there is a commit rtm-ctrlz/php-pie@165f7d2.
I don't think that right now there is a need for a PR, because those changes are not approved yet, but as soon as they will be accepted - be sure I will make a PR or you could use that commit as some kind of reference.

@asgrim
Copy link
Collaborator Author

asgrim commented May 15, 2025

As an author of those changes I made a fork of php/pie with a branch containing updated AuthHelper usage, there is a commit rtm-ctrlz/php-pie@165f7d2. I don't think that right now there is a need for a PR, because those changes are not approved yet, but as soon as they will be accepted - be sure I will make a PR or you could use that commit as some kind of reference.

That is very helpful, and a PR when ready will be great 👍 thank you!

@rtm-ctrlz rtm-ctrlz linked a pull request May 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer investigating This ticket is being investigated by maintainers. Please check with us before contributing PRs etc!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants