From 3c561995e0243c171bd6c68194d5594df9279303 Mon Sep 17 00:00:00 2001 From: Andreas Heigl Date: Wed, 12 Feb 2020 21:37:23 +0100 Subject: [PATCH 1/8] Deprecate ldap_connect with two parameters ldap_connect should be called with an LDAP-URI as parameter and not with 2 parameters as that allows much more flexibility like differentiating between ldap and ldaps or setting multiple ldap-servers. This change requires one to add null as second parameter in case the underlying library is Oracle and one wants to add wallet-details. --- ext/ldap/ldap.c | 4 ++++ ext/ldap/tests/bug73933.phpt | 2 ++ ext/ldap/tests/ldap_connect_basic.phpt | 3 ++- ext/ldap/tests/ldap_connect_error.phpt | 4 ++++ ext/ldap/tests/ldap_first_attribute_error.phpt | 1 + ext/ldap/tests/ldap_get_option_basic.phpt | 3 ++- ext/ldap/tests/ldap_get_option_package_basic.phpt | 3 ++- ext/ldap/tests/ldap_get_option_variation.phpt | 3 ++- ext/ldap/tests/ldap_rename_error.phpt | 3 ++- ext/ldap/tests/ldap_set_option_basic.phpt | 3 ++- ext/ldap/tests/ldap_set_option_cafiles_basic.phpt | 3 ++- ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt | 3 ++- ext/ldap/tests/ldap_set_option_crlcheck_error.phpt | 3 ++- ext/ldap/tests/ldap_set_option_error.phpt | 1 + ext/ldap/tests/ldap_set_option_keepalive_basic.phpt | 3 ++- ext/ldap/tests/ldap_set_option_reqcert_basic.phpt | 3 ++- ext/ldap/tests/ldap_set_option_reqcert_error.phpt | 3 ++- ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt | 3 ++- ext/ldap/tests/ldap_set_option_variation.phpt | 3 ++- 19 files changed, 40 insertions(+), 14 deletions(-) diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c index b8fb4274215ff..8374e23d8f9e5 100644 --- a/ext/ldap/ldap.c +++ b/ext/ldap/ldap.c @@ -925,6 +925,10 @@ PHP_FUNCTION(ldap_connect) ldap_linkdata *ld; LDAP *ldap = NULL; + if (ZEND_NUM_ARGS() == 2) { + zend_error(E_DEPRECATED, "Usage of ldap_connect with two arguments is deprecated."); + } + #ifdef HAVE_ORALDAP if (ZEND_NUM_ARGS() == 3 || ZEND_NUM_ARGS() == 4) { WRONG_PARAM_COUNT; diff --git a/ext/ldap/tests/bug73933.phpt b/ext/ldap/tests/bug73933.phpt index 0445b7ec27999..a987e64905026 100644 --- a/ext/ldap/tests/bug73933.phpt +++ b/ext/ldap/tests/bug73933.phpt @@ -22,6 +22,8 @@ ldap_close($ldap); ?> --EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d + Warning: ldap_mod_replace(): Modify: Can't contact LDAP server in %sbug73933.php on line %d Warning: ldap_modify_batch(): Batch Modify: Can't contact LDAP server in %sbug73933.php on line %d diff --git a/ext/ldap/tests/ldap_connect_basic.phpt b/ext/ldap/tests/ldap_connect_basic.phpt index 9e85774ead09e..6baa7f0f4a08e 100644 --- a/ext/ldap/tests/ldap_connect_basic.phpt +++ b/ext/ldap/tests/ldap_connect_basic.phpt @@ -13,5 +13,6 @@ $link = ldap_connect($host, $port); var_dump($link); ?> --EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d object(LDAP\Connection)#%d (0) { -} +} \ No newline at end of file diff --git a/ext/ldap/tests/ldap_connect_error.phpt b/ext/ldap/tests/ldap_connect_error.phpt index e44f2c38a49fd..944e0a4cc0f27 100644 --- a/ext/ldap/tests/ldap_connect_error.phpt +++ b/ext/ldap/tests/ldap_connect_error.phpt @@ -22,4 +22,8 @@ $links[1] = ldap_connect($host, $port); Warning: ldap_connect(): Could not create session handle: %s in %s on line %d bool(false) +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d + +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d + Warning: ldap_connect(): Too many open links (1) in %s on line %d diff --git a/ext/ldap/tests/ldap_first_attribute_error.phpt b/ext/ldap/tests/ldap_first_attribute_error.phpt index 0d1175e8f94b0..91e243575a526 100644 --- a/ext/ldap/tests/ldap_first_attribute_error.phpt +++ b/ext/ldap/tests/ldap_first_attribute_error.phpt @@ -17,4 +17,5 @@ try { } ?> --EXPECT-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d ldap_first_attribute(): Argument #2 ($entry) must be of type LDAP\ResultEntry, LDAP\Connection given diff --git a/ext/ldap/tests/ldap_get_option_basic.phpt b/ext/ldap/tests/ldap_get_option_basic.phpt index 1dea64fde9494..09cd18cd9b44e 100644 --- a/ext/ldap/tests/ldap_get_option_basic.phpt +++ b/ext/ldap/tests/ldap_get_option_basic.phpt @@ -18,6 +18,7 @@ var_dump( $option ); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(3) diff --git a/ext/ldap/tests/ldap_get_option_package_basic.phpt b/ext/ldap/tests/ldap_get_option_package_basic.phpt index 1dbbbd206e603..77b6dee649d98 100644 --- a/ext/ldap/tests/ldap_get_option_package_basic.phpt +++ b/ext/ldap/tests/ldap_get_option_package_basic.phpt @@ -14,6 +14,7 @@ var_dump(in_array($optionval, ['GnuTLS', 'OpenSSL', 'MozNSS'])); // This is a read-only option. var_dump(ldap_set_option($link, LDAP_OPT_X_TLS_PACKAGE, 'foo')); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) bool(false) diff --git a/ext/ldap/tests/ldap_get_option_variation.phpt b/ext/ldap/tests/ldap_get_option_variation.phpt index 3af058b20894c..e8b3248e1f412 100644 --- a/ext/ldap/tests/ldap_get_option_variation.phpt +++ b/ext/ldap/tests/ldap_get_option_variation.phpt @@ -48,7 +48,8 @@ var_dump( $option ); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(0) bool(true) diff --git a/ext/ldap/tests/ldap_rename_error.phpt b/ext/ldap/tests/ldap_rename_error.phpt index 833f009bba055..0ca179965eaf9 100644 --- a/ext/ldap/tests/ldap_rename_error.phpt +++ b/ext/ldap/tests/ldap_rename_error.phpt @@ -12,5 +12,6 @@ require "connect.inc"; $link = ldap_connect($host, $port); var_dump(ldap_rename($link, "cn=userNotFound,$base", "cn=userZ", "$base", true)); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) diff --git a/ext/ldap/tests/ldap_set_option_basic.phpt b/ext/ldap/tests/ldap_set_option_basic.phpt index 64ffb1627451c..00368fb10c460 100644 --- a/ext/ldap/tests/ldap_set_option_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_basic.phpt @@ -16,6 +16,7 @@ var_dump(ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version)); ldap_get_option($link, LDAP_OPT_PROTOCOL_VERSION, $option); var_dump($option); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(3) diff --git a/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt b/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt index 29f0e45be23b4..893088e7778c2 100644 --- a/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt @@ -24,7 +24,8 @@ foreach([ var_dump($optionval); } ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) string(8) "/foo/bar" bool(true) diff --git a/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt b/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt index 58c132d8858e1..0f7bab512c526 100644 --- a/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt @@ -15,6 +15,7 @@ var_dump($result); ldap_get_option($link, LDAP_OPT_X_TLS_CIPHER_SUITE, $optionval); var_dump($optionval); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) string(4) "3DES" diff --git a/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt b/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt index a40ba69d79ead..86bf8374fb563 100644 --- a/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt +++ b/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt @@ -11,5 +11,6 @@ $link = ldap_connect($host, $port); $result = ldap_set_option($link, LDAP_OPT_X_TLS_CRLCHECK, 9001); var_dump($result); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) diff --git a/ext/ldap/tests/ldap_set_option_error.phpt b/ext/ldap/tests/ldap_set_option_error.phpt index 04603a4e1905d..de14ac01cbefd 100644 --- a/ext/ldap/tests/ldap_set_option_error.phpt +++ b/ext/ldap/tests/ldap_set_option_error.phpt @@ -36,6 +36,7 @@ foreach ($controls as $control) { var_dump(ldap_set_option($link, 999999, 999999)); ?> --EXPECT-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) ValueError: ldap_set_option(): Control must have an "oid" key TypeError: ldap_set_option(): Argument #3 ($value) must contain only arrays, where each array is a control diff --git a/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt b/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt index 54cf648648af1..a04d8db8d9fa1 100644 --- a/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt @@ -21,7 +21,8 @@ foreach([ var_dump($optionval); } ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(5) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt b/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt index c97f518e6ae48..0baf92251d94b 100644 --- a/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt @@ -23,7 +23,8 @@ foreach([ var_dump($optionval); } ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(0) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_reqcert_error.phpt b/ext/ldap/tests/ldap_set_option_reqcert_error.phpt index fd41a3a3c5b88..89920ca64f893 100644 --- a/ext/ldap/tests/ldap_set_option_reqcert_error.phpt +++ b/ext/ldap/tests/ldap_set_option_reqcert_error.phpt @@ -11,5 +11,6 @@ $link = ldap_connect($host, $port); $result = ldap_set_option($link, LDAP_OPT_X_TLS_REQUIRE_CERT, 9001); var_dump($result); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) diff --git a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt index 92f99e66d671c..3a2b4b6d22c4e 100644 --- a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt @@ -23,7 +23,8 @@ foreach([ var_dump($optionval); } ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(512) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_variation.phpt b/ext/ldap/tests/ldap_set_option_variation.phpt index bc0239da5a32c..3bb9233c6874e 100644 --- a/ext/ldap/tests/ldap_set_option_variation.phpt +++ b/ext/ldap/tests/ldap_set_option_variation.phpt @@ -61,7 +61,8 @@ var_dump( ldap_get_option($link, LDAP_OPT_MATCHED_DN, $option); var_dump($option); ?> ---EXPECT-- +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) bool(true) bool(true) From 7169688a9df8674e3aca6a1e89e0dab542b554d4 Mon Sep 17 00:00:00 2001 From: Andreas Heigl Date: Thu, 13 Feb 2020 15:01:30 +0100 Subject: [PATCH 2/8] Modify all ldap-tests to use ldap_connect right All tests are using ldap_connect now with an URI and not with host and port as two separarte parameters. --- ext/ldap/tests/bug48441.phpt | 4 ++-- ext/ldap/tests/bug73933.phpt | 4 +--- ext/ldap/tests/bug77958.phpt | 4 ++-- ext/ldap/tests/connect.inc | 9 +++++---- ext/ldap/tests/ldap_add_basic.phpt | 4 ++-- ext/ldap/tests/ldap_add_error.phpt | 4 ++-- ext/ldap/tests/ldap_add_ext.phpt | 4 ++-- ext/ldap/tests/ldap_bind_basic.phpt | 2 +- ext/ldap/tests/ldap_bind_error.phpt | 2 +- ext/ldap/tests/ldap_bind_ext.phpt | 2 +- ext/ldap/tests/ldap_bind_variation.phpt | 2 +- ext/ldap/tests/ldap_compare_basic.phpt | 4 ++-- ext/ldap/tests/ldap_compare_error.phpt | 4 ++-- ext/ldap/tests/ldap_connect_basic.phpt | 3 +-- ext/ldap/tests/ldap_connect_error.phpt | 8 ++------ .../tests/ldap_control_paged_results_variation1.phpt | 0 ext/ldap/tests/ldap_controls.phpt | 4 ++-- ext/ldap/tests/ldap_count_entries_basic.phpt | 4 ++-- ext/ldap/tests/ldap_delete_basic.phpt | 4 ++-- ext/ldap/tests/ldap_delete_error.phpt | 4 ++-- ext/ldap/tests/ldap_delete_ext.phpt | 4 ++-- ext/ldap/tests/ldap_errno_basic.phpt | 2 +- ext/ldap/tests/ldap_error_basic.phpt | 2 +- ext/ldap/tests/ldap_exop.phpt | 8 ++++---- ext/ldap/tests/ldap_exop_passwd.phpt | 8 ++++---- ext/ldap/tests/ldap_exop_passwd_error.phpt | 6 +++--- ext/ldap/tests/ldap_exop_refresh.phpt | 6 +++--- ext/ldap/tests/ldap_exop_whoami.phpt | 4 ++-- ext/ldap/tests/ldap_first_attribute_basic.phpt | 4 ++-- ext/ldap/tests/ldap_first_attribute_error.phpt | 3 +-- ext/ldap/tests/ldap_first_entry_basic.phpt | 4 ++-- ext/ldap/tests/ldap_first_reference_basic.phpt | 4 ++-- ext/ldap/tests/ldap_free_result_basic.phpt | 4 ++-- ext/ldap/tests/ldap_get_attributes_basic.phpt | 4 ++-- ext/ldap/tests/ldap_get_dn_basic.phpt | 4 ++-- ext/ldap/tests/ldap_get_entries_basic.phpt | 4 ++-- ext/ldap/tests/ldap_get_entries_variation.phpt | 4 ++-- ext/ldap/tests/ldap_get_option_basic.phpt | 3 +-- ext/ldap/tests/ldap_get_option_controls.phpt | 4 ++-- ext/ldap/tests/ldap_get_option_package_basic.phpt | 3 +-- ext/ldap/tests/ldap_get_option_variation.phpt | 3 +-- ext/ldap/tests/ldap_get_values_len_basic.phpt | 4 ++-- ext/ldap/tests/ldap_get_values_len_error.phpt | 4 ++-- ext/ldap/tests/ldap_list_basic.phpt | 4 ++-- ext/ldap/tests/ldap_mod_add_basic.phpt | 4 ++-- ext/ldap/tests/ldap_mod_add_error.phpt | 4 ++-- ext/ldap/tests/ldap_mod_del_basic.phpt | 4 ++-- ext/ldap/tests/ldap_mod_del_error.phpt | 4 ++-- ext/ldap/tests/ldap_mod_ext.phpt | 4 ++-- ext/ldap/tests/ldap_mod_replace_basic.phpt | 4 ++-- ext/ldap/tests/ldap_mod_replace_error.phpt | 4 ++-- ext/ldap/tests/ldap_modify_basic.phpt | 4 ++-- ext/ldap/tests/ldap_modify_batch_basic.phpt | 4 ++-- ext/ldap/tests/ldap_modify_batch_error.phpt | 4 ++-- ext/ldap/tests/ldap_modify_error.phpt | 4 ++-- ext/ldap/tests/ldap_next_attribute_basic.phpt | 4 ++-- ext/ldap/tests/ldap_next_attribute_error.phpt | 4 ++-- ext/ldap/tests/ldap_next_entry_basic.phpt | 4 ++-- ext/ldap/tests/ldap_next_reference_basic.phpt | 4 ++-- ext/ldap/tests/ldap_option_reqcert_basic.phpt | 2 +- ext/ldap/tests/ldap_option_reqcert_error.phpt | 2 +- ext/ldap/tests/ldap_parse_reference_basic.phpt | 4 ++-- ext/ldap/tests/ldap_parse_result_basic.phpt | 4 ++-- ext/ldap/tests/ldap_parse_result_controls.phpt | 4 ++-- ext/ldap/tests/ldap_read_basic.phpt | 4 ++-- ext/ldap/tests/ldap_rename_basic.phpt | 4 ++-- ext/ldap/tests/ldap_rename_error.phpt | 3 +-- ext/ldap/tests/ldap_rename_ext.phpt | 4 ++-- ext/ldap/tests/ldap_sasl_bind_basic.phpt | 4 ++-- ext/ldap/tests/ldap_sasl_bind_error.phpt | 2 +- ext/ldap/tests/ldap_search_basic.phpt | 4 ++-- ext/ldap/tests/ldap_search_error.phpt | 2 +- ext/ldap/tests/ldap_search_overrides.phpt | 4 ++-- ext/ldap/tests/ldap_search_paged_result_controls.phpt | 4 ++-- ext/ldap/tests/ldap_search_sort_controls.phpt | 4 ++-- ext/ldap/tests/ldap_search_variation1.phpt | 4 ++-- ext/ldap/tests/ldap_search_variation2.phpt | 4 ++-- ext/ldap/tests/ldap_search_variation3.phpt | 4 ++-- ext/ldap/tests/ldap_search_variation4.phpt | 4 ++-- ext/ldap/tests/ldap_search_variation5.phpt | 4 ++-- ext/ldap/tests/ldap_search_variation6.phpt | 4 ++-- ext/ldap/tests/ldap_set_option_basic.phpt | 3 +-- ext/ldap/tests/ldap_set_option_cafiles_basic.phpt | 3 +-- ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt | 3 +-- ext/ldap/tests/ldap_set_option_crlcheck_basic.phpt | 4 ++-- ext/ldap/tests/ldap_set_option_crlcheck_error.phpt | 3 +-- ext/ldap/tests/ldap_set_option_error.phpt | 3 +-- ext/ldap/tests/ldap_set_option_keepalive_basic.phpt | 3 +-- ext/ldap/tests/ldap_set_option_reqcert_basic.phpt | 3 +-- ext/ldap/tests/ldap_set_option_reqcert_error.phpt | 3 +-- .../tests/ldap_set_option_tls_protocol_min_basic.phpt | 3 +-- ext/ldap/tests/ldap_set_option_variation.phpt | 3 +-- ext/ldap/tests/ldap_set_rebind_proc_basic.phpt | 2 +- ext/ldap/tests/ldap_set_rebind_proc_error.phpt | 4 ++-- ext/ldap/tests/ldap_start_tls_basic.phpt | 2 +- ext/ldap/tests/ldap_unbind_basic.phpt | 2 +- ext/ldap/tests/ldap_unbind_variation.phpt | 2 +- ext/ldap/tests/skipifbindfailure.inc | 2 +- ext/ldap/tests/skipifcontrol.inc | 4 ++-- 99 files changed, 173 insertions(+), 194 deletions(-) create mode 100644 ext/ldap/tests/ldap_control_paged_results_variation1.phpt diff --git a/ext/ldap/tests/bug48441.phpt b/ext/ldap/tests/bug48441.phpt index 576ec2df1e188..d3b5dcbef0181 100644 --- a/ext/ldap/tests/bug48441.phpt +++ b/ext/ldap/tests/bug48441.phpt @@ -12,7 +12,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/bug73933.phpt b/ext/ldap/tests/bug73933.phpt index a987e64905026..d5110da07cc77 100644 --- a/ext/ldap/tests/bug73933.phpt +++ b/ext/ldap/tests/bug73933.phpt @@ -5,7 +5,7 @@ ldap --FILE-- array(0), @@ -22,8 +22,6 @@ ldap_close($ldap); ?> --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d - Warning: ldap_mod_replace(): Modify: Can't contact LDAP server in %sbug73933.php on line %d Warning: ldap_modify_batch(): Batch Modify: Can't contact LDAP server in %sbug73933.php on line %d diff --git a/ext/ldap/tests/bug77958.phpt b/ext/ldap/tests/bug77958.phpt index da6edca348b79..c8ecc9bbc02d0 100644 --- a/ext/ldap/tests/bug77958.phpt +++ b/ext/ldap/tests/bug77958.phpt @@ -10,7 +10,7 @@ ldap diff --git a/ext/ldap/tests/connect.inc b/ext/ldap/tests/connect.inc index e3a9d1c777dc4..888c4da56d57c 100644 --- a/ext/ldap/tests/connect.inc +++ b/ext/ldap/tests/connect.inc @@ -7,6 +7,7 @@ Change the LDAP_TEST_* environment values if you want to use another configurati $host = getenv("LDAP_TEST_HOST") ?: "localhost"; $port = getenv("LDAP_TEST_PORT") ?: 389; +$uri = getenv("LDAP_TEST_URI") ?: 'ldap://localhost:389'; $base = getenv("LDAP_TEST_BASE") ?: "dc=my-domain,dc=com"; $user = getenv("LDAP_TEST_USER") ?: "cn=Manager,$base"; $passwd = getenv("LDAP_TEST_PASSWD") ?: "secret"; @@ -15,15 +16,15 @@ $sasl_passwd = getenv("LDAP_TEST_SASL_PASSWD") ?: "oops"; $protocol_version = getenv("LDAP_TEST_OPT_PROTOCOL_VERSION") ?: 3; $skip_on_bind_failure = getenv("LDAP_TEST_SKIP_BIND_FAILURE") ?: true; -function ldap_connect_and_bind($host, $port, $user, $passwd, $protocol_version) { - $link = ldap_connect($host, $port); +function ldap_connect_and_bind($uri, $user, $passwd, $protocol_version) { + $link = ldap_connect($uri); ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version); ldap_bind($link, $user, $passwd); return $link; } -function test_bind($host, $port, $user, $passwd, $protocol_version) { - $link = ldap_connect($host, $port); +function test_bind($uri, $user, $passwd, $protocol_version) { + $link = ldap_connect($uri); ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version); return ldap_bind($link, $user, $passwd); } diff --git a/ext/ldap/tests/ldap_add_basic.phpt b/ext/ldap/tests/ldap_add_basic.phpt index 551dea60836df..7c3261b8c89d2 100644 --- a/ext/ldap/tests/ldap_add_basic.phpt +++ b/ext/ldap/tests/ldap_add_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_add_error.phpt b/ext/ldap/tests/ldap_add_error.phpt index 8f75933d6f503..d78276eca3e54 100644 --- a/ext/ldap/tests/ldap_add_error.phpt +++ b/ext/ldap/tests/ldap_add_error.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_add_ext.phpt b/ext/ldap/tests/ldap_add_ext.phpt index d60b6aa65eb72..fa02e296d00f2 100644 --- a/ext/ldap/tests/ldap_add_ext.phpt +++ b/ext/ldap/tests/ldap_add_ext.phpt @@ -14,7 +14,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_POST_READ); diff --git a/ext/ldap/tests/ldap_bind_basic.phpt b/ext/ldap/tests/ldap_bind_basic.phpt index ad4090ee08959..eaf22b096c1da 100644 --- a/ext/ldap/tests/ldap_bind_basic.phpt +++ b/ext/ldap/tests/ldap_bind_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_bind_error.phpt b/ext/ldap/tests/ldap_bind_error.phpt index b4465be3db713..7567ce86da12c 100644 --- a/ext/ldap/tests/ldap_bind_error.phpt +++ b/ext/ldap/tests/ldap_bind_error.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_compare_basic.phpt b/ext/ldap/tests/ldap_compare_basic.phpt index b99e709a4936e..b276ba5706f0b 100644 --- a/ext/ldap/tests/ldap_compare_basic.phpt +++ b/ext/ldap/tests/ldap_compare_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_compare_error.phpt b/ext/ldap/tests/ldap_compare_error.phpt index bc9389f655cdd..63383dfaf536e 100644 --- a/ext/ldap/tests/ldap_compare_error.phpt +++ b/ext/ldap/tests/ldap_compare_error.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_connect_basic.phpt b/ext/ldap/tests/ldap_connect_basic.phpt index 6baa7f0f4a08e..4aa6f21e6bcf3 100644 --- a/ext/ldap/tests/ldap_connect_basic.phpt +++ b/ext/ldap/tests/ldap_connect_basic.phpt @@ -9,10 +9,9 @@ ldap --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d object(LDAP\Connection)#%d (0) { } \ No newline at end of file diff --git a/ext/ldap/tests/ldap_connect_error.phpt b/ext/ldap/tests/ldap_connect_error.phpt index 944e0a4cc0f27..8efecaee072b6 100644 --- a/ext/ldap/tests/ldap_connect_error.phpt +++ b/ext/ldap/tests/ldap_connect_error.phpt @@ -15,15 +15,11 @@ require "connect.inc"; var_dump(ldap_connect("ldap://$host:$port/$base")); $links = array(); -$links[0] = ldap_connect($host, $port); -$links[1] = ldap_connect($host, $port); +$links[0] = ldap_connect($uri); +$links[1] = ldap_connect($uri); ?> --EXPECTF-- Warning: ldap_connect(): Could not create session handle: %s in %s on line %d bool(false) -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d - -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d - Warning: ldap_connect(): Too many open links (1) in %s on line %d diff --git a/ext/ldap/tests/ldap_control_paged_results_variation1.phpt b/ext/ldap/tests/ldap_control_paged_results_variation1.phpt new file mode 100644 index 0000000000000..e69de29bb2d1d diff --git a/ext/ldap/tests/ldap_controls.phpt b/ext/ldap/tests/ldap_controls.phpt index f79b7ff7bc2e3..fc5482278c33c 100644 --- a/ext/ldap/tests/ldap_controls.phpt +++ b/ext/ldap/tests/ldap_controls.phpt @@ -15,7 +15,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_VALUESRETURNFILTER); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_count_entries_basic.phpt b/ext/ldap/tests/ldap_count_entries_basic.phpt index 80f21996e2672..297e50a3a7fac 100644 --- a/ext/ldap/tests/ldap_count_entries_basic.phpt +++ b/ext/ldap/tests/ldap_count_entries_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_delete_basic.phpt b/ext/ldap/tests/ldap_delete_basic.phpt index 491c12f6fdfc8..fad69f60c84bb 100644 --- a/ext/ldap/tests/ldap_delete_basic.phpt +++ b/ext/ldap/tests/ldap_delete_basic.phpt @@ -11,7 +11,7 @@ ldap array( "top", @@ -30,7 +30,7 @@ var_dump( diff --git a/ext/ldap/tests/ldap_delete_error.phpt b/ext/ldap/tests/ldap_delete_error.phpt index 6333692088abd..7323129e14c14 100644 --- a/ext/ldap/tests/ldap_delete_error.phpt +++ b/ext/ldap/tests/ldap_delete_error.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- Warning: ldap_delete(): Delete: Invalid DN syntax in %s on line %d diff --git a/ext/ldap/tests/ldap_delete_ext.phpt b/ext/ldap/tests/ldap_delete_ext.phpt index 41800cd53686e..a7f7bff839212 100644 --- a/ext/ldap/tests/ldap_delete_ext.phpt +++ b/ext/ldap/tests/ldap_delete_ext.phpt @@ -14,7 +14,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_PRE_READ); array( "top", @@ -39,7 +39,7 @@ var_dump( diff --git a/ext/ldap/tests/ldap_errno_basic.phpt b/ext/ldap/tests/ldap_errno_basic.phpt index 78f9a83f50a47..feaef65d4b23f 100644 --- a/ext/ldap/tests/ldap_errno_basic.phpt +++ b/ext/ldap/tests/ldap_errno_basic.phpt @@ -11,7 +11,7 @@ ldap array( "top", diff --git a/ext/ldap/tests/ldap_error_basic.phpt b/ext/ldap/tests/ldap_error_basic.phpt index 903196090588f..37bbc37891ca2 100644 --- a/ext/ldap/tests/ldap_error_basic.phpt +++ b/ext/ldap/tests/ldap_error_basic.phpt @@ -11,7 +11,7 @@ ldap array( "top", diff --git a/ext/ldap/tests/ldap_exop.phpt b/ext/ldap/tests/ldap_exop.phpt index 80ce871399303..92d85e7d97977 100644 --- a/ext/ldap/tests/ldap_exop.phpt +++ b/ext/ldap/tests/ldap_exop.phpt @@ -10,7 +10,7 @@ ldap --CLEAN-- diff --git a/ext/ldap/tests/ldap_exop_passwd.phpt b/ext/ldap/tests/ldap_exop_passwd.phpt index 5ce1d0338de43..0bb20e676955e 100644 --- a/ext/ldap/tests/ldap_exop_passwd.phpt +++ b/ext/ldap/tests/ldap_exop_passwd.phpt @@ -10,7 +10,7 @@ ldap --CLEAN-- diff --git a/ext/ldap/tests/ldap_exop_passwd_error.phpt b/ext/ldap/tests/ldap_exop_passwd_error.phpt index 95ade778594d6..1eba053c66a2a 100644 --- a/ext/ldap/tests/ldap_exop_passwd_error.phpt +++ b/ext/ldap/tests/ldap_exop_passwd_error.phpt @@ -10,20 +10,20 @@ ldap --CLEAN-- diff --git a/ext/ldap/tests/ldap_exop_refresh.phpt b/ext/ldap/tests/ldap_exop_refresh.phpt index 8d3c614a65b9f..7a77e6663b240 100644 --- a/ext/ldap/tests/ldap_exop_refresh.phpt +++ b/ext/ldap/tests/ldap_exop_refresh.phpt @@ -7,7 +7,7 @@ ldap --SKIPIF-- diff --git a/ext/ldap/tests/ldap_exop_whoami.phpt b/ext/ldap/tests/ldap_exop_whoami.phpt index ef6cc568b0433..3c17ed099768a 100644 --- a/ext/ldap/tests/ldap_exop_whoami.phpt +++ b/ext/ldap/tests/ldap_exop_whoami.phpt @@ -10,7 +10,7 @@ ldap diff --git a/ext/ldap/tests/ldap_first_attribute_basic.phpt b/ext/ldap/tests/ldap_first_attribute_basic.phpt index e9552ce547c30..adde35f3d9d93 100644 --- a/ext/ldap/tests/ldap_first_attribute_basic.phpt +++ b/ext/ldap/tests/ldap_first_attribute_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_first_attribute_error.phpt b/ext/ldap/tests/ldap_first_attribute_error.phpt index 91e243575a526..2776838501d3b 100644 --- a/ext/ldap/tests/ldap_first_attribute_error.phpt +++ b/ext/ldap/tests/ldap_first_attribute_error.phpt @@ -9,7 +9,7 @@ ldap --EXPECT-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d ldap_first_attribute(): Argument #2 ($entry) must be of type LDAP\ResultEntry, LDAP\Connection given diff --git a/ext/ldap/tests/ldap_first_entry_basic.phpt b/ext/ldap/tests/ldap_first_entry_basic.phpt index a69165997d25d..29f6d9220feb7 100644 --- a/ext/ldap/tests/ldap_first_entry_basic.phpt +++ b/ext/ldap/tests/ldap_first_entry_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_first_reference_basic.phpt b/ext/ldap/tests/ldap_first_reference_basic.phpt index 7c4cb5fec5e5b..486f5f8c6eee0 100644 --- a/ext/ldap/tests/ldap_first_reference_basic.phpt +++ b/ext/ldap/tests/ldap_first_reference_basic.phpt @@ -10,7 +10,7 @@ ldap --FILE-- array("extensibleObject", "referral"), @@ -28,7 +28,7 @@ var_dump($refs); LDAP_CONTROL_MANAGEDSAIT, 'iscritical' => TRUE]]); remove_dummy_data($link, $base); diff --git a/ext/ldap/tests/ldap_free_result_basic.phpt b/ext/ldap/tests/ldap_free_result_basic.phpt index 788a81221e316..cae61ca2775b9 100644 --- a/ext/ldap/tests/ldap_free_result_basic.phpt +++ b/ext/ldap/tests/ldap_free_result_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_get_attributes_basic.phpt b/ext/ldap/tests/ldap_get_attributes_basic.phpt index 3c786edac746b..abfca7227856a 100644 --- a/ext/ldap/tests/ldap_get_attributes_basic.phpt +++ b/ext/ldap/tests/ldap_get_attributes_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_get_dn_basic.phpt b/ext/ldap/tests/ldap_get_dn_basic.phpt index 2f2daa173ca4d..16971af183143 100644 --- a/ext/ldap/tests/ldap_get_dn_basic.phpt +++ b/ext/ldap/tests/ldap_get_dn_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_get_entries_basic.phpt b/ext/ldap/tests/ldap_get_entries_basic.phpt index 0807519b60e45..4f86c5d8e3ca4 100644 --- a/ext/ldap/tests/ldap_get_entries_basic.phpt +++ b/ext/ldap/tests/ldap_get_entries_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_get_entries_variation.phpt b/ext/ldap/tests/ldap_get_entries_variation.phpt index c078dc24a5a14..230f56680da1e 100644 --- a/ext/ldap/tests/ldap_get_entries_variation.phpt +++ b/ext/ldap/tests/ldap_get_entries_variation.phpt @@ -11,7 +11,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_get_option_basic.phpt b/ext/ldap/tests/ldap_get_option_basic.phpt index 09cd18cd9b44e..c4a612843105d 100644 --- a/ext/ldap/tests/ldap_get_option_basic.phpt +++ b/ext/ldap/tests/ldap_get_option_basic.phpt @@ -9,7 +9,7 @@ ldap --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(3) diff --git a/ext/ldap/tests/ldap_get_option_controls.phpt b/ext/ldap/tests/ldap_get_option_controls.phpt index 8a348baaa8ebc..4542cbb4bc977 100644 --- a/ext/ldap/tests/ldap_get_option_controls.phpt +++ b/ext/ldap/tests/ldap_get_option_controls.phpt @@ -12,7 +12,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_get_option_package_basic.phpt b/ext/ldap/tests/ldap_get_option_package_basic.phpt index 77b6dee649d98..3899e824612b6 100644 --- a/ext/ldap/tests/ldap_get_option_package_basic.phpt +++ b/ext/ldap/tests/ldap_get_option_package_basic.phpt @@ -7,7 +7,7 @@ ldap --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) bool(false) diff --git a/ext/ldap/tests/ldap_get_option_variation.phpt b/ext/ldap/tests/ldap_get_option_variation.phpt index e8b3248e1f412..6cd9708e1e5a0 100644 --- a/ext/ldap/tests/ldap_get_option_variation.phpt +++ b/ext/ldap/tests/ldap_get_option_variation.phpt @@ -9,7 +9,7 @@ ldap --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(0) bool(true) diff --git a/ext/ldap/tests/ldap_get_values_len_basic.phpt b/ext/ldap/tests/ldap_get_values_len_basic.phpt index 4d4c43bbfd36a..99328a712b25e 100644 --- a/ext/ldap/tests/ldap_get_values_len_basic.phpt +++ b/ext/ldap/tests/ldap_get_values_len_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_get_values_len_error.phpt b/ext/ldap/tests/ldap_get_values_len_error.phpt index 3b99e20a23646..eb18f5adf466b 100644 --- a/ext/ldap/tests/ldap_get_values_len_error.phpt +++ b/ext/ldap/tests/ldap_get_values_len_error.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_list_basic.phpt b/ext/ldap/tests/ldap_list_basic.phpt index 704a1d712c2c6..cba341f2b2a94 100644 --- a/ext/ldap/tests/ldap_list_basic.phpt +++ b/ext/ldap/tests/ldap_list_basic.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_mod_add_basic.phpt b/ext/ldap/tests/ldap_mod_add_basic.phpt index 437a2103c407e..ec2e5a3066ea9 100644 --- a/ext/ldap/tests/ldap_mod_add_basic.phpt +++ b/ext/ldap/tests/ldap_mod_add_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_mod_add_error.phpt b/ext/ldap/tests/ldap_mod_add_error.phpt index bbd9faf86b002..47aafb01612ad 100644 --- a/ext/ldap/tests/ldap_mod_add_error.phpt +++ b/ext/ldap/tests/ldap_mod_add_error.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_mod_del_basic.phpt b/ext/ldap/tests/ldap_mod_del_basic.phpt index 6972bc3dd9e08..1888bde25b4af 100644 --- a/ext/ldap/tests/ldap_mod_del_basic.phpt +++ b/ext/ldap/tests/ldap_mod_del_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_mod_del_error.phpt b/ext/ldap/tests/ldap_mod_del_error.phpt index 9e6af834cb2f2..2a6e81ba1492e 100644 --- a/ext/ldap/tests/ldap_mod_del_error.phpt +++ b/ext/ldap/tests/ldap_mod_del_error.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_mod_ext.phpt b/ext/ldap/tests/ldap_mod_ext.phpt index ae86f6ce005c6..23065c2513224 100644 --- a/ext/ldap/tests/ldap_mod_ext.phpt +++ b/ext/ldap/tests/ldap_mod_ext.phpt @@ -16,7 +16,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_POST_READ); diff --git a/ext/ldap/tests/ldap_mod_replace_basic.phpt b/ext/ldap/tests/ldap_mod_replace_basic.phpt index c871f51c07576..afe65b7b652ef 100644 --- a/ext/ldap/tests/ldap_mod_replace_basic.phpt +++ b/ext/ldap/tests/ldap_mod_replace_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_mod_replace_error.phpt b/ext/ldap/tests/ldap_mod_replace_error.phpt index c6228f451ac3e..78599d2240980 100644 --- a/ext/ldap/tests/ldap_mod_replace_error.phpt +++ b/ext/ldap/tests/ldap_mod_replace_error.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- Warning: ldap_mod_replace(): Modify: No such object in %s on line %d diff --git a/ext/ldap/tests/ldap_modify_basic.phpt b/ext/ldap/tests/ldap_modify_basic.phpt index cbb1866840cc4..fcd96da7f7547 100644 --- a/ext/ldap/tests/ldap_modify_basic.phpt +++ b/ext/ldap/tests/ldap_modify_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_modify_batch_basic.phpt b/ext/ldap/tests/ldap_modify_batch_basic.phpt index 193deb770013c..5f5cf4ca2ade2 100644 --- a/ext/ldap/tests/ldap_modify_batch_basic.phpt +++ b/ext/ldap/tests/ldap_modify_batch_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_modify_batch_error.phpt b/ext/ldap/tests/ldap_modify_batch_error.phpt index cabd42b9fcb8a..bce62cafb2791 100644 --- a/ext/ldap/tests/ldap_modify_batch_error.phpt +++ b/ext/ldap/tests/ldap_modify_batch_error.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_modify_error.phpt b/ext/ldap/tests/ldap_modify_error.phpt index ec4f1c93af55c..a4807dfd8acc0 100644 --- a/ext/ldap/tests/ldap_modify_error.phpt +++ b/ext/ldap/tests/ldap_modify_error.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_next_attribute_basic.phpt b/ext/ldap/tests/ldap_next_attribute_basic.phpt index af070b9133e47..56dfcee1e9154 100644 --- a/ext/ldap/tests/ldap_next_attribute_basic.phpt +++ b/ext/ldap/tests/ldap_next_attribute_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_next_attribute_error.phpt b/ext/ldap/tests/ldap_next_attribute_error.phpt index 1a613b9bcd5aa..46ea48fd059d7 100644 --- a/ext/ldap/tests/ldap_next_attribute_error.phpt +++ b/ext/ldap/tests/ldap_next_attribute_error.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_next_entry_basic.phpt b/ext/ldap/tests/ldap_next_entry_basic.phpt index 7404ce1ba37ed..2a460ad265200 100644 --- a/ext/ldap/tests/ldap_next_entry_basic.phpt +++ b/ext/ldap/tests/ldap_next_entry_basic.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_next_reference_basic.phpt b/ext/ldap/tests/ldap_next_reference_basic.phpt index fc1d08f0aaf39..e645752faf532 100644 --- a/ext/ldap/tests/ldap_next_reference_basic.phpt +++ b/ext/ldap/tests/ldap_next_reference_basic.phpt @@ -10,7 +10,7 @@ ldap --FILE-- array("extensibleObject", "referral"), @@ -33,7 +33,7 @@ var_dump($refs); LDAP_CONTROL_MANAGEDSAIT, 'iscritical' => TRUE]]); ldap_delete($link, "cn=userref2,$base", [['oid' => LDAP_CONTROL_MANAGEDSAIT, 'iscritical' => TRUE]]); diff --git a/ext/ldap/tests/ldap_option_reqcert_basic.phpt b/ext/ldap/tests/ldap_option_reqcert_basic.phpt index 467c9d9e0936f..0240d8a77b9bf 100644 --- a/ext/ldap/tests/ldap_option_reqcert_basic.phpt +++ b/ext/ldap/tests/ldap_option_reqcert_basic.phpt @@ -14,7 +14,7 @@ require "connect.inc"; ldap_set_option(null, LDAP_OPT_X_TLS_REQUIRE_CERT, LDAP_OPT_X_TLS_NEVER); -$link = ldap_connect($host, $port); +$link = ldap_connect($uri); ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version); var_dump(@ldap_bind($link, $user, $passwd)); diff --git a/ext/ldap/tests/ldap_option_reqcert_error.phpt b/ext/ldap/tests/ldap_option_reqcert_error.phpt index a00476e48968b..5f75ba0bc9615 100644 --- a/ext/ldap/tests/ldap_option_reqcert_error.phpt +++ b/ext/ldap/tests/ldap_option_reqcert_error.phpt @@ -14,7 +14,7 @@ require "connect.inc"; ldap_set_option(null, LDAP_OPT_X_TLS_REQUIRE_CERT, LDAP_OPT_X_TLS_HARD); -$link = ldap_connect($host, $port); +$link = ldap_connect($uri); ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version); var_dump(@ldap_bind($link, $user, $passwd)); diff --git a/ext/ldap/tests/ldap_parse_reference_basic.phpt b/ext/ldap/tests/ldap_parse_reference_basic.phpt index 310f1f09384a9..1b863c3ddf151 100644 --- a/ext/ldap/tests/ldap_parse_reference_basic.phpt +++ b/ext/ldap/tests/ldap_parse_reference_basic.phpt @@ -10,7 +10,7 @@ ldap --FILE-- array("extensibleObject", "referral"), @@ -30,7 +30,7 @@ var_dump( "2.16.840.1.113730.3.4.2"))); ldap_delete($link, "cn=userref,$base"); diff --git a/ext/ldap/tests/ldap_parse_result_basic.phpt b/ext/ldap/tests/ldap_parse_result_basic.phpt index cc93a9f9ef650..46b98ae6d9eea 100644 --- a/ext/ldap/tests/ldap_parse_result_basic.phpt +++ b/ext/ldap/tests/ldap_parse_result_basic.phpt @@ -11,7 +11,7 @@ ldap array("extensibleObject", "referral"), @@ -29,7 +29,7 @@ var_dump( LDAP_CONTROL_MANAGEDSAIT, 'iscritical' => TRUE]]); remove_dummy_data($link, $base); diff --git a/ext/ldap/tests/ldap_parse_result_controls.phpt b/ext/ldap/tests/ldap_parse_result_controls.phpt index b6cd5a3bcb1ad..1dcfc7f86f838 100644 --- a/ext/ldap/tests/ldap_parse_result_controls.phpt +++ b/ext/ldap/tests/ldap_parse_result_controls.phpt @@ -14,7 +14,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_PAGEDRESULTS); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_read_basic.phpt b/ext/ldap/tests/ldap_read_basic.phpt index 86d790a82a676..9953e2955c96c 100644 --- a/ext/ldap/tests/ldap_read_basic.phpt +++ b/ext/ldap/tests/ldap_read_basic.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_rename_basic.phpt b/ext/ldap/tests/ldap_rename_basic.phpt index 1a6f0626c0f2b..26404ce12bb04 100644 --- a/ext/ldap/tests/ldap_rename_basic.phpt +++ b/ext/ldap/tests/ldap_rename_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_rename_error.phpt b/ext/ldap/tests/ldap_rename_error.phpt index 0ca179965eaf9..257f844ab2688 100644 --- a/ext/ldap/tests/ldap_rename_error.phpt +++ b/ext/ldap/tests/ldap_rename_error.phpt @@ -9,9 +9,8 @@ ldap --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) diff --git a/ext/ldap/tests/ldap_rename_ext.phpt b/ext/ldap/tests/ldap_rename_ext.phpt index f8b80a7f25520..583346a350618 100644 --- a/ext/ldap/tests/ldap_rename_ext.phpt +++ b/ext/ldap/tests/ldap_rename_ext.phpt @@ -15,7 +15,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_POST_READ); diff --git a/ext/ldap/tests/ldap_sasl_bind_basic.phpt b/ext/ldap/tests/ldap_sasl_bind_basic.phpt index 205b8992cc7d9..03fffb84c0dc5 100644 --- a/ext/ldap/tests/ldap_sasl_bind_basic.phpt +++ b/ext/ldap/tests/ldap_sasl_bind_basic.phpt @@ -9,7 +9,7 @@ ldap diff --git a/ext/ldap/tests/ldap_sasl_bind_error.phpt b/ext/ldap/tests/ldap_sasl_bind_error.phpt index 79fbf323b4306..348a2345f5f14 100644 --- a/ext/ldap/tests/ldap_sasl_bind_error.phpt +++ b/ext/ldap/tests/ldap_sasl_bind_error.phpt @@ -16,7 +16,7 @@ $link = ldap_connect_and_bind($host, $port, $user, $passwd, $protocol_version); insert_dummy_data($link, $base); ldap_unbind($link); -$link = ldap_connect($host, $port); +$link = ldap_connect($uri); ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version); // Invalid DN diff --git a/ext/ldap/tests/ldap_search_basic.phpt b/ext/ldap/tests/ldap_search_basic.phpt index 809b18dcd8e72..19314533ad47d 100644 --- a/ext/ldap/tests/ldap_search_basic.phpt +++ b/ext/ldap/tests/ldap_search_basic.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_error.phpt b/ext/ldap/tests/ldap_search_error.phpt index 63d49eeac70cb..659b8a6c0664b 100644 --- a/ext/ldap/tests/ldap_search_error.phpt +++ b/ext/ldap/tests/ldap_search_error.phpt @@ -11,7 +11,7 @@ ldap --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_paged_result_controls.phpt b/ext/ldap/tests/ldap_search_paged_result_controls.phpt index 09865f9071b5b..c6f2baf8e11d0 100644 --- a/ext/ldap/tests/ldap_search_paged_result_controls.phpt +++ b/ext/ldap/tests/ldap_search_paged_result_controls.phpt @@ -14,7 +14,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_PAGEDRESULTS); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_sort_controls.phpt b/ext/ldap/tests/ldap_search_sort_controls.phpt index b19364e18fb3d..0b39c02c66133 100644 --- a/ext/ldap/tests/ldap_search_sort_controls.phpt +++ b/ext/ldap/tests/ldap_search_sort_controls.phpt @@ -15,7 +15,7 @@ skipifunsupportedcontrol(LDAP_CONTROL_VLVREQUEST); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_variation1.phpt b/ext/ldap/tests/ldap_search_variation1.phpt index 3e9a9568308b1..01f7fddff3af5 100644 --- a/ext/ldap/tests/ldap_search_variation1.phpt +++ b/ext/ldap/tests/ldap_search_variation1.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_variation2.phpt b/ext/ldap/tests/ldap_search_variation2.phpt index 25e021b9414b4..eebecb0713fce 100644 --- a/ext/ldap/tests/ldap_search_variation2.phpt +++ b/ext/ldap/tests/ldap_search_variation2.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_variation3.phpt b/ext/ldap/tests/ldap_search_variation3.phpt index f4111aa8636e7..d8603a5176443 100644 --- a/ext/ldap/tests/ldap_search_variation3.phpt +++ b/ext/ldap/tests/ldap_search_variation3.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_variation4.phpt b/ext/ldap/tests/ldap_search_variation4.phpt index bfd758e04be2a..a98be97d9695a 100644 --- a/ext/ldap/tests/ldap_search_variation4.phpt +++ b/ext/ldap/tests/ldap_search_variation4.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_variation5.phpt b/ext/ldap/tests/ldap_search_variation5.phpt index bb7fd78627a8e..6552aac931580 100644 --- a/ext/ldap/tests/ldap_search_variation5.phpt +++ b/ext/ldap/tests/ldap_search_variation5.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_search_variation6.phpt b/ext/ldap/tests/ldap_search_variation6.phpt index 1b55325edd713..96b792889eee0 100644 --- a/ext/ldap/tests/ldap_search_variation6.phpt +++ b/ext/ldap/tests/ldap_search_variation6.phpt @@ -14,7 +14,7 @@ require_once('skipifbindfailure.inc'); --EXPECTF-- diff --git a/ext/ldap/tests/ldap_set_option_basic.phpt b/ext/ldap/tests/ldap_set_option_basic.phpt index 00368fb10c460..cbc3b3addbd24 100644 --- a/ext/ldap/tests/ldap_set_option_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_basic.phpt @@ -9,7 +9,7 @@ ldap --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(3) diff --git a/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt b/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt index 893088e7778c2..8d1e71af90139 100644 --- a/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt @@ -7,7 +7,7 @@ ldap --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) string(8) "/foo/bar" bool(true) diff --git a/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt b/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt index 0f7bab512c526..87a6a61d5d6dc 100644 --- a/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt @@ -7,7 +7,7 @@ ldap --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) string(4) "3DES" diff --git a/ext/ldap/tests/ldap_set_option_crlcheck_basic.phpt b/ext/ldap/tests/ldap_set_option_crlcheck_basic.phpt index 5844766328917..38f81bbcddabb 100644 --- a/ext/ldap/tests/ldap_set_option_crlcheck_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_crlcheck_basic.phpt @@ -7,7 +7,7 @@ ldap --SKIPIF-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) diff --git a/ext/ldap/tests/ldap_set_option_error.phpt b/ext/ldap/tests/ldap_set_option_error.phpt index de14ac01cbefd..fa66e348c46ba 100644 --- a/ext/ldap/tests/ldap_set_option_error.phpt +++ b/ext/ldap/tests/ldap_set_option_error.phpt @@ -9,7 +9,7 @@ ldap "1.2.752.58.10.1", "iscritical" => true), @@ -36,7 +36,6 @@ foreach ($controls as $control) { var_dump(ldap_set_option($link, 999999, 999999)); ?> --EXPECT-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) ValueError: ldap_set_option(): Control must have an "oid" key TypeError: ldap_set_option(): Argument #3 ($value) must contain only arrays, where each array is a control diff --git a/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt b/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt index a04d8db8d9fa1..b2d1e89b4a1c4 100644 --- a/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt @@ -7,7 +7,7 @@ ldap --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(5) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt b/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt index 0baf92251d94b..66087bda8c739 100644 --- a/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt @@ -7,7 +7,7 @@ Edwin Hoksberg --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(0) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_reqcert_error.phpt b/ext/ldap/tests/ldap_set_option_reqcert_error.phpt index 89920ca64f893..7d019d7cde2cc 100644 --- a/ext/ldap/tests/ldap_set_option_reqcert_error.phpt +++ b/ext/ldap/tests/ldap_set_option_reqcert_error.phpt @@ -7,10 +7,9 @@ ldap --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(false) diff --git a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt index 3a2b4b6d22c4e..9392b11b3c21c 100644 --- a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt @@ -7,7 +7,7 @@ ldap --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) int(512) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_variation.phpt b/ext/ldap/tests/ldap_set_option_variation.phpt index 3bb9233c6874e..8fe9c631afb27 100644 --- a/ext/ldap/tests/ldap_set_option_variation.phpt +++ b/ext/ldap/tests/ldap_set_option_variation.phpt @@ -9,7 +9,7 @@ ldap --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d bool(true) bool(true) bool(true) diff --git a/ext/ldap/tests/ldap_set_rebind_proc_basic.phpt b/ext/ldap/tests/ldap_set_rebind_proc_basic.phpt index 09c0d06d81fd7..00c7bb81d9dd3 100644 --- a/ext/ldap/tests/ldap_set_rebind_proc_basic.phpt +++ b/ext/ldap/tests/ldap_set_rebind_proc_basic.phpt @@ -24,7 +24,7 @@ function rebind_proc ($ds, $ldap_url) { } } -$link = ldap_connect_and_bind($host, $port, $user, $passwd, $protocol_version); +$link = ldap_connect_and_bind($uri, $user, $passwd, $protocol_version); var_dump(ldap_set_rebind_proc($link, "rebind_proc")); var_dump(ldap_set_rebind_proc($link, null)); ?> diff --git a/ext/ldap/tests/ldap_set_rebind_proc_error.phpt b/ext/ldap/tests/ldap_set_rebind_proc_error.phpt index a0e2c7647950f..9a4fdd5cbb2ec 100644 --- a/ext/ldap/tests/ldap_set_rebind_proc_error.phpt +++ b/ext/ldap/tests/ldap_set_rebind_proc_error.phpt @@ -11,7 +11,7 @@ ldap die("skip ldap_set_rebind_proc() does not exist"); } require "connect.inc"; - $link = @fsockopen($host, $port); + $link = @fsockopen($uri); if (!$link) { die("skip no server listening"); } @@ -33,7 +33,7 @@ function rebind_proc ($ds, $ldap_url) { } } -$link = ldap_connect($host, $port); +$link = ldap_connect($uri); try { $result = ldap_set_rebind_proc($link, "rebind_proc_inexistent"); } catch(\TypeError $error) { diff --git a/ext/ldap/tests/ldap_start_tls_basic.phpt b/ext/ldap/tests/ldap_start_tls_basic.phpt index bcf93cf3fcc66..4dbdce034369f 100644 --- a/ext/ldap/tests/ldap_start_tls_basic.phpt +++ b/ext/ldap/tests/ldap_start_tls_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_unbind_basic.phpt b/ext/ldap/tests/ldap_unbind_basic.phpt index d16325a7c3e00..76333ecf9b92a 100644 --- a/ext/ldap/tests/ldap_unbind_basic.phpt +++ b/ext/ldap/tests/ldap_unbind_basic.phpt @@ -11,7 +11,7 @@ ldap diff --git a/ext/ldap/tests/ldap_unbind_variation.phpt b/ext/ldap/tests/ldap_unbind_variation.phpt index 896821785ca54..f4ea91bbc1af2 100644 --- a/ext/ldap/tests/ldap_unbind_variation.phpt +++ b/ext/ldap/tests/ldap_unbind_variation.phpt @@ -24,7 +24,7 @@ function rebind_proc ($ds, $ldap_url) { } } -$link = ldap_connect_and_bind($host, $port, $user, $passwd, $protocol_version); +$link = ldap_connect_and_bind($uri, $user, $passwd, $protocol_version); ldap_set_rebind_proc($link, "rebind_proc"); var_dump(ldap_unbind($link)); diff --git a/ext/ldap/tests/skipifbindfailure.inc b/ext/ldap/tests/skipifbindfailure.inc index 8f66c6cb9683d..1a0d0c6d1998b 100644 --- a/ext/ldap/tests/skipifbindfailure.inc +++ b/ext/ldap/tests/skipifbindfailure.inc @@ -3,7 +3,7 @@ require_once 'connect.inc'; if ($skip_on_bind_failure) { - $link = ldap_connect($host, $port); + $link = ldap_connect($uri); ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version); if (!@ldap_bind($link, $user, $passwd)) die(sprintf("skip Can't bind to LDAP Server - [%d] %s", ldap_errno($link), ldap_error($link))); diff --git a/ext/ldap/tests/skipifcontrol.inc b/ext/ldap/tests/skipifcontrol.inc index ff690068aeeb3..26a2b78e85da4 100644 --- a/ext/ldap/tests/skipifcontrol.inc +++ b/ext/ldap/tests/skipifcontrol.inc @@ -3,8 +3,8 @@ require_once 'connect.inc'; function skipifunsupportedcontrol($oid) { - global $host, $port, $user, $passwd, $protocol_version, $base; - $link = ldap_connect_and_bind($host, $port, $user, $passwd, $protocol_version); + global $uri, $user, $passwd, $protocol_version, $base; + $link = ldap_connect_and_bind($uri, $user, $passwd, $protocol_version); $result = ldap_read($link, '', '(objectClass=*)', ['supportedControl']); if (!in_array($oid, ldap_get_entries($link, $result)[0]['supportedcontrol'])) { die(sprintf("skip Unsupported control %s", $oid)); From ba0cdd8bb4e1dcfd10a73754b6a3f14674d3564e Mon Sep 17 00:00:00 2001 From: Andreas Heigl Date: Thu, 13 Feb 2020 15:07:31 +0100 Subject: [PATCH 3/8] Verify deprecation of ldap_connect w/h 2 params This adds a test to verify that calling ldap_connect with 2 parameters triggers a deprecation notice --- .../ldap_deprectate_connect_with_two_parameters.phpt | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt diff --git a/ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt b/ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt new file mode 100644 index 0000000000000..bb3a9a855b35a --- /dev/null +++ b/ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt @@ -0,0 +1,12 @@ +--TEST-- +ldap_connect() - With two parameters is marked as deprecated +--CREDITS-- +Andreas Heigl +--FILE-- + +--EXPECTF-- +Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d From 82bd708c965d4be4bff9aa9de858ab64d4840942 Mon Sep 17 00:00:00 2001 From: Andreas Heigl Date: Wed, 1 Jun 2022 08:21:02 +0200 Subject: [PATCH 4/8] Fix issues from merge-conflicts --- ext/ldap/tests/ldap_count_references_basic.phpt | 4 ++-- ext/ldap/tests/ldap_sasl_bind_basic.phpt | 4 ++-- ext/ldap/tests/ldap_sasl_bind_error.phpt | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ext/ldap/tests/ldap_count_references_basic.phpt b/ext/ldap/tests/ldap_count_references_basic.phpt index 930ae09e5042c..eab0af440c9e5 100644 --- a/ext/ldap/tests/ldap_count_references_basic.phpt +++ b/ext/ldap/tests/ldap_count_references_basic.phpt @@ -7,7 +7,7 @@ ldap --FILE-- array("extensibleObject", "referral"), @@ -27,7 +27,7 @@ var_dump(ldap_count_references($link, $result)); LDAP_CONTROL_MANAGEDSAIT, 'iscritical' => TRUE]]); ldap_delete($link, "cn=userref2,$base", [['oid' => LDAP_CONTROL_MANAGEDSAIT, 'iscritical' => TRUE]]); diff --git a/ext/ldap/tests/ldap_sasl_bind_basic.phpt b/ext/ldap/tests/ldap_sasl_bind_basic.phpt index 03fffb84c0dc5..6e2be4e6fb4e0 100644 --- a/ext/ldap/tests/ldap_sasl_bind_basic.phpt +++ b/ext/ldap/tests/ldap_sasl_bind_basic.phpt @@ -18,7 +18,7 @@ ldap --EXPECT-- diff --git a/ext/ldap/tests/ldap_sasl_bind_error.phpt b/ext/ldap/tests/ldap_sasl_bind_error.phpt index 348a2345f5f14..3c43f77096bc8 100644 --- a/ext/ldap/tests/ldap_sasl_bind_error.phpt +++ b/ext/ldap/tests/ldap_sasl_bind_error.phpt @@ -12,7 +12,7 @@ ldap --EXPECTF-- From 8a3c0edfa3e80ac6ab219a10a061fe577bc2289c Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Sat, 25 Jun 2022 13:27:57 +0200 Subject: [PATCH 5/8] Remove empty test `ldap_control_paged_result()` is removed as of PHP 8.0.0, so this test needs to be removed as well. --- ext/ldap/tests/ldap_control_paged_results_variation1.phpt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 ext/ldap/tests/ldap_control_paged_results_variation1.phpt diff --git a/ext/ldap/tests/ldap_control_paged_results_variation1.phpt b/ext/ldap/tests/ldap_control_paged_results_variation1.phpt deleted file mode 100644 index e69de29bb2d1d..0000000000000 From 77815498b37e889ecb28ee6c336353eb69758fae Mon Sep 17 00:00:00 2001 From: Andreas Heigl Date: Fri, 7 Jul 2023 13:04:53 +0200 Subject: [PATCH 6/8] Update ext/ldap/ldap.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tim Düsterhus --- ext/ldap/ldap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c index 8374e23d8f9e5..5cc8b12829259 100644 --- a/ext/ldap/ldap.c +++ b/ext/ldap/ldap.c @@ -926,7 +926,7 @@ PHP_FUNCTION(ldap_connect) LDAP *ldap = NULL; if (ZEND_NUM_ARGS() == 2) { - zend_error(E_DEPRECATED, "Usage of ldap_connect with two arguments is deprecated."); + zend_error(E_DEPRECATED, "Usage of ldap_connect with two arguments is deprecated"); } #ifdef HAVE_ORALDAP From 6da02452983473bfbb0aacc68b10894ee7f44740 Mon Sep 17 00:00:00 2001 From: Andreas Heigl Date: Fri, 7 Jul 2023 13:50:25 +0200 Subject: [PATCH 7/8] Apply suggestions from code review Thanks @cmb69 Co-authored-by: Christoph M. Becker --- .../tests/ldap_deprectate_connect_with_two_parameters.phpt | 6 +++--- ext/ldap/tests/ldap_get_option_basic.phpt | 2 +- ext/ldap/tests/ldap_get_option_package_basic.phpt | 2 +- ext/ldap/tests/ldap_get_option_variation.phpt | 2 +- ext/ldap/tests/ldap_rename_error.phpt | 2 +- ext/ldap/tests/ldap_set_option_basic.phpt | 2 +- ext/ldap/tests/ldap_set_option_cafiles_basic.phpt | 2 +- ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt | 2 +- ext/ldap/tests/ldap_set_option_crlcheck_error.phpt | 2 +- ext/ldap/tests/ldap_set_option_keepalive_basic.phpt | 2 +- ext/ldap/tests/ldap_set_option_reqcert_basic.phpt | 2 +- ext/ldap/tests/ldap_set_option_reqcert_error.phpt | 2 +- ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt | 2 +- ext/ldap/tests/ldap_set_option_variation.phpt | 2 +- 14 files changed, 16 insertions(+), 16 deletions(-) diff --git a/ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt b/ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt index bb3a9a855b35a..b022579c57624 100644 --- a/ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt +++ b/ext/ldap/tests/ldap_deprectate_connect_with_two_parameters.phpt @@ -1,7 +1,7 @@ --TEST-- ldap_connect() - With two parameters is marked as deprecated ---CREDITS-- -Andreas Heigl +--EXTENSIONS-- +ldap --FILE-- --EXPECTF-- -Deprecated: Usage of ldap_connect with two arguments is deprecated. in %s on line %d +Deprecated: Usage of ldap_connect with two arguments is deprecated in %s on line %d diff --git a/ext/ldap/tests/ldap_get_option_basic.phpt b/ext/ldap/tests/ldap_get_option_basic.phpt index c4a612843105d..8facfdc05bd1f 100644 --- a/ext/ldap/tests/ldap_get_option_basic.phpt +++ b/ext/ldap/tests/ldap_get_option_basic.phpt @@ -18,6 +18,6 @@ var_dump( $option ); ?> ---EXPECTF-- +--EXPECT-- bool(true) int(3) diff --git a/ext/ldap/tests/ldap_get_option_package_basic.phpt b/ext/ldap/tests/ldap_get_option_package_basic.phpt index 3899e824612b6..6424a1c5d104f 100644 --- a/ext/ldap/tests/ldap_get_option_package_basic.phpt +++ b/ext/ldap/tests/ldap_get_option_package_basic.phpt @@ -14,6 +14,6 @@ var_dump(in_array($optionval, ['GnuTLS', 'OpenSSL', 'MozNSS'])); // This is a read-only option. var_dump(ldap_set_option($link, LDAP_OPT_X_TLS_PACKAGE, 'foo')); ?> ---EXPECTF-- +--EXPECT-- bool(true) bool(false) diff --git a/ext/ldap/tests/ldap_get_option_variation.phpt b/ext/ldap/tests/ldap_get_option_variation.phpt index 6cd9708e1e5a0..e925e2410b78d 100644 --- a/ext/ldap/tests/ldap_get_option_variation.phpt +++ b/ext/ldap/tests/ldap_get_option_variation.phpt @@ -48,7 +48,7 @@ var_dump( $option ); ?> ---EXPECTF-- +--EXPECT-- bool(true) int(0) bool(true) diff --git a/ext/ldap/tests/ldap_rename_error.phpt b/ext/ldap/tests/ldap_rename_error.phpt index 257f844ab2688..3acd6f8ed7dc2 100644 --- a/ext/ldap/tests/ldap_rename_error.phpt +++ b/ext/ldap/tests/ldap_rename_error.phpt @@ -12,5 +12,5 @@ require "connect.inc"; $link = ldap_connect($uri); var_dump(ldap_rename($link, "cn=userNotFound,$base", "cn=userZ", "$base", true)); ?> ---EXPECTF-- +--EXPECT-- bool(false) diff --git a/ext/ldap/tests/ldap_set_option_basic.phpt b/ext/ldap/tests/ldap_set_option_basic.phpt index cbc3b3addbd24..1b552dc4a8904 100644 --- a/ext/ldap/tests/ldap_set_option_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_basic.phpt @@ -16,6 +16,6 @@ var_dump(ldap_set_option($link, LDAP_OPT_PROTOCOL_VERSION, $protocol_version)); ldap_get_option($link, LDAP_OPT_PROTOCOL_VERSION, $option); var_dump($option); ?> ---EXPECTF-- +--EXPECT-- bool(true) int(3) diff --git a/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt b/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt index 8d1e71af90139..f3eec8e63f610 100644 --- a/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_cafiles_basic.phpt @@ -24,7 +24,7 @@ foreach([ var_dump($optionval); } ?> ---EXPECTF-- +--EXPECT-- bool(true) string(8) "/foo/bar" bool(true) diff --git a/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt b/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt index 87a6a61d5d6dc..e114de130e79c 100644 --- a/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_ciphersuite_basic.phpt @@ -15,6 +15,6 @@ var_dump($result); ldap_get_option($link, LDAP_OPT_X_TLS_CIPHER_SUITE, $optionval); var_dump($optionval); ?> ---EXPECTF-- +--EXPECT-- bool(true) string(4) "3DES" diff --git a/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt b/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt index 528099cc26347..ef88e32cc8b97 100644 --- a/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt +++ b/ext/ldap/tests/ldap_set_option_crlcheck_error.phpt @@ -11,5 +11,5 @@ $link = ldap_connect($uri); $result = ldap_set_option($link, LDAP_OPT_X_TLS_CRLCHECK, 9001); var_dump($result); ?> ---EXPECTF-- +--EXPECT-- bool(false) diff --git a/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt b/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt index b2d1e89b4a1c4..e4d2199df6a8a 100644 --- a/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_keepalive_basic.phpt @@ -21,7 +21,7 @@ foreach([ var_dump($optionval); } ?> ---EXPECTF-- +--EXPECT-- bool(true) int(5) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt b/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt index 66087bda8c739..c87055fa9e939 100644 --- a/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_reqcert_basic.phpt @@ -23,7 +23,7 @@ foreach([ var_dump($optionval); } ?> ---EXPECTF-- +--EXPECT-- bool(true) int(0) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_reqcert_error.phpt b/ext/ldap/tests/ldap_set_option_reqcert_error.phpt index 7d019d7cde2cc..ddefafdfe218e 100644 --- a/ext/ldap/tests/ldap_set_option_reqcert_error.phpt +++ b/ext/ldap/tests/ldap_set_option_reqcert_error.phpt @@ -11,5 +11,5 @@ $link = ldap_connect($uri); $result = ldap_set_option($link, LDAP_OPT_X_TLS_REQUIRE_CERT, 9001); var_dump($result); ?> ---EXPECTF-- +--EXPECT-- bool(false) diff --git a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt index 9392b11b3c21c..44abaeb9d9a3b 100644 --- a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt +++ b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt @@ -23,7 +23,7 @@ foreach([ var_dump($optionval); } ?> ---EXPECTF-- +--EXPECT-- bool(true) int(512) bool(true) diff --git a/ext/ldap/tests/ldap_set_option_variation.phpt b/ext/ldap/tests/ldap_set_option_variation.phpt index 8fe9c631afb27..17a5cfd218e21 100644 --- a/ext/ldap/tests/ldap_set_option_variation.phpt +++ b/ext/ldap/tests/ldap_set_option_variation.phpt @@ -61,7 +61,7 @@ var_dump( ldap_get_option($link, LDAP_OPT_MATCHED_DN, $option); var_dump($option); ?> ---EXPECTF-- +--EXPECT-- bool(true) bool(true) bool(true) From 89ef8ff71f236a4da89d192795d3840630df9c0b Mon Sep 17 00:00:00 2001 From: Andreas Heigl Date: Mon, 10 Jul 2023 10:16:21 +0200 Subject: [PATCH 8/8] Reintroduce lost newline --- ext/ldap/tests/ldap_connect_basic.phpt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/ldap/tests/ldap_connect_basic.phpt b/ext/ldap/tests/ldap_connect_basic.phpt index 4aa6f21e6bcf3..a8a5cb6977a8d 100644 --- a/ext/ldap/tests/ldap_connect_basic.phpt +++ b/ext/ldap/tests/ldap_connect_basic.phpt @@ -14,4 +14,4 @@ var_dump($link); ?> --EXPECTF-- object(LDAP\Connection)#%d (0) { -} \ No newline at end of file +}