Skip to content

zend_mm_heap corrupted when running tests on Windows CI with ZTS builds #15180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmb69 opened this issue Jul 31, 2024 · 7 comments
Closed

zend_mm_heap corrupted when running tests on Windows CI with ZTS builds #15180

cmb69 opened this issue Jul 31, 2024 · 7 comments

Comments

@cmb69
Copy link
Member

cmb69 commented Jul 31, 2024

Description

Apparently, all our WINDOWS_X64_ZTS CI builds trigger a "zend_mm_heap corrupted" message just after starting the test runner, e.g. https://github.com/php/php-src/actions/runs/10154549484/job/28079930149#step:6:77. This does not happen with NTS builds. I cannot reproduce that issue locally, so I have no idea what's wrong there. This is apparently not the case for PHP-8.1, but for all higher branches.

Maybe somebody has an idea what's happening, or wants to investigate this more closely.

PHP Version

PHP 8.2

Operating System

Windows

@nielsdos
Copy link
Member

@cmb69 Please see #10838 where I analysed this.

@cmb69
Copy link
Member Author

cmb69 commented Jul 31, 2024

Ah! Thank you @nielsdos! Closing this as duplicate of #10838.

@cmb69
Copy link
Member Author

cmb69 commented Jul 31, 2024

Maybe #6993 wasn't the best idea.

@nielsdos
Copy link
Member

dl() in general isn't the best idea. I remember looking into what would be necessary to make it work properly but it's a huge effort.

@cmb69
Copy link
Member Author

cmb69 commented Jul 31, 2024

Maybe it's best to rid dl() altogether. It appears to be of very limited use.

@nielsdos
Copy link
Member

Maybe it's best to rid dl() altogether. It appears to be of very limited use.

I've been thinking that as well, maybe 8.5 material

@cmb69
Copy link
Member Author

cmb69 commented Jul 31, 2024

I've been thinking that as well, maybe 8.5 material

Yeah, deprecate in 8.5 and drop in 9.0. But if 9.0 would be next, we would have to keep it for a long time. :(

Anyway, I just forgot to press the close button again.

@cmb69 cmb69 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants