Skip to content

Cacheline demote optimization for JITTed code is missing #12825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PeterYang12 opened this issue Nov 29, 2023 · 2 comments
Closed

Cacheline demote optimization for JITTed code is missing #12825

PeterYang12 opened this issue Nov 29, 2023 · 2 comments

Comments

@PeterYang12
Copy link
Contributor

Description

Hi maintainers, This #11101 supports Cacheline demote and got merged in PHP-8.3.0.
I can see it:

$ git tag --contain 6bd5464
php-8.3.0RC1
php-8.3.0RC2
php-8.3.0RC3
php-8.3.0RC4
php-8.3.0RC5
php-8.3.0RC6
php-8.3.0alpha1
php-8.3.0alpha2
php-8.3.0alpha3
php-8.3.0beta1
php-8.3.0beta2
php-8.3.0beta3

However, in the latest codes, in the master branch, it's gone. And I can't find the implementation. For example, this fucntion https://github.com/php/php-src/blob/566100d7fef86e0061bad67f0ec56f659591bcc7/ext/opcache/jit/zend_jit_ir.c#L15741C53-L15741C53

Is there a specific reason why the optimization was removed, or was it accidentally removed during the process?
Given that the function lacks an implementation, it might fail to build on some machines.
If this task is still ongoing, our team would be very interested in participating or assisting with it.

Looking forward to your response :)

PHP Version

master

Operating System

No response

@dstogov
Copy link
Member

dstogov commented Dec 1, 2023

The support for CLDEMOTE was removed occasionally.

I've added support for CLDEMOTE in IR Framework via dstogov/ir@ed4fd9e and restored in php JIT via bf6b66f

@dstogov dstogov closed this as completed Dec 1, 2023
@PeterYang12
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants