Test failure with external PCRE

[orlitzky]

Description

FAILED TEST SUMMARY
---------------------------------------------------------------------
GH-11374 (PCRE regular expression without JIT enabled gives different result) [ext/pcre/tests/gh11374.phpt]

This was introduced in #12439 which backports a libpcre fix to the bundled copy and then tests for it. When using an external libpcre, nobody will have this fix because it doesn't appear in any released version of libpcre. So, the test fails.

Personally I don't think the test needs to be duplicated in PHP if it's already included in the upstream test suite (https://github.com/PCRE2Project/pcre2/pull/300/files), but if it's providing some peace of mind, maybe it could be made conditional on the internal libpcre?

PHP Version

git HEAD

Operating System

No response

[nielsdos]

I already took care of this in the current development versions by making it conditional on either being bundled or having a more recent version than 10.42 installed.
See

php-src/ext/pcre/tests/gh11374.phpt

Line 7 in 298bba5

if (!zend_test_is_pcre_bundled() && (PCRE_VERSION_MAJOR == 10 && PCRE_VERSION_MINOR <= 42)) die("skip old pcre version");

[orlitzky]

And that's why you git pull UPSTREAM master before filing a bug. Thank you :)

[nielsdos]

No worries, I rather have people ask "too much" than "too little" :)