Skip to content

Commit e208cb2

Browse files
GirgiasGirgias
committed
Promote various warnings to Error in GMP extension
This gets rid of most false returns Closes GH-5882
1 parent 5d72e40 commit e208cb2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+1290
-944
lines changed

‎ext/gmp/gmp.c

Lines changed: 163 additions & 153 deletions
Large diffs are not rendered by default.

‎ext/gmp/gmp.stub.php

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -7,104 +7,104 @@ class GMP
77
}
88

99
/** @param int|bool|string $number */
10-
function gmp_init($number, int $base = 0): GMP|false {}
10+
function gmp_init($number, int $base = 0): GMP {}
1111

12-
function gmp_import(string $data, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): GMP|false {}
12+
function gmp_import(string $data, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): GMP {}
1313

1414
/** @param GMP|int|bool|string $gmpnumber */
15-
function gmp_export($gmpnumber, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): string|false {}
15+
function gmp_export($gmpnumber, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): string {}
1616

1717
/** @param GMP|int|bool|string $gmpnumber */
1818
function gmp_intval($gmpnumber): int {}
1919

2020
/** @param GMP|int|bool|string $gmpnumber */
21-
function gmp_strval($gmpnumber, int $base = 10): string|false {}
21+
function gmp_strval($gmpnumber, int $base = 10): string {}
2222

2323
/**
2424
* @param GMP|int|bool|string $a
2525
* @param GMP|int|bool|string $b
2626
*/
27-
function gmp_add($a, $b): GMP|false {}
27+
function gmp_add($a, $b): GMP {}
2828

2929
/**
3030
* @param GMP|int|bool|string $a
3131
* @param GMP|int|bool|string $b
3232
*/
33-
function gmp_sub($a, $b): GMP|false {}
33+
function gmp_sub($a, $b): GMP {}
3434

3535
/**
3636
* @param GMP|int|bool|string $a
3737
* @param GMP|int|bool|string $b
3838
*/
39-
function gmp_mul($a, $b): GMP|false {}
39+
function gmp_mul($a, $b): GMP {}
4040

4141
/**
4242
* @param GMP|int|bool|string $a
4343
* @param GMP|int|bool|string $b
4444
*/
45-
function gmp_div_qr($a, $b, int $round = GMP_ROUND_ZERO): array|false {}
45+
function gmp_div_qr($a, $b, int $round = GMP_ROUND_ZERO): array {}
4646

4747
/**
4848
* @param GMP|int|bool|string $a
4949
* @param GMP|int|bool|string $b
5050
*/
51-
function gmp_div_q($a, $b, int $round = GMP_ROUND_ZERO): GMP|false {}
51+
function gmp_div_q($a, $b, int $round = GMP_ROUND_ZERO): GMP {}
5252

5353
/**
5454
* @param GMP|int|bool|string $a
5555
* @param GMP|int|bool|string $b
5656
*/
57-
function gmp_div_r($a, $b, int $round = GMP_ROUND_ZERO): GMP|false {}
57+
function gmp_div_r($a, $b, int $round = GMP_ROUND_ZERO): GMP {}
5858

5959
/**
6060
* @param GMP|int|bool|string $a
6161
* @param GMP|int|bool|string $b
6262
* @alias gmp_div_q
6363
*/
64-
function gmp_div($a, $b, int $round = GMP_ROUND_ZERO): GMP|false {}
64+
function gmp_div($a, $b, int $round = GMP_ROUND_ZERO): GMP {}
6565

6666
/**
6767
* @param GMP|int|bool|string $a
6868
* @param GMP|int|bool|string $b
6969
*/
70-
function gmp_mod($a, $b): GMP|false {}
70+
function gmp_mod($a, $b): GMP {}
7171

7272
/**
7373
* @param GMP|int|bool|string $a
7474
* @param GMP|int|bool|string $b
7575
*/
76-
function gmp_divexact($a, $b): GMP|false {}
76+
function gmp_divexact($a, $b): GMP {}
7777

7878
/** @param GMP|int|bool|string $a */
79-
function gmp_neg($a): GMP|false {}
79+
function gmp_neg($a): GMP {}
8080

8181
/** @param GMP|int|bool|string $a */
82-
function gmp_abs($a): GMP|false {}
82+
function gmp_abs($a): GMP {}
8383

84-
/** @param GMP|int $a */
85-
function gmp_fact($a): GMP|false {}
84+
/** @param GMP|int|bool|string $a */
85+
function gmp_fact($a): GMP {}
8686

8787
/** @param GMP|int|bool|string $a */
88-
function gmp_sqrt($a): GMP|false {}
88+
function gmp_sqrt($a): GMP {}
8989

9090
/** @param GMP|int|bool|string $a */
91-
function gmp_sqrtrem($a): array|false {}
91+
function gmp_sqrtrem($a): array {}
9292

9393
/** @param GMP|int|bool|string $a */
94-
function gmp_root($a, int $nth): GMP|false {}
94+
function gmp_root($a, int $nth): GMP {}
9595

9696
/** @param GMP|int|bool|string $a */
97-
function gmp_rootrem($a, int $nth): array|false {}
97+
function gmp_rootrem($a, int $nth): array {}
9898

9999
/** @param GMP|int|bool|string $base */
100-
function gmp_pow($base, int $exp): GMP|false {}
100+
function gmp_pow($base, int $exp): GMP {}
101101

102102
/**
103103
* @param GMP|int|bool|string $base
104104
* @param GMP|int|bool|string $exp
105105
* @param GMP|int|bool|string $mod
106106
*/
107-
function gmp_powm($base, $exp, $mod): GMP|false {}
107+
function gmp_powm($base, $exp, $mod): GMP {}
108108

109109
/** @param GMP|int|bool|string $a */
110110
function gmp_perfect_square($a): bool {}
@@ -113,25 +113,25 @@ function gmp_perfect_square($a): bool {}
113113
function gmp_perfect_power($a): bool {}
114114

115115
/** @param GMP|int|bool|string $a */
116-
function gmp_prob_prime($a, int $reps = 10): int|false {}
116+
function gmp_prob_prime($a, int $reps = 10): int {}
117117

118118
/**
119119
* @param GMP|int|bool|string $a
120120
* @param GMP|int|bool|string $b
121121
*/
122-
function gmp_gcd($a, $b): GMP|false {}
122+
function gmp_gcd($a, $b): GMP {}
123123

124124
/**
125125
* @param GMP|int|bool|string $a
126126
* @param GMP|int|bool|string $b
127127
*/
128-
function gmp_gcdext($a, $b): array|false {}
128+
function gmp_gcdext($a, $b): array {}
129129

130130
/**
131131
* @param GMP|int|bool|string $a
132132
* @param GMP|int|bool|string $b
133133
*/
134-
function gmp_lcm($a, $b): GMP|false {}
134+
function gmp_lcm($a, $b): GMP {}
135135

136136
/**
137137
* @param GMP|int|bool|string $a
@@ -143,85 +143,85 @@ function gmp_invert($a, $b): GMP|false {}
143143
* @param GMP|int|bool|string $a
144144
* @param GMP|int|bool|string $b
145145
*/
146-
function gmp_jacobi($a, $b): int|false {}
146+
function gmp_jacobi($a, $b): int {}
147147

148148
/**
149149
* @param GMP|int|bool|string $a
150150
* @param GMP|int|bool|string $b
151151
*/
152-
function gmp_legendre($a, $b): int|false {}
152+
function gmp_legendre($a, $b): int {}
153153

154154
/**
155155
* @param GMP|int|bool|string $a
156156
* @param GMP|int|bool|string $b
157157
*/
158-
function gmp_kronecker($a, $b): int|false {}
158+
function gmp_kronecker($a, $b): int {}
159159

160160
/**
161161
* @param GMP|int|bool|string $a
162162
* @param GMP|int|bool|string $b
163163
*/
164-
function gmp_cmp($a, $b): int|false {}
164+
function gmp_cmp($a, $b): int {}
165165

166166
/** @param GMP|int|bool|string $a */
167-
function gmp_sign($a): int|false {}
167+
function gmp_sign($a): int {}
168168

169169
/** @param GMP|int|bool|string $seed */
170-
function gmp_random_seed($seed): ?bool {}
170+
function gmp_random_seed($seed): void {}
171171

172-
function gmp_random_bits(int $bits): GMP|false {}
172+
function gmp_random_bits(int $bits): GMP {}
173173

174174
/**
175175
* @param GMP|int|bool|string $min
176176
* @param GMP|int|bool|string $max
177177
**/
178-
function gmp_random_range($min, $max): GMP|false {}
178+
function gmp_random_range($min, $max): GMP {}
179179

180180
/**
181181
* @param GMP|int|bool|string $a
182182
* @param GMP|int|bool|string $b
183183
*/
184-
function gmp_and($a, $b): GMP|false {}
184+
function gmp_and($a, $b): GMP {}
185185

186186
/**
187187
* @param GMP|int|bool|string $a
188188
* @param GMP|int|bool|string $b
189189
*/
190-
function gmp_or($a, $b): GMP|false {}
190+
function gmp_or($a, $b): GMP {}
191191

192192
/** @param GMP|int|bool|string $a */
193-
function gmp_com($a): GMP|false {}
193+
function gmp_com($a): GMP {}
194194

195195
/**
196196
* @param GMP|int|bool|string $a
197197
* @param GMP|int|bool|string $b
198198
*/
199-
function gmp_xor($a, $b): GMP|false {}
199+
function gmp_xor($a, $b): GMP {}
200200

201-
function gmp_setbit(GMP $a, int $index, bool $set_clear = true): ?bool {}
201+
function gmp_setbit(GMP $a, int $index, bool $set_clear = true): void {}
202202

203-
function gmp_clrbit(GMP $a, int $index): ?bool {}
203+
function gmp_clrbit(GMP $a, int $index): void {}
204204

205205
/** @param GMP|int|bool|string $a */
206206
function gmp_testbit($a, int $index): bool {}
207207

208208
/** @param GMP|int|bool|string $a */
209-
function gmp_scan0($a, int $start): int|false {}
209+
function gmp_scan0($a, int $start): int {}
210210

211211
/** @param GMP|int|bool|string $a */
212-
function gmp_scan1($a, int $start): int|false {}
212+
function gmp_scan1($a, int $start): int {}
213213

214214
/** @param GMP|int|bool|string $a */
215-
function gmp_popcount($a): int|false {}
215+
function gmp_popcount($a): int {}
216216

217217
/**
218218
* @param GMP|int|bool|string $a
219219
* @param GMP|int|bool|string $b
220220
*/
221-
function gmp_hamdist($a, $b): int|false {}
221+
function gmp_hamdist($a, $b): int {}
222222

223223
/** @param GMP|int|bool|string $a */
224-
function gmp_nextprime($a): GMP|false {}
224+
function gmp_nextprime($a): GMP {}
225225

226226
/** @param GMP|int|bool|string $a */
227-
function gmp_binomial($a, int $b): GMP|false {}
227+
function gmp_binomial($a, int $b): GMP {}

0 commit comments

Comments
 (0)