Always use ZVAL_DUP()

TimWolla · TimWolla · commit dbb619d7734b · 2022-03-07T20:55:48.000+01:00
diff --git a/Zend/zend.c b/Zend/zend.c
@@ -677,7 +677,7 @@ static void function_copy_ctor(zval *zv) /* {{{ */
 			attr = zend_add_attribute(&func->common.attributes, old_attr->name, old_attr->argc, old_attr->flags, old_attr->offset, old_attr->lineno);
 
 			for (i = 0 ; i < old_attr->argc; i++) {
-				ZVAL_COPY_OR_DUP(&attr->args[i].value, &old_attr->args[i].value);
+				ZVAL_DUP(&attr->args[i].value, &old_attr->args[i].value);
 			}
 		} ZEND_HASH_FOREACH_END();
 	}

Original file line number	Diff line number	Diff line change
`@@ -677,7 +677,7 @@ static void function_copy_ctor(zval zv) / {{{ */`
`677`	`677`	`attr = zend_add_attribute(&func->common.attributes, old_attr->name, old_attr->argc, old_attr->flags, old_attr->offset, old_attr->lineno);`
`678`	`678`
`679`	`679`	`for (i = 0 ; i < old_attr->argc; i++) {`
`680`		`- ZVAL_COPY_OR_DUP(&attr->args[i].value, &old_attr->args[i].value);`
	`680`	`+ ZVAL_DUP(&attr->args[i].value, &old_attr->args[i].value);`
`681`	`681`	`}`
`682`	`682`	`} ZEND_HASH_FOREACH_END();`
`683`	`683`	`}`