Better error message

Author: Girgias

ext/mbstring/mbstring.c

@@ -334,8 +334,7 @@ static const mbfl_encoding *php_mb_get_encoding(zend_string *encoding_name, cons
 
 		encoding = mbfl_name2encoding(ZSTR_VAL(encoding_name));
 		if (!encoding) {
-			zend_argument_value_error(arg_num, "must be a valid encoding, encoding \"%s\" is unknown",
-				ZSTR_VAL(encoding_name));
+			zend_argument_value_error(arg_num, "must be a valid encoding, \"%s\" given", ZSTR_VAL(encoding_name));
 			return NULL;
 		}
 
@@ -3526,7 +3525,7 @@ php_mb_numericentity_exec(INTERNAL_FUNCTION_PARAMETERS, int type)
 	if (encoding && encoding_len > 0) {
 		string.encoding = mbfl_name2encoding(encoding);
 		if (!string.encoding) {
-			zend_argument_value_error(3, "must be a valid encoding, encoding \"%s\" is unknown", encoding);
+			zend_argument_value_error(3, "must be a valid encoding, \"%s\" given", encoding);
 			RETURN_THROWS();
 		}
 	}

ext/mbstring/php_mbregex.c

@@ -855,7 +855,7 @@ PHP_FUNCTION(mb_regex_encoding)
 		mbctype = _php_mb_regex_name2mbctype(encoding);
 
 		if (mbctype == ONIG_ENCODING_UNDEF) {
-			zend_argument_value_error(1, "must be a valid encoding, encoding \"%s\" is unknown", encoding);
+			zend_argument_value_error(1, "must be a valid encoding, \"%s\" given", encoding);
 			RETURN_THROWS();
 		}
 

ext/mbstring/tests/bug43998.phpt

@@ -39,21 +39,21 @@ foreach($inputs as $input) {
 ?>
 --EXPECT--
 -- Iteration 1 --
-mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, encoding "12345" is unknown
-mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, encoding "12345" is unknown
+mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, "12345" given
+mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, "12345" given
 
 -- Iteration 2 --
-mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, encoding "1.23456789E-9" is unknown
-mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, encoding "1.23456789E-9" is unknown
+mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, "1.23456789E-9" given
+mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, "1.23456789E-9" given
 
 -- Iteration 3 --
-mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, encoding "1" is unknown
-mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, encoding "1" is unknown
+mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, "1" given
+mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, "1" given
 
 -- Iteration 4 --
-mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, encoding "" is unknown
-mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, encoding "" is unknown
+mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, "" given
+mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, "" given
 
 -- Iteration 5 --
-mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, encoding "" is unknown
-mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, encoding "" is unknown
+mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, "" given
+mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, "" given

ext/mbstring/tests/mb_chr.phpt

@@ -44,7 +44,7 @@ bool(true)
 bool(true)
 bool(true)
 bool(true)
-mb_chr(): Argument #2 ($encoding) must be a valid encoding, encoding "typo" is unknown
+mb_chr(): Argument #2 ($encoding) must be a valid encoding, "typo" given
 
 Warning: mb_chr(): Unsupported encoding "pass" in %s on line %d
 bool(false)

ext/mbstring/tests/mb_convert_encoding.phpt

@@ -124,4 +124,4 @@ JIS: GyRCRnxLXDhsJUYlLSU5JUgkRyQ5ISMbKEIwMTIzNBskQiM1IzYjNyM4IzkhIxsoQg==
 == INVALID PARAMETER ==
 INT: 1234
 EUC-JP: 
-mb_convert_encoding(): Argument #2 ($to) must be a valid encoding, encoding "BAD" is unknown
+mb_convert_encoding(): Argument #2 ($to) must be a valid encoding, "BAD" given

ext/mbstring/tests/mb_ord.phpt

@@ -49,7 +49,7 @@ mb_ord("");
 bool(true)
 bool(true)
 bool(true)
-mb_ord(): Argument #2 ($encoding) must be a valid encoding, encoding "typo" is unknown
+mb_ord(): Argument #2 ($encoding) must be a valid encoding, "typo" given
 
 Warning: mb_ord(): Unsupported encoding "pass" in %s on line %d
 bool(false)

ext/mbstring/tests/mb_regex_encoding_error2.phpt

@@ -27,4 +27,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_regex_encoding() : error conditions ***
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "unknown" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "unknown" given

ext/mbstring/tests/mb_regex_encoding_variation2.phpt

@@ -101,7 +101,7 @@ string(5) "UCS-4"
 
 -- Iteration 2 --
 string(5) "UCS-4"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "UCS-4BE" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "UCS-4BE" given
 string(5) "UCS-4"
 
 -- Iteration 3 --
@@ -111,17 +111,17 @@ string(7) "UCS-4LE"
 
 -- Iteration 4 --
 string(7) "UCS-4LE"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "UCS-2" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "UCS-2" given
 string(7) "UCS-4LE"
 
 -- Iteration 5 --
 string(7) "UCS-4LE"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "UCS-2BE" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "UCS-2BE" given
 string(7) "UCS-4LE"
 
 -- Iteration 6 --
 string(7) "UCS-4LE"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "UCS-2LE" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "UCS-2LE" given
 string(7) "UCS-4LE"
 
 -- Iteration 7 --
@@ -156,12 +156,12 @@ string(8) "UTF-16LE"
 
 -- Iteration 13 --
 string(8) "UTF-16LE"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "UTF-7" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "UTF-7" given
 string(8) "UTF-16LE"
 
 -- Iteration 14 --
 string(8) "UTF-16LE"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "UTF7-IMAP" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "UTF7-IMAP" given
 string(8) "UTF-16LE"
 
 -- Iteration 15 --
@@ -196,12 +196,12 @@ string(4) "SJIS"
 
 -- Iteration 21 --
 string(4) "SJIS"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "ISO-2022-JP" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "ISO-2022-JP" given
 string(4) "SJIS"
 
 -- Iteration 22 --
 string(4) "SJIS"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "JIS" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "JIS" given
 string(4) "SJIS"
 
 -- Iteration 23 --
@@ -271,42 +271,42 @@ string(11) "ISO-8859-15"
 
 -- Iteration 36 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "byte2be" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "byte2be" given
 string(11) "ISO-8859-15"
 
 -- Iteration 37 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "byte2le" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "byte2le" given
 string(11) "ISO-8859-15"
 
 -- Iteration 38 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "byte4be" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "byte4be" given
 string(11) "ISO-8859-15"
 
 -- Iteration 39 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "byte4le" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "byte4le" given
 string(11) "ISO-8859-15"
 
 -- Iteration 40 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "BASE64" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "BASE64" given
 string(11) "ISO-8859-15"
 
 -- Iteration 41 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "HTML-ENTITIES" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "HTML-ENTITIES" given
 string(11) "ISO-8859-15"
 
 -- Iteration 42 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "7bit" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "7bit" given
 string(11) "ISO-8859-15"
 
 -- Iteration 43 --
 string(11) "ISO-8859-15"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "8bit" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "8bit" given
 string(11) "ISO-8859-15"
 
 -- Iteration 44 --
@@ -316,12 +316,12 @@ string(6) "EUC-CN"
 
 -- Iteration 45 --
 string(6) "EUC-CN"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "CP936" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "CP936" given
 string(6) "EUC-CN"
 
 -- Iteration 46 --
 string(6) "EUC-CN"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "HZ" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "HZ" given
 string(6) "EUC-CN"
 
 -- Iteration 47 --
@@ -331,7 +331,7 @@ string(6) "EUC-TW"
 
 -- Iteration 48 --
 string(6) "EUC-TW"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "CP950" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "CP950" given
 string(6) "EUC-TW"
 
 -- Iteration 49 --
@@ -346,27 +346,27 @@ string(6) "EUC-KR"
 
 -- Iteration 51 --
 string(6) "EUC-KR"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "UHC" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "UHC" given
 string(6) "EUC-KR"
 
 -- Iteration 52 --
 string(6) "EUC-KR"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "ISO-2022-KR" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "ISO-2022-KR" given
 string(6) "EUC-KR"
 
 -- Iteration 53 --
 string(6) "EUC-KR"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "Windows-1251" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "Windows-1251" given
 string(6) "EUC-KR"
 
 -- Iteration 54 --
 string(6) "EUC-KR"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "Windows-1252" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "Windows-1252" given
 string(6) "EUC-KR"
 
 -- Iteration 55 --
 string(6) "EUC-KR"
-mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, encoding "CP866" is unknown
+mb_regex_encoding(): Argument #1 ($encoding) must be a valid encoding, "CP866" given
 string(6) "EUC-KR"
 
 -- Iteration 56 --

ext/mbstring/tests/mb_str_unknown_encoding.phpt

@@ -142,25 +142,25 @@ try {
 
 ?>
 --EXPECT--
-mb_chr(): Argument #2 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_convert_case(): Argument #3 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
+mb_chr(): Argument #2 ($encoding) must be a valid encoding, "UTF-0" given
+mb_convert_case(): Argument #3 ($encoding) must be a valid encoding, "UTF-0" given
 mb_convert_encoding(): Argument #3 ($from) must provide at least one valid character encoding
-mb_convert_kana(): Argument #3 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_decode_numericentity(): Argument #3 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_ord(): Argument #2 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strcut(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strimwidth(): Argument #5 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_stripos(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_stristr(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strlen(): Argument #2 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strpos(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strrchr(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strrichr(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strripos(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strrpos(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strstr(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_strwidth(): Argument #2 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_substr(): Argument #4 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
-mb_substr_count(): Argument #3 ($encoding) must be a valid encoding, encoding "UTF-0" is unknown
+mb_convert_kana(): Argument #3 ($encoding) must be a valid encoding, "UTF-0" given
+mb_decode_numericentity(): Argument #3 ($encoding) must be a valid encoding, "UTF-0" given
+mb_ord(): Argument #2 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strcut(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strimwidth(): Argument #5 ($encoding) must be a valid encoding, "UTF-0" given
+mb_stripos(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_stristr(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strlen(): Argument #2 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strpos(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strrchr(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strrichr(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strripos(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strrpos(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strstr(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, "UTF-0" given
+mb_strwidth(): Argument #2 ($encoding) must be a valid encoding, "UTF-0" given
+mb_substr(): Argument #4 ($encoding) must be a valid encoding, "UTF-0" given
+mb_substr_count(): Argument #3 ($encoding) must be a valid encoding, "UTF-0" given

ext/mbstring/tests/mb_stripos_error2.phpt

@@ -32,4 +32,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_stripos() : error conditions ***
-mb_stripos(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_stripos(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_stristr_error2.phpt

@@ -33,4 +33,4 @@ try {
 *** Testing mb_stristr() : error conditions ***
 
 -- Testing mb_stristr() with unknown encoding --
-mb_stristr(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_stristr(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strlen.phpt

@@ -79,4 +79,4 @@ try {
 43
 101
 == WRONG PARAMETERS ==
-mb_strlen(): Argument #2 ($encoding) must be a valid encoding, encoding "BAD_NAME" is unknown
+mb_strlen(): Argument #2 ($encoding) must be a valid encoding, "BAD_NAME" given

ext/mbstring/tests/mb_strlen_error2.phpt

@@ -29,6 +29,6 @@ try {
 }
 
 ?>
---EXPECTF--
+--EXPECT--
 *** Testing mb_strlen() : error ***
-mb_strlen(): Argument #2 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strlen(): Argument #2 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strpos_error2.phpt

@@ -31,4 +31,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_strpos() : error conditions ***
-mb_strpos(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strpos(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strrchr_error2.phpt

@@ -33,4 +33,4 @@ try {
 *** Testing mb_strrchr() : error conditions ***
 
 -- Testing mb_strrchr() with unknown encoding --
-mb_strrchr(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strrchr(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strrichr_error2.phpt

@@ -33,4 +33,4 @@ try {
 *** Testing mb_strrichr() : error conditions ***
 
 -- Testing mb_strrichr() with unknown encoding --
-mb_strrichr(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strrichr(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strripos_error2.phpt

@@ -32,4 +32,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_strripos() : error conditions ***
-mb_strripos(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strripos(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strrpos_error2.phpt

@@ -32,4 +32,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_strrpos() : error conditions ***
-mb_strrpos(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strrpos(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strstr_error2.phpt

@@ -33,4 +33,4 @@ try {
 *** Testing mb_strstr() : error conditions ***
 
 -- Testing mb_strstr() with unknown encoding --
-mb_strstr(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strstr(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strtolower_error2.phpt

@@ -30,4 +30,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_strtolower() : error conditions***
-mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strtolower(): Argument #2 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_strtoupper_error2.phpt

@@ -30,4 +30,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_strtoupper() : error conditions ***
-mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_strtoupper(): Argument #2 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_substr_count_error2.phpt

@@ -35,4 +35,4 @@ try {
 *** Testing mb_substr_count() : error conditions ***
 
 -- Testing mb_substr_count() function with an unknown encoding --
-mb_substr_count(): Argument #3 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_substr_count(): Argument #3 ($encoding) must be a valid encoding, "unknown-encoding" given

ext/mbstring/tests/mb_substr_error2.phpt

@@ -32,4 +32,4 @@ try {
 ?>
 --EXPECT--
 *** Testing mb_substr() : error conditions ***
-mb_substr(): Argument #4 ($encoding) must be a valid encoding, encoding "unknown-encoding" is unknown
+mb_substr(): Argument #4 ($encoding) must be a valid encoding, "unknown-encoding" given