Skip to content

Commit 6e6280a

Browse files
committed
Corrected error messages:
- we don't use NULL for overlaoded objects for ages - fixed array/object mess
1 parent 96c1325 commit 6e6280a

File tree

5 files changed

+75
-75
lines changed

5 files changed

+75
-75
lines changed

Zend/tests/bug41813.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ $foo[0]->bar = "xyz";
99
echo "Done\n";
1010
?>
1111
--EXPECTF--
12-
Fatal error: Uncaught Error: Cannot use string offset as an array in %s:%d
12+
Fatal error: Uncaught Error: Cannot use string offset as an object in %s:%d
1313
Stack trace:
1414
#0 {main}
1515
thrown in %s on line %d

Zend/tests/bug49866.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ $b = &$a[1];
77
$b = "f";
88
echo $a;
99
--EXPECTF--
10-
Fatal error: Uncaught Error: Cannot create references to/from string offsets nor overloaded objects in %sbug49866.php:3
10+
Fatal error: Uncaught Error: Cannot create references to/from string offsets in %sbug49866.php:3
1111
Stack trace:
1212
#0 {main}
1313
thrown in %sbug49866.php on line 3

Zend/tests/bug70089.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ try {
3434
string(36) "Cannot use string offset as an array"
3535
string(27) "Cannot unset string offsets"
3636
string(41) "Only variables can be passed by reference"
37-
string(64) "Cannot increment/decrement overloaded objects nor string offsets"
37+
string(41) "Cannot increment/decrement string offsets"

Zend/zend_vm_def.h

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -806,7 +806,7 @@ ZEND_VM_HELPER(zend_binary_assign_op_dim_helper, VAR|UNUSED|CV, CONST|TMPVAR|UNU
806806
var_ptr = Z_INDIRECT(rv);
807807

808808
if (UNEXPECTED(var_ptr == NULL)) {
809-
zend_throw_error(NULL, "Cannot use assign-op operators with overloaded objects nor string offsets");
809+
zend_throw_error(NULL, "Cannot use assign-op operators with string offsets");
810810
FREE_OP2();
811811
FREE_OP(free_op_data1);
812812
FREE_OP1_VAR_PTR();
@@ -847,7 +847,7 @@ ZEND_VM_HELPER(zend_binary_assign_op_helper, VAR|CV, CONST|TMPVAR|CV, binary_op_
847847
var_ptr = GET_OP1_ZVAL_PTR_PTR(BP_VAR_RW);
848848

849849
if (OP1_TYPE == IS_VAR && UNEXPECTED(var_ptr == NULL)) {
850-
zend_throw_error(NULL, "Cannot use assign-op operators with overloaded objects nor string offsets");
850+
zend_throw_error(NULL, "Cannot use assign-op operators with string offsets");
851851
FREE_OP2();
852852
HANDLE_EXCEPTION();
853853
}
@@ -1132,7 +1132,7 @@ ZEND_VM_HELPER(zend_pre_incdec_property_helper, VAR|UNUSED|CV, CONST|TMPVAR|CV,
11321132
property = GET_OP2_ZVAL_PTR(BP_VAR_R);
11331133

11341134
if (OP1_TYPE == IS_VAR && UNEXPECTED(object == NULL)) {
1135-
zend_throw_error(NULL, "Cannot increment/decrement overloaded objects nor string offsets");
1135+
zend_throw_error(NULL, "Cannot increment/decrement string offsets");
11361136
FREE_OP2();
11371137
HANDLE_EXCEPTION();
11381138
}
@@ -1213,7 +1213,7 @@ ZEND_VM_HELPER(zend_post_incdec_property_helper, VAR|UNUSED|CV, CONST|TMPVAR|CV,
12131213
property = GET_OP2_ZVAL_PTR(BP_VAR_R);
12141214

12151215
if (OP1_TYPE == IS_VAR && UNEXPECTED(object == NULL)) {
1216-
zend_throw_error(NULL, "Cannot increment/decrement overloaded objects nor string offsets");
1216+
zend_throw_error(NULL, "Cannot increment/decrement string offsets");
12171217
FREE_OP2();
12181218
HANDLE_EXCEPTION();
12191219
}
@@ -1280,7 +1280,7 @@ ZEND_VM_HANDLER(34, ZEND_PRE_INC, VAR|CV, ANY)
12801280

12811281
if (OP1_TYPE == IS_VAR && UNEXPECTED(var_ptr == NULL)) {
12821282
SAVE_OPLINE();
1283-
zend_throw_error(NULL, "Cannot increment/decrement overloaded objects nor string offsets");
1283+
zend_throw_error(NULL, "Cannot increment/decrement string offsets");
12841284
HANDLE_EXCEPTION();
12851285
}
12861286

@@ -1326,7 +1326,7 @@ ZEND_VM_HANDLER(35, ZEND_PRE_DEC, VAR|CV, ANY)
13261326

13271327
if (OP1_TYPE == IS_VAR && UNEXPECTED(var_ptr == NULL)) {
13281328
SAVE_OPLINE();
1329-
zend_throw_error(NULL, "Cannot increment/decrement overloaded objects nor string offsets");
1329+
zend_throw_error(NULL, "Cannot increment/decrement string offsets");
13301330
HANDLE_EXCEPTION();
13311331
}
13321332

@@ -1372,7 +1372,7 @@ ZEND_VM_HANDLER(36, ZEND_POST_INC, VAR|CV, ANY)
13721372

13731373
if (OP1_TYPE == IS_VAR && UNEXPECTED(var_ptr == NULL)) {
13741374
SAVE_OPLINE();
1375-
zend_throw_error(NULL, "Cannot increment/decrement overloaded objects nor string offsets");
1375+
zend_throw_error(NULL, "Cannot increment/decrement string offsets");
13761376
HANDLE_EXCEPTION();
13771377
}
13781378

@@ -1411,7 +1411,7 @@ ZEND_VM_HANDLER(37, ZEND_POST_DEC, VAR|CV, ANY)
14111411

14121412
if (OP1_TYPE == IS_VAR && UNEXPECTED(var_ptr == NULL)) {
14131413
SAVE_OPLINE();
1414-
zend_throw_error(NULL, "Cannot increment/decrement overloaded objects nor string offsets");
1414+
zend_throw_error(NULL, "Cannot increment/decrement string offsets");
14151415
HANDLE_EXCEPTION();
14161416
}
14171417

@@ -2221,7 +2221,7 @@ ZEND_VM_HANDLER(136, ZEND_ASSIGN_OBJ, VAR|UNUSED|THIS|CV, CONST|TMPVAR|CV)
22212221
property_name = GET_OP2_ZVAL_PTR(BP_VAR_R);
22222222

22232223
if (OP1_TYPE == IS_VAR && UNEXPECTED(object == NULL)) {
2224-
zend_throw_error(NULL, "Cannot use string offset as an array");
2224+
zend_throw_error(NULL, "Cannot use string offset as an object");
22252225
FREE_OP2();
22262226
HANDLE_EXCEPTION();
22272227
}
@@ -2377,7 +2377,7 @@ ZEND_VM_HANDLER(39, ZEND_ASSIGN_REF, VAR|CV, VAR|CV, SRC)
23772377
value_ptr = GET_OP2_ZVAL_PTR_PTR(BP_VAR_W);
23782378

23792379
if (OP2_TYPE == IS_VAR && UNEXPECTED(value_ptr == NULL)) {
2380-
zend_throw_error(NULL, "Cannot create references to/from string offsets nor overloaded objects");
2380+
zend_throw_error(NULL, "Cannot create references to/from string offsets");
23812381
FREE_UNFETCHED_OP1();
23822382
HANDLE_EXCEPTION();
23832383
}
@@ -2405,7 +2405,7 @@ ZEND_VM_HANDLER(39, ZEND_ASSIGN_REF, VAR|CV, VAR|CV, SRC)
24052405

24062406
variable_ptr = GET_OP1_ZVAL_PTR_PTR_UNDEF(BP_VAR_W);
24072407
if (OP1_TYPE == IS_VAR && UNEXPECTED(variable_ptr == NULL)) {
2408-
zend_throw_error(NULL, "Cannot create references to/from string offsets nor overloaded objects");
2408+
zend_throw_error(NULL, "Cannot create references to/from string offsets");
24092409
FREE_OP2_VAR_PTR();
24102410
HANDLE_EXCEPTION();
24112411
}

0 commit comments

Comments
 (0)