Fix GH-10489: run-tests.php does not escape path when building cmd

Multiple tests had to be changed to escape the arguments in shell
commands. Some tests are skipped because they behave differently with
spaces in the path versus without. One notable example of this is the
hashbang test which does not work because spaces in hashbangs paths are
not supported in Linux.

Author: nielsdos

Zend/tests/bug40236.phpt

@@ -6,7 +6,7 @@ if (extension_loaded("readline")) die("skip Test doesn't support readline");
 ?>
 --FILE--
 <?php
-$php = getenv('TEST_PHP_EXECUTABLE');
+$php = escapeshellarg(getenv('TEST_PHP_EXECUTABLE'));
 $cmd = "\"$php\" -n -d memory_limit=4M -a \"".__DIR__."\"/bug40236.inc";
 echo `$cmd`;
 ?>

Zend/tests/bug60978.phpt

@@ -3,7 +3,7 @@ Bug #60978 (exit code incorrect)
 --FILE--
 <?php
 $php = getenv('TEST_PHP_EXECUTABLE');
-exec($php . ' -n -r "exit(2);"', $output, $exit_code);
+exec(escapeshellarg($php) . ' -n -r "exit(2);"', $output, $exit_code);
 echo $exit_code;
 ?>
 --EXPECT--

ext/com_dotnet/tests/bug77578.phpt

@@ -6,7 +6,7 @@ com_dotnet
 <?php
 // To actually be able to verify the crash during shutdown on Windows, we have
 // to execute a PHP subprocess, and check its exit status.
-$php = PHP_BINARY;
+$php = escapeshellarg(PHP_BINARY);
 $ini = php_ini_loaded_file();
 $iniopt = $ini ? "-c $ini" : '';
 $command = "$php $iniopt -d extension=com_dotnet -d com.autoregister_typelib=1 -r \"new COM('WbemScripting.SWbemLocator');\"";

ext/mbstring/tests/gh7902.phpt

@@ -3,6 +3,7 @@ GH-7902 (mb_send_mail may delimit headers with LF only)
 --SKIPIF--
 <?php
 if (!extension_loaded("mbstring")) die("skip mbstring extension not available");
+if (str_contains(getcwd(), " ")) die("skip sendmail_path ini with spaces");
 ?>
 --INI--
 sendmail_path={MAIL:{PWD}/gh7902.eml}

ext/simplexml/tests/bug79971_1.phpt

@@ -3,6 +3,7 @@ Bug #79971 (special character is breaking the path in xml function)
 --SKIPIF--
 <?php
 if (!extension_loaded('simplexml')) die('skip simplexml extension not available');
+if (str_contains(getcwd(), ' ')) die('skip simplexml already escapes the path with spaces so this test does not work');
 ?>
 --FILE--
 <?php

ext/standard/tests/directory/bug74589_utf8.phpt

@@ -18,6 +18,7 @@ internal_encoding=utf-8
 $item = "bug74589_新建文件夹"; // utf-8 string
 $dir = __DIR__ . DIRECTORY_SEPARATOR . $item;
 $test_file = $dir . DIRECTORY_SEPARATOR . "test.php";
+$test_file_escaped = escapeshellarg($test_file);
 
 mkdir($dir);
 
@@ -27,9 +28,9 @@ file_put_contents($test_file,
     var_dump(__FILE__);
     var_dump(__DIR__ === __DIR__);");
 
-$php = getenv('TEST_PHP_EXECUTABLE');
+$php = escapeshellarg(getenv('TEST_PHP_EXECUTABLE'));
 
-echo shell_exec("$php -n $test_file");
+echo shell_exec("$php -n $test_file_escaped");
 
 ?>
 --EXPECTF--

ext/standard/tests/file/bug22414.phpt

@@ -1,5 +1,11 @@
 --TEST--
 Bug #22414 (passthru() does not read data correctly)
+--SKIPIF--
+<?php
+if (str_contains(getenv('TEST_PHP_EXECUTABLE'), " ")) {
+    die("skip can't escape shell argument properly uniformly");
+}
+?>
 --INI--
 output_handler=
 --FILE--

ext/standard/tests/file/bug26615.phpt

@@ -7,9 +7,9 @@ variables_order=E
 $out = array();
 $status = -1;
 if (substr(PHP_OS, 0, 3) != 'WIN') {
-    exec($_ENV['TEST_PHP_EXECUTABLE'].' -n -r \'for($i=1;$i<=5000;$i++) print "$i\n";\' | tr \'\n\' \' \'', $out, $status);
+    exec(escapeshellarg($_ENV['TEST_PHP_EXECUTABLE']).' -n -r \'for($i=1;$i<=5000;$i++) print "$i\n";\' | tr \'\n\' \' \'', $out, $status);
 } else {
-    exec($_ENV['TEST_PHP_EXECUTABLE'].' -n -r "for($i=1;$i<=5000;$i++) echo $i,\' \';"', $out, $status);
+    exec(escapeshellarg($_ENV['TEST_PHP_EXECUTABLE']).' -n -r "for($i=1;$i<=5000;$i++) echo $i,\' \';"', $out, $status);
 }
 print_r($out);
 ?>

ext/standard/tests/file/bug26938.phpt

@@ -4,7 +4,7 @@ Bug #26938 (exec does not read consecutive long lines correctly)
 <?php
 $out = array();
 $status = -1;
-$php = getenv('TEST_PHP_EXECUTABLE');
+$php = escapeshellarg(getenv('TEST_PHP_EXECUTABLE'));
 if (substr(PHP_OS, 0, 3) != 'WIN') {
     exec($php . ' -n -r \''
          . '$lengths = array(10,20000,10000,5,10000,3);'

ext/standard/tests/file/mkdir-002.phpt

@@ -24,7 +24,8 @@ var_dump(rmdir("./mkdir-002"));
 var_dump(mkdir(__DIR__."/mkdir-002", 0777));
 var_dump(mkdir(__DIR__."/mkdir-002/subdir", 0777));
 $dirname = __DIR__."/mkdir-002";
-var_dump(`ls -l $dirname`);
+$dirname_escaped = escapeshellarg($dirname);
+var_dump(`ls -l $dirname_escaped`);
 var_dump(rmdir(__DIR__."/mkdir-002/subdir"));
 var_dump(rmdir(__DIR__."/mkdir-002"));