Skip to content

Commit 1807673

Browse files
committed
make failed tests fail the test target
I don't see any reason to ignore failed tests. This makes it unnecessarily difficult to use ci, also for module builds.
1 parent 4029475 commit 1807673

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile.global

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ PHP_TEST_SHARED_EXTENSIONS = ` \
8686
PHP_DEPRECATED_DIRECTIVES_REGEX = '^(magic_quotes_(gpc|runtime|sybase)?|(zend_)?extension(_debug)?(_ts)?)[\t\ ]*='
8787

8888
test: all
89-
-@if test ! -z "$(PHP_EXECUTABLE)" && test -x "$(PHP_EXECUTABLE)"; then \
89+
@if test ! -z "$(PHP_EXECUTABLE)" && test -x "$(PHP_EXECUTABLE)"; then \
9090
INI_FILE=`$(PHP_EXECUTABLE) -d 'display_errors=stderr' -r 'echo php_ini_loaded_file();' 2> /dev/null`; \
9191
if test "$$INI_FILE"; then \
9292
$(EGREP) -h -v $(PHP_DEPRECATED_DIRECTIVES_REGEX) "$$INI_FILE" > $(top_builddir)/tmp-php.ini; \

0 commit comments

Comments
 (0)