From de96477cf213aac5bd2233dab9e176eed0158f83 Mon Sep 17 00:00:00 2001 From: Aydin Hassan Date: Wed, 21 Apr 2021 13:46:19 +0100 Subject: [PATCH 1/3] Path utils --- src/Utils/Path.php | 19 +++++++++++++++++ test/Utils/PathTest.php | 47 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+) create mode 100644 src/Utils/Path.php create mode 100644 test/Utils/PathTest.php diff --git a/src/Utils/Path.php b/src/Utils/Path.php new file mode 100644 index 00000000..fa47065e --- /dev/null +++ b/src/Utils/Path.php @@ -0,0 +1,19 @@ +assertEquals( + '/some/path/some-folder/file.txt', + Path::join('/some/path', 'some-folder/file.txt') + ); + + $this->assertEquals( + '/some/path/some-folder/file.txt', + Path::join('/some/path/', 'some-folder/file.txt') + ); + + $this->assertEquals( + '/some/path/some-folder/file.txt', + Path::join('/some/path', '/some-folder/file.txt') + ); + + $this->assertEquals( + '/some/path/some-folder/file.txt', + Path::join('/some/path/', '/some-folder/file.txt') + ); + + $this->assertEquals( + '/some/path/some-folder/file.txt', + Path::join('/some/path//', '//some-folder/file.txt') + ); + + $this->assertEquals( + '/some/path/some-folder/file.txt', + Path::join('/some/path/', 'some-folder', 'file.txt') + ); + + $this->assertEquals( + '/some/path/some-folder/file.txt', + Path::join('/some/path/', '/some-folder/', '/file.txt') + ); + } +} From febe9cb1a3d133e1551f5ffb53c1886bfec14562 Mon Sep 17 00:00:00 2001 From: Aydin Hassan Date: Wed, 21 Apr 2021 14:25:14 +0100 Subject: [PATCH 2/3] Try use pcov for coverage --- .github/workflows/php-workshop.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/php-workshop.yml b/.github/workflows/php-workshop.yml index 37040d83..1fd4afa4 100644 --- a/.github/workflows/php-workshop.yml +++ b/.github/workflows/php-workshop.yml @@ -24,7 +24,8 @@ jobs: with: php-version: ${{ matrix.php }} tools: composer:v2 - + coverage: pcov + - name: Install Dependencies run: composer update --prefer-dist From 8693d51b6d875fdbd5f024e858a97ee6c26c928c Mon Sep 17 00:00:00 2001 From: Aydin Hassan Date: Wed, 21 Apr 2021 14:28:35 +0100 Subject: [PATCH 3/3] Disable coverage --- .github/workflows/php-workshop.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/php-workshop.yml b/.github/workflows/php-workshop.yml index 1fd4afa4..17f3ca6c 100644 --- a/.github/workflows/php-workshop.yml +++ b/.github/workflows/php-workshop.yml @@ -24,8 +24,8 @@ jobs: with: php-version: ${{ matrix.php }} tools: composer:v2 - coverage: pcov - + coverage: none + - name: Install Dependencies run: composer update --prefer-dist