Fixup phpstan failures

Author: mikeymike

src/Solution/DirectorySolution.php

@@ -81,14 +81,14 @@ private function __construct(string $directory, string $entryPoint, array $exclu
      * @param string $directory The directory to search for files.
      * @param array<string> $exclusions An array of file names to exclude from the folder.
      * @param string $entryPoint The relative path from the directory of the entry point file.
-     * @return self
+     * @return SolutionInterface
      */
     public static function fromDirectory(
         string $directory,
         array $exclusions = [],
         $entryPoint = 'solution.php'
     ): SolutionInterface {
-        return InMemorySolution::fromSolution(
+        return InTempSolution::fromSolution(
             new self($directory, $entryPoint, array_merge($exclusions, ['composer.lock', 'vendor']))
         );
     }

src/Solution/InMemorySolution.php renamed to src/Solution/InTempSolution.php

@@ -4,15 +4,21 @@
 
 namespace PhpSchool\PhpWorkshop\Solution;
 
+use PhpSchool\PhpWorkshop\Utils\System;
 use Symfony\Component\Filesystem\Filesystem;
 
-class InMemorySolution implements SolutionInterface
+class InTempSolution implements SolutionInterface
 {
     /**
      * @var string
      */
     private string $baseDirectory;
 
+    /**
+     * @var string
+     */
+    private string $entryPoint;
+
     /**
      * @var SolutionFile[]
      */
@@ -22,21 +28,22 @@ private function __construct(SolutionInterface $solution)
     {
         $fileSystem = new Filesystem();
 
-        $currentPath = explode('/', realpath(__DIR__));
-        $solutionPath = explode('/', realpath($solution->getBaseDirectory()));
-        $entryPointPath = explode('/', realpath($solution->getEntryPoint()));
+        $tempDir = System::tempDir();
+        $currentPath = explode('/', System::realpath(__DIR__));
+        $solutionPath = explode('/', System::realpath($solution->getBaseDirectory()));
+        $entryPointPath = explode('/', System::realpath($solution->getEntryPoint()));
 
         $intersection = array_intersect($currentPath, $solutionPath);
 
         if (count($intersection) <= 1) {
-            $intersection = explode('/', realpath(sys_get_temp_dir()));
+            $intersection = explode('/', $tempDir);
         }
 
         $basename = implode('/', array_diff($solutionPath, $intersection));
         $entrypoint = implode('/', array_diff($entryPointPath, $intersection));
 
-        $this->baseDirectory = sprintf('%s/php-school/%s', realpath(sys_get_temp_dir()), $basename);
-        $this->entryPoint = sprintf('%s/php-school/%s', realpath(sys_get_temp_dir()), $entrypoint);
+        $this->baseDirectory = sprintf('%s/php-school/%s', $tempDir, $basename);
+        $this->entryPoint = sprintf('%s/php-school/%s', $tempDir, $entrypoint);
 
         if ($fileSystem->exists($this->baseDirectory)) {
             $fileSystem->remove($this->baseDirectory);
@@ -57,14 +64,14 @@ private function __construct(SolutionInterface $solution)
                 : $fileSystem->copy($file->getPathname(), $target);
         }
 
-        $this->files = array_map(function (SolutionFile $solutionFile) use ($intersection) {
-            $filePath = explode('/', realpath($solutionFile->__toString()));
+        $this->files = array_map(function (SolutionFile $solutionFile) use ($intersection, $tempDir) {
+            $filePath = explode('/', System::realpath($solutionFile->__toString()));
             $file = implode('/', array_diff($filePath, $intersection));
-            return SolutionFile::fromFile(sprintf('%s/php-school/%s', realpath(sys_get_temp_dir()), $file));
+            return SolutionFile::fromFile(sprintf('%s/php-school/%s', $tempDir, $file));
         }, $solution->getFiles());
     }
 
-    public static function fromSolution(SolutionInterface $solution)
+    public static function fromSolution(SolutionInterface $solution): SolutionInterface
     {
         return new self($solution);
     }

src/Solution/SingleFileSolution.php

@@ -33,12 +33,12 @@ private function __construct(string $file)
      * Static constructor to build an instance from an absolute file path.
      *
      * @param string $file The absolute path of the reference solution.
-     * @return self
+     * @return SolutionInterface
      * @throws InvalidArgumentException If the file does not exist.
      */
     public static function fromFile(string $file): SolutionInterface
     {
-        return InMemorySolution::fromSolution(new self($file));
+        return InTempSolution::fromSolution(new self($file));
     }
 
     /**

src/TestUtils/SolutionPathTransformer.php

@@ -9,6 +9,11 @@ class SolutionPathTransformer
     public static function tempPathToSolutionTempPath(string $tmpFilePath): string
     {
         $tmpDir = realpath(sys_get_temp_dir());
+
+        if (!$tmpDir) {
+            throw new \RuntimeException();
+        }
+
         $file = str_replace($tmpDir, '', $tmpFilePath);
 
         return sprintf('%s/php-school/%s', $tmpDir, ltrim($file, '/'));

src/Utils/System.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpSchool\PhpWorkshop\Utils;
+
+class System
+{
+    public static function realpath(string $path): string
+    {
+        $realpath = realpath($path);
+
+        if (false === $realpath) {
+            throw new \RuntimeException(sprintf('Failed to get realpath of "%s"', $path));
+        }
+
+        return $realpath;
+    }
+
+    public static function tempDir(): string
+    {
+        return self::realpath(sys_get_temp_dir());
+    }
+}