Merge pull request #70 from php-school/missing-args-pretty-error

Print error when missing command arguments

Author: AydinHassan

src/Application.php

@@ -6,7 +6,9 @@
 use DI\ContainerBuilder;
 use PhpSchool\PhpWorkshop\Check\CheckInterface;
 use PhpSchool\PhpWorkshop\Check\CheckRepository;
+use PhpSchool\PhpWorkshop\Exception\MissingArgumentException;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
+use PhpSchool\PhpWorkshop\Output\OutputInterface;
 use PhpSchool\PhpWorkshop\ResultRenderer\ResultRendererInterface;
 
 /**
@@ -161,7 +163,21 @@ public function run()
             $checkRepository->registerCheck($check);
         });
 
-        $router = $container->get(CommandRouter::class);
-        return $router->route();
+        try {
+            $exitCode = $container->get(CommandRouter::class)->route();
+        } catch (MissingArgumentException $e) {
+            $container
+                ->get(OutputInterface::class)
+                ->printError(
+                    sprintf(
+                        'Argument%s: "%s" %s missing!',
+                        count($e->getMissingArguments()) > 1 ? 's' : '',
+                        implode('", "', $e->getMissingArguments()),
+                        count($e->getMissingArguments()) > 1 ? 'are' : 'is'
+                    )
+                );
+            return 1;
+        }
+        return $exitCode;
     }
 }

src/Exception/MissingArgumentException.php

@@ -11,12 +11,18 @@
  */
 class MissingArgumentException extends RuntimeException
 {
+    /**
+     * @var array
+     */
+    private $missingArguments = [];
+
     /**
      * @param $commandName
      * @param array $missingArguments
      */
     public function __construct($commandName, array $missingArguments)
     {
+        $this->missingArguments = $missingArguments;
         parent::__construct(
             sprintf(
                 'Command: "%s" is missing the following arguments: "%s"',
@@ -25,4 +31,12 @@ public function __construct($commandName, array $missingArguments)
             )
         );
     }
+
+    /**
+     * @return array
+     */
+    public function getMissingArguments()
+    {
+        return $this->missingArguments;
+    }
 }

test/Exception/MissingArgumentExceptionTest.php

@@ -19,5 +19,7 @@ public function testException()
             'Command: "some-route" is missing the following arguments: "arg1", "arg2"',
             $e->getMessage()
         );
+
+        $this->assertSame(['arg1', 'arg2'], $e->getMissingArguments());
     }
 }