Skip to content

Conversation

@navarr
Copy link
Contributor

@navarr navarr commented Aug 25, 2021

Errata for proposed PR to introduce new types in PSR-16 (simple cache)

Proposed versions are:

@navarr navarr requested a review from a team as a code owner August 25, 2021 02:49
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold until this passes the required CC vote.

This is to prevent breakages with consumers
@navarr
Copy link
Contributor Author

navarr commented Aug 28, 2021

@Crell Is it OK/appropriate to edit the PSR example code to match the interface as defined by the errata as I have done in 069fd7f?

Errata clarifications may only be added to the meta document, not to the spec itself, as items in their own section. The spec itself may only be minimally edited to point readers toward a relevant errata if appropriate.

https://www.php-fig.org/bylaws/psr-workflow/

@navarr
Copy link
Contributor Author

navarr commented Aug 28, 2021

@dragoonis: You're the editor of PSR-16, would you support this errata?

@Geolim4
Copy link
Contributor

Geolim4 commented Sep 22, 2021

Hello @Jean85 any news about this ? When this MR will pass ?

@Jean85
Copy link
Member

Jean85 commented Sep 23, 2021

No vote has been called for the CC yet. We need @dragoonis to push it or someone else to take over.

@Crell
Copy link
Contributor

Crell commented Sep 24, 2021

Per the new bylaw updates, the CC can appoint a new Maintainer at its leisure. Or it can just make the updates on its own authority. We don't need Paul as he's clearly uninvolved anymore.

Copy link
Contributor

@Crell Crell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK now.

@Crell
Copy link
Contributor

Crell commented Sep 24, 2021

I think we can take this to a CC vote now. Everything seems good to me. Thanks, @Geolim4!

@Geolim4
Copy link
Contributor

Geolim4 commented Sep 24, 2021

I think we can take this to a CC vote now. Everything seems good to me. Thanks, @Geolim4!

Okay, nice. Poke me when you release the 3.0.0 so I can update my composer constraint asap.

Thanks again for your time boys.

@Geolim4
Copy link
Contributor

Geolim4 commented Sep 24, 2021

Per the new bylaw updates, the CC can appoint a new Maintainer at its leisure. Or it can just make the updates on its own authority. We don't need Paul as he's clearly uninvolved anymore.

@Crell does Maintainer application is open to anyone or only to Fig member ?
If it is open to external people, I would propose myself to maintain this PSR on behalf of Phpfastcache project.

@Crell
Copy link
Contributor

Crell commented Sep 24, 2021

The Maintainer of a given artifact is appointed by the Core Committee by Approval Vote. Once a given artifact is created, the Maintainer may step down and name a replacement Maintainer at any time with Implicit Approval. If necessary, a Decision vote to appoint a new Maintainer may be held following a suitable nomination period.

Could be anyone. I... think that's slightly confusing as written (and I JUST wrote it, damnit, where are my reviewers at???), but I think if you apply via the list and no one else is interested, we just have an Approval vote on you. If someone else also steps forward, we have a Decision Vote to choose among you.

That doesn't block a vote on these changes, though. Right now the CC itself is the maintainer, which means we can just call an Approval vote like we did on the others.

@Geolim4
Copy link
Contributor

Geolim4 commented Sep 28, 2021

@Crell @Jean85 when will the vote ends so I can plan an approximate date to update my dependencies. Thank you.

@Jean85
Copy link
Member

Jean85 commented Oct 6, 2021

@navarr I've added the \Throwable fix in #25 with php-fig/simple-cache@dd145de, should we add something here about it?

@navarr
Copy link
Contributor Author

navarr commented Oct 6, 2021

@Jean85 The symfony issue was specific to versions prior to 7.4 right? Are there any requirements from implementing libraries that come with this change?

I've currently got in my editor the diff:

- ### 8.1 Type additions
+ ### 8.1 Throwable
+ 
+ The 2.0 release of the `psr/simple-cache` package updates `Psr\SimpleCache\CacheException` to extend `Throwable`.
+ 
+ ### 8.2 Type additions

@Jean85
Copy link
Member

Jean85 commented Oct 6, 2021

Yes, the issue was only for PHP versions older than 7.4. Diff LGTM 👍 maybe just add a leading \ to Throwable to avoid confusion.

@navarr navarr requested review from Crell, Jean85 and garak October 6, 2021 13:56
Co-authored-by: Larry Garfield <[email protected]>
@Geolim4
Copy link
Contributor

Geolim4 commented Oct 13, 2021

Hello,

Sorry I'm bumping the PR again but when will this PHP-8 upgrade will be released ?

It's been while now that the PHP community waits for this upgrade.

Thank again.

@navarr
Copy link
Contributor Author

navarr commented Oct 14, 2021

This is now up for a vote with the Core Committee: https://groups.google.com/g/php-fig/c/DJ8ysB1JV4Y

@Geolim4
Copy link
Contributor

Geolim4 commented Oct 27, 2021

Hello, I'm bumping again but when will this v3 of the library will be released ?
The vote seems to take so long now :(

@navarr
Copy link
Contributor Author

navarr commented Oct 27, 2021

@Geolim4 indeed! We've passed quorum and have >2/3 of the entire committee voting yes. Voting officially ends tomorrow and then after that it can be merged.

So, I would expect this to get merged tomorrow

@vdelau vdelau merged commit 0fcb0b3 into php-fig:master Oct 28, 2021
@vdelau
Copy link
Member

vdelau commented Oct 28, 2021

The vote is concluded and the proposal is accepted (https://groups.google.com/g/php-fig/c/DJ8ysB1JV4Y/m/a9hNoIG5AwAJ)

@ADmad
Copy link

ADmad commented Oct 29, 2021

@Crell does Maintainer application is open to anyone or only to Fig member ?
If it is open to external people, I would propose myself to maintain this PSR on behalf of Phpfastcache project.

Can we get the ball rolling on making @Geolim4 a maintainer for the Simple Cache PSR? Clearly he's the one most interested it in keeping it up to date and has expressed his interest in helping maintain it. The PHP community would surely appreciate a more faster pace of handling updates than what FIG currently has to offer.

@Geolim4
Copy link
Contributor

Geolim4 commented Oct 29, 2021

@Crell does Maintainer application is open to anyone or only to Fig member ?
If it is open to external people, I would propose myself to maintain this PSR on behalf of Phpfastcache project.

Can we get the ball rolling on making @Geolim4 a maintainer for the Simple Cache PSR? Clearly he's the one most interested it in keeping it up to date and has expressed his interest in helping maintain it. The PHP community would surely appreciate a more faster pace of handling updates than what FIG currently has to offer.

Actually I'm one of the "rare" libraries that implements (and support) PSR-6 and PSR-16 (via adapter) and to release the next major release PHP-8 compatible only I needed this PSR to be updated, but I'm really surprised to be the only one concerned by this update, I was expecting more people involved.

@ADmad
Copy link

ADmad commented Oct 29, 2021

@Geolim4 The change for adding types really didn't need much of involvement from the community. Just the FIG team needed regularly nudges to move the process along, which thankfully we had you doing 🙂.

@navarr navarr deleted the patch-1 branch October 29, 2021 13:01
@Jean85 Jean85 removed the WIP label Oct 29, 2021
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Oct 29, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] allow/provide psr/simple-cache v2

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

As we already did for psr/cache.
See php-fig/fig-standards#1252 for background.

Commits
-------

d511251 [Cache] allow/provide psr/simple-cache v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants