-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Errata: Type additions #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errata: Type additions #1252
Conversation
Jean85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On hold until this passes the required CC vote.
This is to prevent breakages with consumers
|
@Crell Is it OK/appropriate to edit the PSR example code to match the interface as defined by the errata as I have done in 069fd7f?
|
|
@dragoonis: You're the editor of PSR-16, would you support this errata? |
Co-authored-by: Larry Garfield <[email protected]>
This reverts commit 069fd7f.
|
Hello @Jean85 any news about this ? When this MR will pass ? |
|
No vote has been called for the CC yet. We need @dragoonis to push it or someone else to take over. |
|
Per the new bylaw updates, the CC can appoint a new Maintainer at its leisure. Or it can just make the updates on its own authority. We don't need Paul as he's clearly uninvolved anymore. |
Crell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK now.
|
I think we can take this to a CC vote now. Everything seems good to me. Thanks, @Geolim4! |
Okay, nice. Poke me when you release the 3.0.0 so I can update my composer constraint asap. Thanks again for your time boys. |
@Crell does Maintainer application is open to anyone or only to Fig member ? |
Could be anyone. I... think that's slightly confusing as written (and I JUST wrote it, damnit, where are my reviewers at???), but I think if you apply via the list and no one else is interested, we just have an Approval vote on you. If someone else also steps forward, we have a Decision Vote to choose among you. That doesn't block a vote on these changes, though. Right now the CC itself is the maintainer, which means we can just call an Approval vote like we did on the others. |
|
@navarr I've added the |
|
@Jean85 The symfony issue was specific to versions prior to 7.4 right? Are there any requirements from implementing libraries that come with this change? I've currently got in my editor the diff: - ### 8.1 Type additions
+ ### 8.1 Throwable
+
+ The 2.0 release of the `psr/simple-cache` package updates `Psr\SimpleCache\CacheException` to extend `Throwable`.
+
+ ### 8.2 Type additions |
|
Yes, the issue was only for PHP versions older than 7.4. Diff LGTM 👍 maybe just add a leading |
Co-authored-by: Larry Garfield <[email protected]>
|
Hello, Sorry I'm bumping the PR again but when will this PHP-8 upgrade will be released ? It's been while now that the PHP community waits for this upgrade. Thank again. |
|
This is now up for a vote with the Core Committee: https://groups.google.com/g/php-fig/c/DJ8ysB1JV4Y |
|
Hello, I'm bumping again but when will this v3 of the library will be released ? |
|
@Geolim4 indeed! We've passed quorum and have >2/3 of the entire committee voting yes. Voting officially ends tomorrow and then after that it can be merged. So, I would expect this to get merged tomorrow |
|
The vote is concluded and the proposal is accepted (https://groups.google.com/g/php-fig/c/DJ8ysB1JV4Y/m/a9hNoIG5AwAJ) |
Can we get the ball rolling on making @Geolim4 a maintainer for the Simple Cache PSR? Clearly he's the one most interested it in keeping it up to date and has expressed his interest in helping maintain it. The PHP community would surely appreciate a more faster pace of handling updates than what FIG currently has to offer. |
Actually I'm one of the "rare" libraries that implements (and support) PSR-6 and PSR-16 (via adapter) and to release the next major release PHP-8 compatible only I needed this PSR to be updated, but I'm really surprised to be the only one concerned by this update, I was expecting more people involved. |
|
@Geolim4 The change for adding types really didn't need much of involvement from the community. Just the FIG team needed regularly nudges to move the process along, which thankfully we had you doing 🙂. |
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] allow/provide psr/simple-cache v2 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As we already did for psr/cache. See php-fig/fig-standards#1252 for background. Commits ------- d511251 [Cache] allow/provide psr/simple-cache v2
Errata for proposed PR to introduce new types in PSR-16 (simple cache)
Proposed versions are: