Skip to content

pdd.xml gets modified when it's executed under different commit author #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jan 14, 2024 · 1 comment
Closed

pdd.xml gets modified when it's executed under different commit author #1659

php-coder opened this issue Jan 14, 2024 · 1 comment
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented area/ci
Milestone
0.4.8

Comments

@php-coder
Copy link
Owner

This seems like a bug in pdd. Let's just remove <author> and <email> fields as a workaround.

Examples:

Relate to #1610
@php-coder php-coder added this to the 0.4.8 milestone Jan 14, 2024
@php-coder php-coder self-assigned this Jan 14, 2024
@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Jan 14, 2024
@php-coder
Copy link
Owner Author

php-coder commented May 27, 2024 •
edited
Loading

After upgrade to 0.24.0 I removed a workaround (b7a7af8) because pdd doesn't add author/email to pdd.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented area/ci
Projects
None yet
Milestone
0.4.8
Development

No branches or pull requests
1 participant
@php-coder