Skip to content

Commit aa3fb57

Browse files
committed
SeriesController: extract duplicated code to separate methods.
Related to #717 No functional changes.
1 parent 9a1d7b3 commit aa3fb57

File tree

1 file changed

+24
-20
lines changed

1 file changed

+24
-20
lines changed

src/main/java/ru/mystamps/web/controller/SeriesController.java

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,9 @@ public void showForm(
137137

138138
String lang = LocaleUtils.getLanguageOrNull(userLocale);
139139

140-
List<CategoryDto> categories =
141-
categoryService.findCategoriesWithParents(lang);
142-
List<FirstLevelCategoryDto> groupedCategories =
143-
GroupByParent.transformCategories(categories);
144-
model.addAttribute("categories", groupedCategories);
145-
146-
List<LinkEntityDto> countries = countryService.findAllAsLinkEntities(lang);
147-
model.addAttribute("countries", countries);
148-
149-
model.addAttribute("years", YEARS);
140+
addCategoriesToModel(model, lang);
141+
addCountriesToModel(model, lang);
142+
addYearToModel(model);
150143

151144
AddSeriesForm addSeriesForm = new AddSeriesForm();
152145
addSeriesForm.setPerforated(true);
@@ -222,16 +215,9 @@ public String processInput(
222215
if (result.hasErrors()) {
223216
String lang = LocaleUtils.getLanguageOrNull(userLocale);
224217

225-
List<CategoryDto> categories =
226-
categoryService.findCategoriesWithParents(lang);
227-
List<FirstLevelCategoryDto> groupedCategories =
228-
GroupByParent.transformCategories(categories);
229-
model.addAttribute("categories", groupedCategories);
230-
231-
List<LinkEntityDto> countries = countryService.findAllAsLinkEntities(lang);
232-
model.addAttribute("countries", countries);
233-
234-
model.addAttribute("years", YEARS);
218+
addCategoriesToModel(model, lang);
219+
addCountriesToModel(model, lang);
220+
addYearToModel(model);
235221

236222
// don't try to re-display file upload field
237223
form.setImage(null);
@@ -493,6 +479,24 @@ public String searchSeriesByCatalog(
493479
return "series/search_result";
494480
}
495481

482+
private void addCategoriesToModel(Model model, String lang) {
483+
List<CategoryDto> categories = categoryService.findCategoriesWithParents(lang);
484+
485+
List<FirstLevelCategoryDto> groupedCategories =
486+
GroupByParent.transformCategories(categories);
487+
488+
model.addAttribute("categories", groupedCategories);
489+
}
490+
491+
private void addCountriesToModel(Model model, String lang) {
492+
List<LinkEntityDto> countries = countryService.findAllAsLinkEntities(lang);
493+
model.addAttribute("countries", countries);
494+
}
495+
496+
private void addYearToModel(Model model) {
497+
model.addAttribute("years", YEARS);
498+
}
499+
496500
// CheckStyle: ignore LineLength for next 1 line
497501
private Map<String, ?> prepareCommonAttrsForSeriesInfo(SeriesDto series, Integer currentUserId) {
498502
Map<String, Object> model = new HashMap<>();

0 commit comments

Comments
 (0)