First attempt to make improvements of validation : it is draft .

Author: KrivenkoAlexander

src/main/java/ru/mystamps/web/feature/series/sale/AddSeriesSalesForm.java

@@ -17,22 +17,29 @@
  */
 package ru.mystamps.web.feature.series.sale;
 
+import javax.validation.GroupSequence;
+import javax.validation.constraints.NotNull;
+import javax.validation.constraints.Size;
 import lombok.Getter;
 import lombok.Setter;
 import org.hibernate.validator.constraints.URL;
 import org.springframework.format.annotation.DateTimeFormat;
 import ru.mystamps.web.dao.dto.Currency;
+import ru.mystamps.web.support.beanvalidation.FieldsMismatch;
 import ru.mystamps.web.support.beanvalidation.Group;
 import ru.mystamps.web.validation.ValidationRules;
-
-import javax.validation.GroupSequence;
-import javax.validation.constraints.NotNull;
-import javax.validation.constraints.Size;
 import java.math.BigDecimal;
 import java.util.Date;
 
 @Getter
 @Setter
+//@SellerAndBuyerSellSeriesMatch(
+//	message = "The sellers and buyers should be different"
+//)
+@FieldsMismatch(
+	first = "sellerId",
+	second ="buyerId"
+)
 public class AddSeriesSalesForm implements AddSeriesSalesDto {
 
 	@DateTimeFormat(pattern = "dd.MM.yyyy")

src/main/java/ru/mystamps/web/feature/series/sale/JdbcSeriesSalesDao.java

@@ -21,11 +21,11 @@
 import org.apache.commons.lang3.Validate;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
-
 import java.util.HashMap;
 import java.util.Map;
 
 @RequiredArgsConstructor
+
 public class JdbcSeriesSalesDao implements SeriesSalesDao {
 
 	private final NamedParameterJdbcTemplate jdbcTemplate;

src/main/java/ru/mystamps/web/feature/series/sale/SeriesSalesServiceImpl.java

@@ -23,10 +23,10 @@
 import org.springframework.security.access.prepost.PreAuthorize;
 import org.springframework.transaction.annotation.Transactional;
 import ru.mystamps.web.support.spring.security.HasAuthority;
-
 import java.util.Date;
 
 @RequiredArgsConstructor
+
 public class SeriesSalesServiceImpl implements SeriesSalesService {
 
 	private final Logger log;

src/main/java/ru/mystamps/web/support/beanvalidation/FieldsMatchValidator.java

@@ -59,7 +59,7 @@ public boolean isValid(Object value, ConstraintValidatorContext ctx) {
 
 		// FIXME: check fields only when both fields are equals
 
-		if (!firstFieldValue.equals(secondFieldValue)) {
+		if (firstFieldValue.equals(secondFieldValue)) {
 			// bind error message to 2nd field
 			ConstraintViolationUtils.recreate(
 				ctx,

src/main/java/ru/mystamps/web/support/beanvalidation/SellerAndBuyerSellSeriesMatch.java

@@ -0,0 +1,41 @@
+/*
+ * Copyright (C) 2009-2019 Slava Semushin <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.support.beanvalidation;
+
+
+import javax.validation.Constraint;
+import javax.validation.Payload;
+import java.lang.annotation.Documented;
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+
+
+import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
+import static java.lang.annotation.ElementType.TYPE;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+@Target({ TYPE, ANNOTATION_TYPE })
+@Retention(RUNTIME)
+@Constraint(validatedBy = SellerAndBuyerSellSeriesValidator.class)
+@Documented
+public @interface SellerAndBuyerSellSeriesMatch {
+	String message();
+	Class<?>[] groups() default { };
+	Class<? extends Payload>[] payload() default { };
+	
+}

src/main/java/ru/mystamps/web/support/beanvalidation/SellerAndBuyerSellSeriesValidator.java

@@ -0,0 +1,40 @@
+package ru.mystamps.web.support.beanvalidation;
+
+import javax.validation.ConstraintValidator;
+import javax.validation.ConstraintValidatorContext;
+import org.springframework.beans.BeanWrapperImpl;
+import org.springframework.beans.PropertyAccessor;
+
+public class SellerAndBuyerSellSeriesValidator implements ConstraintValidator<SellerAndBuyerSellSeriesMatch,Object> {
+	
+	private Integer sellerId;
+	private Integer buyerId;
+
+	@Override
+	public void initialize(SellerAndBuyerSellSeriesMatch sellerAndBuyerSellSeriesMatch) {
+	}
+
+	@Override
+	public boolean isValid(Object form, ConstraintValidatorContext ctx) {
+		if (form == null) {
+			return  true;
+		}
+		PropertyAccessor wrapper = new BeanWrapperImpl(form);
+		sellerId= (Integer) wrapper.getPropertyValue("sellerId");
+		
+		buyerId=(Integer) wrapper.getPropertyValue("buyerId");
+		
+		
+		if (sellerId.intValue() == buyerId.intValue()) {
+
+			ConstraintViolationUtils.recreate(
+				ctx,
+				String.valueOf(buyerId),
+				ctx.getDefaultConstraintMessageTemplate()
+			);
+			return false;
+		}
+		
+		return false;
+	}
+}