Skip to content

Commit 8506bf3

Browse files
committed
refactor(WhenUserAddSeries): port shouldIgnoreDuplicatedCatalogNumbers() to Robot Framework.
Also remove a similar test from misc-admin.robot: one test for that case is enough. If this will be broken only for admin it won't be so critical as when it's broken for users. Addressed to #530 No functional changes.
1 parent f577589 commit 8506bf3

File tree

3 files changed

+20
-46
lines changed

3 files changed

+20
-46
lines changed

src/test/java/ru/mystamps/web/tests/cases/WhenUserAddSeries.java

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -194,32 +194,6 @@ public void shouldCreateSeriesWithAllFieldsFilled() {
194194
assertThat(nextPage.getZagorskiCatalogInfo()).isEqualTo("#50-52 (150.2 RUB)");
195195
}
196196

197-
@Test(groups = "logic")
198-
public void shouldIgnoreDuplicatedCatalogNumbers() {
199-
page.fillCategory(validCategoryName);
200-
page.fillQuantity("2");
201-
page.fillImage(SAMPLE_IMAGE_PATH);
202-
page.showCatalogNumbers();
203-
204-
page.fillMichelNumbers("4,5,4");
205-
page.fillScottNumbers("14,15,14");
206-
page.fillYvertNumbers("24,25,24");
207-
page.fillGibbonsNumbers("34,35,34");
208-
page.fillSolovyovNumbers("44,45,44");
209-
page.fillZagorskiNumbers("54,55,54");
210-
211-
AbstractPage next = page.submit();
212-
assertThat(next).isInstanceOf(InfoSeriesPage.class);
213-
214-
InfoSeriesPage nextPage = (InfoSeriesPage)next;
215-
assertThat(nextPage.getMichelCatalogInfo()).isEqualTo("#4, 5");
216-
assertThat(nextPage.getScottCatalogInfo()).isEqualTo("#14, 15");
217-
assertThat(nextPage.getYvertCatalogInfo()).isEqualTo("#24, 25");
218-
assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#34, 35");
219-
assertThat(nextPage.getSolovyovCatalogInfo()).isEqualTo("#44, 45");
220-
assertThat(nextPage.getZagorskiCatalogInfo()).isEqualTo("#54, 55");
221-
}
222-
223197
@Test(groups = "logic")
224198
public void shouldAllowExistingCatalogNumbers() {
225199
page.fillCategory(validCategoryName);

src/test/robotframework/series/creation/misc-admin.robot

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,6 @@ Suite Teardown After Test Suite
77
Force Tags series misc
88

99
*** Test Cases ***
10-
Catalog numbers should ignore duplicate values
11-
[Tags] unstable
12-
Select From List By Label id=category Sport
13-
Input Text id=quantity 2
14-
Choose File id=image ${MAIN_RESOURCE_DIR}${/}test.png
15-
Click Element id=add-catalog-numbers-link
16-
Input Text id=michelNumbers 104,105,104
17-
Input Text id=scottNumbers 114,115,114
18-
Input Text id=yvertNumbers 124,125,124
19-
Input Text id=gibbonsNumbers 134,135,134
20-
Input Text id=solovyovNumbers 144,145,144
21-
Input Text id=zagorskiNumbers 154,155,154
22-
Submit Form id=add-series-form
23-
Element Text Should Be id=michel_catalog_info \#104, 105
24-
Element Text Should Be id=scott_catalog_info \#114, 115
25-
Element Text Should Be id=yvert_catalog_info \#124, 125
26-
Element Text Should Be id=gibbons_catalog_info \#134, 135
27-
Element Text Should Be id=solovyov_catalog_info \#144, 145
28-
Element Text Should Be id=zagorski_catalog_info \#154, 155
29-
3010
Catalog numbers should accept existing numbers
3111
Go To ${SITE_URL}/series/add
3212
Select From List By Label id=category Sport

src/test/robotframework/series/creation/misc-user.robot

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,26 @@ Catalog numbers should be stripped from any spaces
4444
Textfield Value Should Be id=solovyovNumbers 9,10
4545
Textfield Value Should Be id=zagorskiNumbers 11,12
4646

47+
Catalog numbers should ignore duplicate values
48+
[Tags] unstable
49+
Select From List By Label id=category Sport
50+
Input Text id=quantity 2
51+
Choose File id=image ${MAIN_RESOURCE_DIR}${/}test.png
52+
Click Element id=add-catalog-numbers-link
53+
Input Text id=michelNumbers 104,105,104
54+
Input Text id=scottNumbers 114,115,114
55+
Input Text id=yvertNumbers 124,125,124
56+
Input Text id=gibbonsNumbers 134,135,134
57+
Input Text id=solovyovNumbers 144,145,144
58+
Input Text id=zagorskiNumbers 154,155,154
59+
Submit Form id=add-series-form
60+
Element Text Should Be id=michel_catalog_info \#104, 105
61+
Element Text Should Be id=scott_catalog_info \#114, 115
62+
Element Text Should Be id=yvert_catalog_info \#124, 125
63+
Element Text Should Be id=gibbons_catalog_info \#134, 135
64+
Element Text Should Be id=solovyov_catalog_info \#144, 145
65+
Element Text Should Be id=zagorski_catalog_info \#154, 155
66+
4767
*** Keywords ***
4868
Before Test Suite
4969
Open Browser ${SITE_URL}/account/auth ${BROWSER}

0 commit comments

Comments
 (0)