Skip to content

Commit 4390283

Browse files
committed
refactor(WhenAnonymousUserRegisterAccount): port emailShouldBeValid() to Robot Framework.
Addressed to #530 No functional changes.
1 parent c98d127 commit 4390283

File tree

2 files changed

+12
-19
lines changed

2 files changed

+12
-19
lines changed

src/test/java/ru/mystamps/web/tests/cases/WhenAnonymousUserRegisterAccount.java

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import org.testng.annotations.AfterClass;
2424
import org.testng.annotations.BeforeClass;
2525
import org.testng.annotations.BeforeMethod;
26-
import org.testng.annotations.DataProvider;
2726
import org.testng.annotations.Test;
2827
import ru.mystamps.web.Url;
2928
import ru.mystamps.web.tests.page.RegisterAccountPage;
@@ -90,21 +89,14 @@ public void shouldExistsMessageWithLinkToAuthenticationPage() {
9089
.isTrue();
9190
}
9291

93-
@Test(groups = "invalid", dataProvider = "invalidEmails")
94-
public void emailShouldBeValid(String invalidEmail, String expectedMessage) {
95-
page.registerUser(invalidEmail);
96-
97-
assertThat(page).field("email").hasError(expectedMessage);
98-
}
99-
10092
@Test(groups = "misc")
10193
public void emailShouldBeStripedFromLeadingAndTrailingSpaces() {
10294
page.registerUser(" test ");
10395

10496
assertThat(page).field("email").hasValue("test");
10597
}
10698

107-
@Test(groups = "logic", dependsOnGroups = { "invalid", "misc" })
99+
@Test(groups = "logic", dependsOnGroups = { "misc" })
108100
public void successfulMessageShouldBeShownAfterRegistration() {
109101
page.registerUser("[email protected]");
110102

@@ -158,14 +150,4 @@ public void emailWithActivationKeyShouldBeSentAfterRegistration()
158150
.isTrue();
159151
}
160152

161-
@DataProvider(name = "invalidEmails")
162-
public Object[][] getInvalidEmails() {
163-
String expectedErrorMessage = tr("ru.mystamps.web.support.beanvalidation.Email.message");
164-
165-
return new Object[][] {
166-
{"login", expectedErrorMessage},
167-
{"login@domain", expectedErrorMessage}
168-
};
169-
}
170-
171153
}

src/test/robotframework/account/registration/validation.robot

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,21 @@ Register account with too long email
1212
Submit Form id=register-account-form
1313
Element Text Should Be id=email.errors Value is greater than allowable maximum of 255 characters
1414

15+
Register account with invalid email
16+
[Template] Invalid Email Should Be Rejected
17+
login
18+
login@domain
19+
1520
*** Keywords ***
1621
Before Test Suite
1722
Open Browser ${SITE_URL}/account/register ${BROWSER}
1823
Register Keyword To Run On Failure Log Source
1924

2025
After Test Suite
2126
Close Browser
27+
28+
Invalid Email Should Be Rejected
29+
[Arguments] ${email}
30+
Input Text id=email ${email}
31+
Submit Form id=register-account-form
32+
Element Text Should Be id=email.errors Invalid e-mail address

0 commit comments

Comments
 (0)