SeriesSalesImportServiceImpl.getParsedData(): add unit teststs.

Fix #835

Author: php-coder

src/main/java/ru/mystamps/web/service/SeriesSalesImportServiceImpl.java

@@ -45,7 +45,6 @@ public void saveParsedData(Integer requestId, SeriesSalesParsedDataDbDto data) {
 		seriesSalesImportDao.addParsedData(requestId, data);
 	}
 
-	// @todo #695 SeriesSalesImportServiceImpl.getParsedData(): add unit tests
 	@Override
 	@Transactional(readOnly = true)
 	public SeriesSaleParsedDataDto getParsedData(Integer requestId) {

src/test/groovy/ru/mystamps/web/service/SeriesSalesImportServiceImplTest.groovy

@@ -22,6 +22,7 @@ import org.slf4j.helpers.NOPLogger
 import spock.lang.Specification
 
 import ru.mystamps.web.dao.SeriesSalesImportDao
+import ru.mystamps.web.dao.dto.SeriesSaleParsedDataDto
 import ru.mystamps.web.dao.dto.SeriesSalesParsedDataDbDto
 import ru.mystamps.web.tests.Random
 
@@ -66,4 +67,28 @@ class SeriesSalesImportServiceImplTest extends Specification {
 			1 * seriesSalesImportDao.addParsedData(expectedRequestId, expectedParsedData)
 	}
 
+	//
+	// Tests for getParsedData()
+	//
+	
+	def 'getParsedData() should throw exception when request id is null'() {
+		when:
+			service.getParsedData(null)
+		then:
+			IllegalArgumentException ex = thrown()
+			ex.message == 'Request id must be non null'
+	}
+	
+	def 'getParsedData() should invoke dao and return its result'() {
+		given:
+			Integer expectedRequestId = Random.id()
+			SeriesSaleParsedDataDto expectedResult = TestObjects.createSeriesSaleParsedDataDto()
+		when:
+			SeriesSaleParsedDataDto result = service.getParsedData(expectedRequestId)
+		then:
+			1 * seriesSalesImportDao.findParsedDataByRequestId(expectedRequestId) >> expectedResult
+		and:
+			result == expectedResult
+	}
+	
 }

src/test/java/ru/mystamps/web/service/TestObjects.java

@@ -296,4 +296,8 @@ public static SeriesSalesParsedDataDbDto createSeriesSalesParsedDataDbDto() {
 		return dto;
 	}
 
+	public static SeriesSaleParsedDataDto createSeriesSaleParsedDataDto() {
+		return new SeriesSaleParsedDataDto(Random.id(), Random.price(), Random.currency());
+	}
+	
 }