workaround optimization problem, cleanup tools\winiot

Author: Paul Monson

.gitignore

@@ -71,6 +71,7 @@ PCbuild/*.VC.opendb
 PCbuild/.vs/
 PCbuild/amd64/
 PCbuild/arm32/
+PCbuild/iot/
 PCbuild/obj/
 PCbuild/win32/
 .purify

Lib/test/test_ssl.py

@@ -1319,7 +1319,7 @@ def test_load_verify_cadata(self):
         with self.assertRaisesRegex(ssl.SSLError, "not enough data"):
             ctx.load_verify_locations(cadata=b"broken")
 
-    @unittest.skipIf(platform.machine() == 'ARM', "ssl error needs investigation")
+    @unittest.skipIf(platform.win32_editionId() == 'IoTUAP' and 'python_d' in sys.executable, "Crashes on debug python builds on Windows IoT Core")
     def test_load_dh_params(self):
         ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER)
         ctx.load_dh_params(DHFILE)
@@ -1621,7 +1621,7 @@ def test_str(self):
         self.assertEqual(str(e), "foo")
         self.assertEqual(e.errno, 1)
 
-    @unittest.skipIf(platform.machine() == 'ARM', "ssl error needs investigation")
+    @unittest.skipIf(platform.win32_editionId() == 'IoTUAP' and 'python_d' in sys.executable, "Crashes on debug python builds on Windows IoT Core")
     def test_lib_reason(self):
         # Test the library and reason attributes
         ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
@@ -3726,7 +3726,7 @@ def test_compression_disabled(self):
                                    sni_name=hostname)
         self.assertIs(stats['compression'], None)
 
-    @unittest.skipIf(platform.machine() == 'ARM', "ssl error needs investigation")
+    @unittest.skipIf(platform.win32_editionId() == 'IoTUAP' and 'python_d' in sys.executable, "Crashes on debug python builds on Windows IoT Core")
     def test_dh_params(self):
         # Check we can get a connection with ephemeral Diffie-Hellman
         client_context, server_context, hostname = testing_context()

Python/ceval.c

@@ -547,6 +547,10 @@ PyEval_EvalFrameEx(PyFrameObject *f, int throwflag)
     return tstate->interp->eval_frame(f, throwflag);
 }
 
+#ifdef _M_ARM
+#pragma optimize ("", off)
+#endif // _M_ARM
+
 PyObject* _Py_HOT_FUNCTION
 _PyEval_EvalFrameDefault(PyFrameObject *f, int throwflag)
 {
@@ -3500,6 +3504,10 @@ _PyEval_EvalFrameDefault(PyFrameObject *f, int throwflag)
     return _Py_CheckFunctionResult(NULL, retval, "PyEval_EvalFrameEx");
 }
 
+#ifdef _M_ARM
+#pragma optimize ("", on)
+#endif // _M_ARM
+
 static void
 format_missing(const char *kind, PyCodeObject *co, PyObject *names)
 {

Tools/winiot/build.bat

@@ -2,39 +2,29 @@
 setlocal
 set D=%~dp0
 set PCBUILD=%D%..\..\PCbuild\
+set PYTHON_EXE=%PCBUILD%..\externals\pythonx86\tools\python.exe
 if "%Py_OutDir%"=="" set Py_OutDir=%PCBUILD%
 
 set BUILDX86=
 set BUILDX64=
 set BUILDARM=
-set SYNCX86=
-set SYNCX64=
-set SYNCARM=
 set REBUILD=
-set OUTPUT=
-set PACKAGES=
 set DEBUG=
-set DEBUG_SUFFIX=
+set TEST=
+set _SUFFIX=
 
 :CheckOpts
 if "%~1" EQU "-h" goto Help
-if "%~1" EQU "-x86" (set BUILDX86=1 && set SYNCX86=1) && shift && goto CheckOpts
-if "%~1" EQU "-x64" (set BUILDX64=1 && set SYNCX64=1) && shift && goto CheckOpts
-if "%~1" EQU "-arm" (set BUILDARM=1 && set SYNCARM=1) && shift && goto CheckOpts
+if "%~1" EQU "-x86" (set BUILDX86=1) && shift && goto CheckOpts
+if "%~1" EQU "-x64" (set BUILDX64=1) && shift && goto CheckOpts
+if "%~1" EQU "-arm" (set BUILDARM=1) && shift && goto CheckOpts
+if "%~1" EQU "-t" (set TEST=-t) && shift && goto CheckOpts
 if "%~1" EQU "-r" (set REBUILD=-r) && shift && goto CheckOpts
 if "%~1" EQU "-d" (set DEBUG=-d && set _SUFFIX=_d) && shift && goto CheckOpts
-if "%~1" EQU "-o" (set OUTPUT="/p:OutputPath=%~2") && shift && shift && goto CheckOpts
-if "%~1" EQU "--out" (set OUTPUT="/p:OutputPath=%~2") && shift && shift && goto CheckOpts
-if "%~1" EQU "-p" (set PACKAGES=%PACKAGES% %~2) && shift && shift && goto CheckOpts
 if "%~1" NEQ "" echo Unknown parameter "%~1" && exit
 
 if not defined BUILDX86 if not defined BUILDX64 if not defined BUILDARM (set BUILDX86=1) && (set BUILDX64=1) && (set BUILDARM=1)
 
-:: need x64 python.exe to run sync_win_iot.pl when only building for ARM
-if defined BUILDARM (
-    if not exist "%PCBUILD%amd64\python.exe" ( set BUILDX64=1 )
-)
-
 call "%PCBUILD%find_msbuild.bat" %MSBUILD%
 if ERRORLEVEL 1 (echo Cannot locate MSBuild.exe on PATH or as MSBUILD variable & exit /b 2)
 
@@ -45,29 +35,26 @@ if defined DEBUG (set CONFIGURATION=Debug
 
 if defined BUILDX86 (
     if defined REBUILD ( call "%PCBUILD%build.bat" -e -r
-    ) else if not exist "%Py_OutDir%win32\python.exe" call "%PCBUILD%build.bat" -e %DEBUG% 
+    ) else if not exist "%Py_OutDir%win32\python%_SUFFIX%.exe" call "%PCBUILD%build.bat" -e %DEBUG% 
     if errorlevel 1 goto :eof
 
-    if defined SYNCX86 ( %MSBUILD% "%D%sync_win_iot.proj" /p:Configuration=%CONFIGURATION% /p:Platform=x86 %OUTPUT% %PACKAGES% %WINIOT% )
-    if errorlevel 1 goto :eof
+    %PYTHON_EXE% %D%sync_win_iot.py %DEBUG% %TEST% -p win32
 )
 
 if defined BUILDX64 (
     if defined REBUILD ( call "%PCBUILD%build.bat" -p x64 -e -r
-    ) else if not exist "%Py_OutDir%amd64\python.exe" call "%PCBUILD%build.bat" -p x64 -e %DEBUG% 
+    ) else if not exist "%Py_OutDir%amd64\python%_SUFFIX%.exe" call "%PCBUILD%build.bat" -p x64 -e %DEBUG% 
     if errorlevel 1 goto :eof
 
-    if defined SYNCX64 ( %MSBUILD% "%D%sync_win_iot.proj" /p:Configuration=%CONFIGURATION% /p:Platform=x64 %OUTPUT% %PACKAGES% %WINIOT% )
-    if errorlevel 1 goto :eof
+    %PYTHON_EXE% %D%sync_win_iot.py %DEBUG% %TEST% -p amd64
 )
 
 if defined BUILDARM (
-    if defined REBUILD ( call "%PCBUILD%build.bat" -p ARM -e %DEBUG% -r --no-tkinter --no-ssl --no-vs
-    ) else if not exist "%Py_OutDir%arm32\python%_SUFFIX%.exe" call "%PCBUILD%build.bat" -p ARM -e %DEBUG% --no-tkinter --no-vs
+    if defined REBUILD ( call "%PCBUILD%build.bat" -p ARM -e %DEBUG% -r --no-tkinter --no-vs
+    ) else if not exist "%Py_OutDir%arm32\python%_SUFFIX%.exe" call "%PCBUILD%build.bat" -p ARM -E %DEBUG% --no-tkinter --no-vs
     if errorlevel 1 goto :eof
 
-    if defined SYNCARM ( %MSBUILD% "%D%sync_win_iot.proj" /p:Configuration=%CONFIGURATION% /p:Platform=ARM  /p:"PythonExe=%PCBUILD%amd64\python.exe" %OUTPUT% %PACKAGES% %WINIOT%  )
-    if errorlevel 1 goto :eof
+    %PYTHON_EXE% %D%sync_win_iot.py %DEBUG% %TEST% -p arm32
 )
 
 exit /B 0
@@ -78,7 +65,7 @@ echo.
 echo    -x86                Build and sync x86 files
 echo    -x64                Build and sync x64 files
 echo    -arm                Build and sync arm files (will build X64 to execute tools)
+echo    -t                  Include test files
 echo    -d                  Build Debug configuration
 echo    -r                  Rebuild rather than incremental build
-echo    --out [DIR]         Override output directory
 echo    -h                  Show usage