Skip to content

Commit ff9cddf

Browse files
author
Devdutt Shenoi
committed
don't panic on missing file
1 parent 0e41597 commit ff9cddf

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

src/parseable/staging/reader.rs

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ use arrow_ipc::{reader::StreamReader, root_as_message_unchecked, MessageHeader};
3030
use arrow_schema::Schema;
3131
use byteorder::{LittleEndian, ReadBytesExt};
3232
use itertools::kmerge_by;
33-
use tracing::error;
33+
use tracing::{error, warn};
3434

3535
use crate::{
3636
event::DEFAULT_TIMESTAMP_KEY,
@@ -82,11 +82,16 @@ pub struct MergedReverseRecordReader {
8282
}
8383

8484
impl MergedReverseRecordReader {
85-
pub fn try_new(files: &[PathBuf]) -> Self {
86-
let mut readers = Vec::with_capacity(files.len());
87-
for file in files {
88-
let Ok(reader) = get_reverse_reader(File::open(file).unwrap()) else {
89-
error!("Invalid file detected, ignoring it: {:?}", file);
85+
pub fn try_new(file_paths: &[PathBuf]) -> Self {
86+
let mut readers = Vec::with_capacity(file_paths.len());
87+
for path in file_paths {
88+
let Ok(file) = File::open(&path) else {
89+
warn!("Error when trying to read file: {path:?}");
90+
continue;
91+
};
92+
93+
let Ok(reader) = get_reverse_reader(file) else {
94+
error!("Invalid file detected, ignoring it: {path:?}");
9095
continue;
9196
};
9297

0 commit comments

Comments
 (0)