Fix

Author: trueleo

server/src/handlers/http/rbac.rs

@@ -79,7 +79,7 @@ pub async fn reset_password(username: web::Path<String>) -> Result<impl Responde
         .iter_mut()
         .find(|user| user.username == username)
     {
-        user.password_hash = hash.clone();
+        user.password_hash.clone_from(&hash);
     } else {
         // should be unreachable given state is always consistent
         return Err(RBACError::UserDoesNotExist);

server/src/migration.rs

@@ -45,14 +45,14 @@ pub async fn run_metadata_migration(config: &Config) -> anyhow::Result<()> {
     }
 
     if let Some(storage_metadata) = storage_metadata {
-        if let Some("v1") = dbg!(get_version(&storage_metadata)) {
+        if get_version(&storage_metadata) == Some("v1") {
             let metadata = metadata_migration::v1_v2(storage_metadata);
             put_remote_metadata(&*object_store, &metadata).await?;
         }
     }
 
     if let Some(staging_metadata) = staging_metadata {
-        if let Some("v1") = get_version(&staging_metadata) {
+        if get_version(&staging_metadata) == Some("v1") {
             let metadata = metadata_migration::v1_v2(staging_metadata);
             put_staging_metadata(config, &metadata)?;
         }