Classify installation with pushType and failback with deviceType #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffjen
changed the title
|
GIVen the android code, the push type should be |
jeffjen
changed the title
|
Without breaking a lot of people, made the classification fail back if pushType is not explicitly configured from senderType |
|
We'lll need the pushType based classification even more as fcm is gonna replace GCMand we need to let both live together :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote an adapter that basically extend the ParsePushAdapter, keeping the overall logic, and added custom Firebase Cloud Messaging driver. From what I read from the documents it should be pushType, not deviceType, that will determine which sender should be adpted.