-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
test: improve PushController tests #7760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## alpha #7760 +/- ##
==========================================
+ Coverage 93.95% 93.96% +0.01%
==========================================
Files 183 183
Lines 13640 13640
==========================================
+ Hits 12815 12817 +2
+ Misses 825 823 -2
Continue to review full report at Codecov.
|
@mtrezza this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I see all beautiful green!
🎉 This change has been released in version 5.0.0-alpha.16 |
🎉 This change has been released in version 5.0.0-beta.10 |
🎉 This change has been released in version 5.1.0 |
New Pull Request Checklist
Issue Description
Every once in awhile some of these tests fail on Postgres. The timer is set low, so giving it a small bump.
Related issue: #7180
Approach
Improve some of the PushController tests to use async/await. Increase sleep timer to prevent random failures on Postgres.
TODOs before merging