From f01cb8c670bc7c6e37a1583148576e1842294f2a Mon Sep 17 00:00:00 2001 From: Drew Date: Fri, 5 Feb 2016 11:58:52 -0800 Subject: [PATCH 1/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index faaae4e388..35920404ee 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,8 +6,9 @@ We really want Parse to be yours, to see it grow and thrive in the open source c ##### Please Do's -* Please write tests to cover new methods. -* Please run the tests and make sure you didn't break anything. +* Take testing seriously! Aim to increase the test coverage with every pull request. +* Run the tests for the file you are working on with `TESTING=1 ./node_modules/jasmine/bin/jasmine.js --filter="MyFile"` (from repo root) +* Run the tests for the whole project and look at the coverage report to make sure your tests are exhaustive by running `npm test` and looking at (project-root)/lcov-report/parse-server/FileUnderTest.js.html ##### Code of Conduct From 53ffbde962457587f7a53acc49e82e706cc72c65 Mon Sep 17 00:00:00 2001 From: Drew Date: Fri, 5 Feb 2016 12:52:14 -0800 Subject: [PATCH 2/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 35920404ee..23e6107df2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ We really want Parse to be yours, to see it grow and thrive in the open source c ##### Please Do's * Take testing seriously! Aim to increase the test coverage with every pull request. -* Run the tests for the file you are working on with `TESTING=1 ./node_modules/jasmine/bin/jasmine.js --filter="MyFile"` (from repo root) +* Run the tests for the file you are working on with `TESTING=1 (repo-root)/node_modules/jasmine/bin/jasmine.js spec/ParseFile.spec.js` * Run the tests for the whole project and look at the coverage report to make sure your tests are exhaustive by running `npm test` and looking at (project-root)/lcov-report/parse-server/FileUnderTest.js.html ##### Code of Conduct From 8fc11314e716f475e020cbbe5e29cd443e637a5d Mon Sep 17 00:00:00 2001 From: Drew Date: Fri, 5 Feb 2016 12:52:36 -0800 Subject: [PATCH 3/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 23e6107df2..397621264d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ We really want Parse to be yours, to see it grow and thrive in the open source c ##### Please Do's * Take testing seriously! Aim to increase the test coverage with every pull request. -* Run the tests for the file you are working on with `TESTING=1 (repo-root)/node_modules/jasmine/bin/jasmine.js spec/ParseFile.spec.js` +* Run the tests for the file you are working on with `TESTING=1 (repo-root)/node_modules/jasmine/bin/jasmine.js spec/MyFile.spec.js` * Run the tests for the whole project and look at the coverage report to make sure your tests are exhaustive by running `npm test` and looking at (project-root)/lcov-report/parse-server/FileUnderTest.js.html ##### Code of Conduct