Skip to content

Deprecate current pages implementation #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
mtrezza opened this issue Oct 13, 2021 · 6 comments · Fixed by #9526
Closed
4 tasks done

Deprecate current pages implementation #7625

mtrezza opened this issue Oct 13, 2021 · 6 comments · Fixed by #9526
Labels
block:major Needs to be resolved before next major release; remove label afterwards bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released-alpha Released as alpha version type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021 •
edited
Loading

New Issue Checklist

Issue Description

A new pages router has been introduced with #7128. The PagesRouter has since been thoroughly tested and can be moved out of experimental status.

For Parse Server 5.0-beta, the current router should be deprecated in favor of the new PagesRouter.

Steps to reproduce

n/a

Actual Outcome

n/a

Expected Outcome

n/a

Environment

Server

  • Parse Server version: 5.0.0-alpha.1
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 13, 2021 •
edited
Loading

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added type:improvement bounty:$5 Bounty applies for fixing this issue (Parse Bounty Program) labels Oct 13, 2021
@mtrezza mtrezza added bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) and removed bounty:$5 Bounty applies for fixing this issue (Parse Bounty Program) labels Oct 30, 2021
@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
@vibh1103
Copy link

vibh1103 commented Oct 9, 2023

Hi @mtrezza can i pick this task ?

@mtrezza
Copy link
Member Author

mtrezza commented Oct 9, 2023

Sure, please feel free. Now would be a good time, so we can merge a PR in November for Parse Server 7 release.

@vibh1103
Copy link

vibh1103 commented Oct 9, 2023

@mtrezza can you please share some reference PR's previously we deprecated the feature.

@mtrezza
Copy link
Member Author

mtrezza commented Oct 9, 2023

You could search for "deprecate" in the merged PRs, to see how a deprecation is done, like #8388.

The contribution guide also has a chapter about it.

@mtrezza mtrezza added state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message block:major Needs to be resolved before next major release; remove label afterwards labels Jan 10, 2025
@dblythy dblythy mentioned this issue Jan 10, 2025
Merged
4 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block:major Needs to be resolved before next major release; remove label afterwards bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released-alpha Released as alpha version type:feature New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Deprecate PublicAPIRouter in favor of PagesRouter dblythy/parse-server
3 participants
@mtrezza @vibh1103 @parseplatformorg