Skip to content

Commit 54e46d4

Browse files
committed
Merge pull request #666 from ParsePlatform/nlutsenko.files.url
Remove 'url' as a required field on Files when they are stored on object.
2 parents 1945313 + a96cb6b commit 54e46d4

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

spec/ParseFile.spec.js

+18-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// This is a port of the test suite:
22
// hungry/js/test/parse_file_test.js
33

4+
"use strict";
5+
46
var request = require('request');
57

68
var str = "Hello World!";
@@ -482,7 +484,22 @@ describe('Parse.File testing', () => {
482484
);
483485
done();
484486
});
485-
486487
});
487488

489+
it('supports files in objects without urls', done => {
490+
var file = {
491+
__type: 'File',
492+
name: '123.txt'
493+
};
494+
var obj = new Parse.Object('FileTest');
495+
obj.set('file', file);
496+
obj.save().then(() => {
497+
var query = new Parse.Query('FileTest');
498+
return query.first();
499+
}).then(result => {
500+
let fileAgain = result.get('file');
501+
expect(fileAgain.url()).toMatch(/123.txt$/);
502+
done();
503+
});
504+
});
488505
});

src/Schema.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,7 @@ function getObjectType(obj) {
728728
if (obj.__type === 'Pointer' && obj.className) {
729729
return '*' + obj.className;
730730
}
731-
if (obj.__type === 'File' && obj.url && obj.name) {
731+
if (obj.__type === 'File' && obj.name) {
732732
return 'file';
733733
}
734734
if (obj.__type === 'Date' && obj.iso) {

0 commit comments

Comments
 (0)