Fix race when fetching schema frequently

Author: flovilmart

spec/ParseQuery.spec.js

@@ -1631,8 +1631,9 @@ describe('Parse.Query testing', () => {
       });
       expect(total).toBe(0);
       done()
-    }, () => {
+    }, (e) => {
       fail('should not fail');
+      fail(JSON.stringify(e));
       done();
     })
   });

spec/ParseRelation.spec.js

@@ -575,6 +575,9 @@ describe('Parse.Relation testing', () => {
         expect(result.get('key').get('even')).toBe(false);
       });
       done();
+    }, (e) => {
+      fail(JSON.stringify(e));
+      done();
     })
   });
 
@@ -613,6 +616,9 @@ describe('Parse.Relation testing', () => {
           done();
         }
       }));
+    }, (e) => {
+      fail(JSON.stringify(e));
+      done();
     });
   });
 
@@ -653,6 +659,9 @@ describe('Parse.Relation testing', () => {
           done();
         }
       }));
+    }, (e) => {
+      fail(JSON.stringify(e));
+      done();
     });
   });
 

src/Controllers/SchemaController.js

@@ -333,25 +333,29 @@ export default class SchemaController {
     if (this.reloadDataPromise && !options.clearCache) {
       return this.reloadDataPromise;
     }
-    this.data = {};
-    this.perms = {};
     this.reloadDataPromise = promise.then(() => {
       return this.getAllClasses(options);
     })
     .then(allSchemas => {
+      const data = {};
+      const perms = {};
       allSchemas.forEach(schema => {
-        this.data[schema.className] = injectDefaultSchema(schema).fields;
-        this.perms[schema.className] = schema.classLevelPermissions;
+        data[schema.className] = injectDefaultSchema(schema).fields;
+        perms[schema.className] = schema.classLevelPermissions;
       });
 
       // Inject the in-memory classes
       volatileClasses.forEach(className => {
         const schema = injectDefaultSchema({ className });
-        this.data[className] = schema.fields;
-        this.perms[className] = schema.classLevelPermissions;
+        data[className] = schema.fields;
+        perms[className] = schema.classLevelPermissions;
       });
+      this.data = data;
+      this.perms = perms;
       delete this.reloadDataPromise;
     }, (err) => {
+      this.data = {};
+      this.perms = {};
       delete this.reloadDataPromise;
       throw err;
     });