Skip to content

Commit 41853a0

Browse files
authored
Revert "Makes sure routes don't overlap and yield a header set error"
1 parent be9fb43 commit 41853a0

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

src/Controllers/AnalyticsController.js

+1-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import AdaptableController from './AdaptableController';
22
import { AnalyticsAdapter } from '../Adapters/Analytics/AnalyticsAdapter';
33

4-
const AppOpenedEventName = 'AppOpened';
5-
64
export class AnalyticsController extends AdaptableController {
75
appOpened(req) {
86
return Promise.resolve().then(() => {
@@ -15,12 +13,8 @@ export class AnalyticsController extends AdaptableController {
1513
}
1614

1715
trackEvent(req) {
18-
const eventName = req.params.eventName;
19-
if (eventName === AppOpenedEventName) {
20-
return this.appOpened(req);
21-
}
2216
return Promise.resolve().then(() => {
23-
return this.adapter.trackEvent(eventName, req.body, req);
17+
return this.adapter.trackEvent(req.params.eventName, req.body, req);
2418
}).then((response) => {
2519
return { response: response || {} };
2620
}).catch((err) => {

src/Routers/AnalyticsRouter.js

+6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
// AnalyticsRouter.js
22
import PromiseRouter from '../PromiseRouter';
33

4+
function appOpened(req) {
5+
const analyticsController = req.config.analyticsController;
6+
return analyticsController.appOpened(req);
7+
}
8+
49
function trackEvent(req) {
510
const analyticsController = req.config.analyticsController;
611
return analyticsController.trackEvent(req);
@@ -9,6 +14,7 @@ function trackEvent(req) {
914

1015
export class AnalyticsRouter extends PromiseRouter {
1116
mountRoutes() {
17+
this.route('POST','/events/AppOpened', appOpened);
1218
this.route('POST','/events/:eventName', trackEvent);
1319
}
1420
}

src/Routers/SessionsRouter.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ export class SessionsRouter extends ClassesRouter {
1111
}
1212

1313
handleGet(req) {
14-
if (req.params.objectId === 'me') {
15-
return this.handleMe(req);
16-
}
1714
req.params.className = '_Session';
1815
return super.handleGet(req);
1916
}
@@ -52,6 +49,7 @@ export class SessionsRouter extends ClassesRouter {
5249
}
5350

5451
mountRoutes() {
52+
this.route('GET','/sessions/me', req => { return this.handleMe(req); });
5553
this.route('GET', '/sessions', req => { return this.handleFind(req); });
5654
this.route('GET', '/sessions/:objectId', req => { return this.handleGet(req); });
5755
this.route('POST', '/sessions', req => { return this.handleCreate(req); });

src/Routers/UsersRouter.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ export class UsersRouter extends ClassesRouter {
1818
}
1919

2020
handleGet(req) {
21-
if (req.params.objectId === 'me') {
22-
return this.handleMe(req);
23-
}
2421
req.params.className = '_User';
2522
return super.handleGet(req);
2623
}
@@ -201,6 +198,7 @@ export class UsersRouter extends ClassesRouter {
201198
mountRoutes() {
202199
this.route('GET', '/users', req => { return this.handleFind(req); });
203200
this.route('POST', '/users', req => { return this.handleCreate(req); });
201+
this.route('GET', '/users/me', req => { return this.handleMe(req); });
204202
this.route('GET', '/users/:objectId', req => { return this.handleGet(req); });
205203
this.route('PUT', '/users/:objectId', req => { return this.handleUpdate(req); });
206204
this.route('DELETE', '/users/:objectId', req => { return this.handleDelete(req); });

0 commit comments

Comments
 (0)