Skip to content

Commit 1eb2a87

Browse files
committed
Removes GCS Adapter from provided adapters
* 💣 removes exposed GCS files adapter - Should fix problems with GCS - Throws error that shows the right repo
1 parent 0b2dc12 commit 1eb2a87

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,8 @@
3434
"multer": "^1.1.0",
3535
"parse": "^1.8.0",
3636
"parse-server-fs-adapter": "^1.0.0",
37-
"parse-server-gcs-adapter": "^1.0.0",
3837
"parse-server-push-adapter": "^1.0.0",
39-
"parse-server-s3-adapter": "^1.0.0",
38+
"parse-server-s3-adapter": "^1.0.1",
4039
"parse-server-simple-mailgun-adapter": "^1.0.0",
4140
"redis": "^2.5.0-1",
4241
"request": "^2.65.0",
@@ -61,7 +60,8 @@
6160
"gaze": "^0.5.2",
6261
"jasmine": "^2.3.2",
6362
"mongodb-runner": "3.1.15",
64-
"nodemon": "^1.8.1"
63+
"nodemon": "^1.8.1",
64+
"parse-server-gcs-adapter": "^1.0.0"
6565
},
6666
"scripts": {
6767
"dev": "npm run build && node bin/dev",

spec/index.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,9 @@ describe('server', () => {
261261
done();
262262
});
263263

264-
it('exposes all the "core" adapters', done => {
264+
it('core adapters are not exposed anymore', done => {
265265
expect(ParseServer.S3Adapter).toThrow();
266-
expect(ParseServer.GCSAdapter).toThrow('GCSAdapter requires an projectId');
266+
expect(ParseServer.GCSAdapter).toThrow('GCSAdapter is not provided by parse-server anymore; please install parse-server-gcs-adapter');
267267
expect(ParseServer.FileSystemAdapter).toThrow();
268268
done();
269269
});

src/deprecated.js

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
export function useExternal(name, moduleName) {
2+
return function() {
3+
throw `${name} is not provided by parse-server anymore; please install ${moduleName}`;
4+
}
5+
}

src/index.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import winston from 'winston';
22
import ParseServer from './ParseServer';
3-
import GCSAdapter from 'parse-server-gcs-adapter';
4-
import S3Adapter from 'parse-server-s3-adapter';
5-
import FileSystemAdapter from 'parse-server-fs-adapter';
3+
import S3Adapter from 'parse-server-s3-adapter'
4+
import FileSystemAdapter from 'parse-server-fs-adapter'
5+
import { useExternal } from './deprecated'
66

77
if (process.env.VERBOSE || process.env.VERBOSE_PARSE_SERVER) {
88
winston.level = 'silly';
@@ -20,5 +20,7 @@ let _ParseServer = function(options) {
2020
// Mount the create liveQueryServer
2121
_ParseServer.createLiveQueryServer = ParseServer.createLiveQueryServer;
2222

23+
let GCSAdapter = useExternal('GCSAdapter', 'parse-server-gcs-adapter');
24+
2325
export default ParseServer;
2426
export { S3Adapter, GCSAdapter, FileSystemAdapter, _ParseServer as ParseServer };

0 commit comments

Comments
 (0)