Skip to content

Commit 0050f7a

Browse files
committed
add securtiy check section to contribution guide
1 parent 096b7ed commit 0050f7a

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ Related issue: FILL_THIS_OUT
2525
- [ ] Add test cases
2626
- [ ] Add entry to changelog
2727
- [ ] Add changes to documentation (guides, repository pages, in-code descriptions)
28-
- [ ] Add security check warning <!-- see PR #6973 -->
28+
- [ ] Add [security check](https://github.com/parse-community/parse-server/blob/master/CONTRIBUTING.md#security-checks)
2929
- [ ] Add new Parse Error codes to Parse JS SDK <!-- no hard-coded error codes in Parse Server -->
3030
- [ ] ...

CONTRIBUTING.md

+12-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,18 @@ If you want to make changes to [Parse Server Configuration][config] add the desi
100100

101101
To view docs run `npm run docs` and check the `/out` directory.
102102

103-
### Code of Conduct
103+
## Feature Considerations
104+
### Security Checks
105+
106+
The Parse Server security checks feature warns developers about weak security settings in their Parse Server deployment.
107+
108+
A security check needs to be added for every new feature or enhancement that allows the developer to configure it in a way that weakens security mechanisms or exposes functionality which creates a weak spot for malicious attacks. If you are not sure whether your feature or enhancements requires a security check, feel free to ask.
109+
110+
For example, allowing public read and write to a class may be useful to simplify development but should be disallowed in a production environment.
111+
112+
Security checks are added in [SecurityChecks.js](https://github.com/parse-community/parse-server/blob/master/src/SecurityChecks.js).
113+
114+
## Code of Conduct
104115

105116
This project adheres to the [Contributor Covenant Code of Conduct](https://github.com/parse-community/parse-server/blob/master/CODE_OF_CONDUCT.md). By participating, you are expected to honor this code.
106117

0 commit comments

Comments
 (0)