Skip to content

Commit 0db139d

Browse files
committed
Fixed error when sending pushes to one pushType
Added check for empty devices sets when sending push notifications to senders. This fixes and issue where the empty sets being processed by the senders would throw several reference errors.
1 parent a651668 commit 0db139d

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

src/ParsePushAdapter.js

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,22 @@ export class ParsePushAdapter {
5050
for (let pushType in deviceMap) {
5151
let sender = this.senderMap[pushType];
5252
let devices = deviceMap[pushType];
53-
if (!sender) {
54-
log.verbose(LOG_PREFIX, `Can not find sender for push type ${pushType}, ${data}`)
55-
let results = devices.map((device) => {
56-
return Promise.resolve({
57-
device,
58-
transmitted: false,
59-
response: {'error': `Can not find sender for push type ${pushType}, ${data}`}
60-
})
61-
});
62-
sendPromises.push(Promise.all(results));
63-
} else {
64-
sendPromises.push(sender.send(data, devices));
65-
}
53+
if(devices.length > 0)
54+
{
55+
if (!sender) {
56+
log.verbose(LOG_PREFIX, `Can not find sender for push type ${pushType}, ${data}`)
57+
let results = devices.map((device) => {
58+
return Promise.resolve({
59+
device,
60+
transmitted: false,
61+
response: {'error': `Can not find sender for push type ${pushType}, ${data}`}
62+
})
63+
});
64+
sendPromises.push(Promise.all(results));
65+
} else {
66+
sendPromises.push(sender.send(data, devices));
67+
}
68+
}
6669
}
6770
return Promise.all(sendPromises).then((promises) => {
6871
// flatten all

0 commit comments

Comments
 (0)