From ef02fbf1c4b22e2f9adc3c33ac88fce4dece0155 Mon Sep 17 00:00:00 2001 From: Diamond Lewis Date: Sat, 4 Mar 2023 20:33:36 -0600 Subject: [PATCH] fix: Crashing when editing Number in Edit Row Modal --- src/dashboard/Data/Browser/EditRowDialog.react.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/dashboard/Data/Browser/EditRowDialog.react.js b/src/dashboard/Data/Browser/EditRowDialog.react.js index 1dde61268d..532279bdb1 100644 --- a/src/dashboard/Data/Browser/EditRowDialog.react.js +++ b/src/dashboard/Data/Browser/EditRowDialog.react.js @@ -14,6 +14,7 @@ import ObjectPickerDialog from 'dashboard/Data/Browser/ObjectPickerDialog.react' import styles from 'dashboard/Data/Browser/Browser.scss'; import getFileName from 'lib/getFileName'; import encode from 'parse/lib/browser/encode'; +import validateNumeric from 'lib/validateNumeric'; export default class EditRowDialog extends React.Component { constructor(props) { @@ -291,8 +292,8 @@ export default class EditRowDialog extends React.Component { disabled={isDisabled} value={currentObject[name]} placeholder={val === undefined ? '(undefined)' : ''} - onChange={newValue => this.updateCurrentObject(newValue, name)} - onBlur={newValue => this.handleChange(parseFloat(newValue), name)} + onChange={newValue => this.updateCurrentObject(validateNumeric(newValue) ? newValue : currentObject[name], name)} + onBlur={newValue => this.handleChange(validateNumeric(parseFloat(newValue)) ? parseFloat(newValue) : undefined, name)} /> ); break;