From 5d118fff779725a37ab79d82d8fe2e65368fd827 Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Thu, 5 Aug 2021 19:03:05 +0500 Subject: [PATCH 01/10] cell select height fix --- src/components/BrowserCell/BrowserCell.scss | 2 +- src/dashboard/Data/Browser/Browser.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/BrowserCell/BrowserCell.scss b/src/components/BrowserCell/BrowserCell.scss index aa845c9d0a..923e1cc1b4 100644 --- a/src/components/BrowserCell/BrowserCell.scss +++ b/src/components/BrowserCell/BrowserCell.scss @@ -11,7 +11,7 @@ text-overflow: ellipsis; cursor: default; color: #0E69A1; - height: 30px; + height: 35px; line-height: 22px; padding: 5px 4px 0; border-right: 1px solid #e3e3ea; diff --git a/src/dashboard/Data/Browser/Browser.scss b/src/dashboard/Data/Browser/Browser.scss index 5607effdde..e74b561864 100644 --- a/src/dashboard/Data/Browser/Browser.scss +++ b/src/dashboard/Data/Browser/Browser.scss @@ -102,7 +102,7 @@ @include MonospaceFont; font-size: 12px; white-space: nowrap; - height: auto; + height: 35px; border-bottom: 1px solid #e3e3ea; &:nth-child(odd) { From 372ff63f3534b9c862830654f67366a3a6b179ee Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Thu, 5 Aug 2021 19:16:23 +0500 Subject: [PATCH 02/10] cell height refactoring --- src/components/BrowserCell/BrowserCell.scss | 2 +- src/dashboard/Data/Browser/Browser.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/BrowserCell/BrowserCell.scss b/src/components/BrowserCell/BrowserCell.scss index 923e1cc1b4..d7d4b31174 100644 --- a/src/components/BrowserCell/BrowserCell.scss +++ b/src/components/BrowserCell/BrowserCell.scss @@ -11,7 +11,7 @@ text-overflow: ellipsis; cursor: default; color: #0E69A1; - height: 35px; + height: 32px; line-height: 22px; padding: 5px 4px 0; border-right: 1px solid #e3e3ea; diff --git a/src/dashboard/Data/Browser/Browser.scss b/src/dashboard/Data/Browser/Browser.scss index e74b561864..bf5306abc7 100644 --- a/src/dashboard/Data/Browser/Browser.scss +++ b/src/dashboard/Data/Browser/Browser.scss @@ -102,7 +102,7 @@ @include MonospaceFont; font-size: 12px; white-space: nowrap; - height: 35px; + height: 32px; border-bottom: 1px solid #e3e3ea; &:nth-child(odd) { From f896f3be2fd5e9b2a13fff38e555cece71cb52eb Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Tue, 10 Aug 2021 19:38:22 +0500 Subject: [PATCH 03/10] row height to match cell height --- src/components/BrowserCell/BrowserCell.scss | 2 +- src/dashboard/Data/Browser/Browser.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/BrowserCell/BrowserCell.scss b/src/components/BrowserCell/BrowserCell.scss index d7d4b31174..aa845c9d0a 100644 --- a/src/components/BrowserCell/BrowserCell.scss +++ b/src/components/BrowserCell/BrowserCell.scss @@ -11,7 +11,7 @@ text-overflow: ellipsis; cursor: default; color: #0E69A1; - height: 32px; + height: 30px; line-height: 22px; padding: 5px 4px 0; border-right: 1px solid #e3e3ea; diff --git a/src/dashboard/Data/Browser/Browser.scss b/src/dashboard/Data/Browser/Browser.scss index bf5306abc7..4d40604b9a 100644 --- a/src/dashboard/Data/Browser/Browser.scss +++ b/src/dashboard/Data/Browser/Browser.scss @@ -102,7 +102,7 @@ @include MonospaceFont; font-size: 12px; white-space: nowrap; - height: 32px; + height: 31px; border-bottom: 1px solid #e3e3ea; &:nth-child(odd) { From 58f0419da3007a8bd195ef9d73cd68b8b646884e Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Wed, 11 Aug 2021 17:02:13 +0500 Subject: [PATCH 04/10] refactor height --- src/dashboard/Data/Browser/Browser.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dashboard/Data/Browser/Browser.scss b/src/dashboard/Data/Browser/Browser.scss index 4d40604b9a..b6acada937 100644 --- a/src/dashboard/Data/Browser/Browser.scss +++ b/src/dashboard/Data/Browser/Browser.scss @@ -102,7 +102,7 @@ @include MonospaceFont; font-size: 12px; white-space: nowrap; - height: 31px; + height: 30px; border-bottom: 1px solid #e3e3ea; &:nth-child(odd) { From 5880bacbcd080bf5af4b6a6f4b3b6b0d733a93e2 Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Wed, 11 Aug 2021 18:31:14 +0500 Subject: [PATCH 05/10] removed line height --- src/components/BrowserCell/BrowserCell.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/BrowserCell/BrowserCell.scss b/src/components/BrowserCell/BrowserCell.scss index aa845c9d0a..38f9d1513a 100644 --- a/src/components/BrowserCell/BrowserCell.scss +++ b/src/components/BrowserCell/BrowserCell.scss @@ -12,7 +12,7 @@ cursor: default; color: #0E69A1; height: 30px; - line-height: 22px; + // line-height: 22px; padding: 5px 4px 0; border-right: 1px solid #e3e3ea; } From 38d6a29b8ed17bc53d2ffb35851989deb59b0d27 Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Mon, 16 Aug 2021 19:43:59 +0500 Subject: [PATCH 06/10] cell padding fix --- src/components/Pill/Pill.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Pill/Pill.scss b/src/components/Pill/Pill.scss index c24ca6240e..ad97b2dc5a 100644 --- a/src/components/Pill/Pill.scss +++ b/src/components/Pill/Pill.scss @@ -13,7 +13,7 @@ justify-content: space-between; align-items: center; color: #0E69A1; - height: 20px; + height: 18px; line-height: 20px; border-radius: 10px; font-size: 11px; @@ -49,4 +49,4 @@ .disableIconAction { cursor: initial; -} \ No newline at end of file +} From 041fd96f5553dddbfd7c883c8669552406ce702f Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Mon, 16 Aug 2021 21:37:31 +0500 Subject: [PATCH 07/10] Cell lineheight fix --- src/components/BrowserCell/BrowserCell.scss | 2 +- src/components/Pill/Pill.scss | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/BrowserCell/BrowserCell.scss b/src/components/BrowserCell/BrowserCell.scss index 38f9d1513a..bd8cd26172 100644 --- a/src/components/BrowserCell/BrowserCell.scss +++ b/src/components/BrowserCell/BrowserCell.scss @@ -13,7 +13,7 @@ color: #0E69A1; height: 30px; // line-height: 22px; - padding: 5px 4px 0; + padding: 6px 4px 0; border-right: 1px solid #e3e3ea; } diff --git a/src/components/Pill/Pill.scss b/src/components/Pill/Pill.scss index ad97b2dc5a..2c9c3a217f 100644 --- a/src/components/Pill/Pill.scss +++ b/src/components/Pill/Pill.scss @@ -11,10 +11,10 @@ @include MonospaceFont; display: flex; justify-content: space-between; - align-items: center; + // align-items: center; color: #0E69A1; - height: 18px; - line-height: 20px; + // height: 20px; + line-height: 18px; border-radius: 10px; font-size: 11px; width: 100%; From ba743d534d5e6d48f25e55757281ef29b3770b1c Mon Sep 17 00:00:00 2001 From: Faisal Nadeem Date: Tue, 17 Aug 2021 16:38:47 +0500 Subject: [PATCH 08/10] cell spacing -- 2 --- src/components/BrowserCell/BrowserCell.scss | 2 +- src/components/Pill/Pill.scss | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/components/BrowserCell/BrowserCell.scss b/src/components/BrowserCell/BrowserCell.scss index bd8cd26172..38f9d1513a 100644 --- a/src/components/BrowserCell/BrowserCell.scss +++ b/src/components/BrowserCell/BrowserCell.scss @@ -13,7 +13,7 @@ color: #0E69A1; height: 30px; // line-height: 22px; - padding: 6px 4px 0; + padding: 5px 4px 0; border-right: 1px solid #e3e3ea; } diff --git a/src/components/Pill/Pill.scss b/src/components/Pill/Pill.scss index 2c9c3a217f..029e28bcf8 100644 --- a/src/components/Pill/Pill.scss +++ b/src/components/Pill/Pill.scss @@ -18,11 +18,12 @@ border-radius: 10px; font-size: 11px; width: 100%; - overflow: hidden; - text-overflow: ellipsis; + // overflow: hidden; + // text-overflow: ellipsis; white-space: nowrap; margin-bottom: 4px; & a { + margin-top: -1.5px; height: 20px; width: 20px; background: #d6e5f2; From 240ecde788f1021f33bae688b72d8ceff0203711 Mon Sep 17 00:00:00 2001 From: Manuel <5673677+mtrezza@users.noreply.github.com> Date: Tue, 17 Aug 2021 20:34:23 +0200 Subject: [PATCH 09/10] Update BrowserCell.scss --- src/components/BrowserCell/BrowserCell.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/BrowserCell/BrowserCell.scss b/src/components/BrowserCell/BrowserCell.scss index 38f9d1513a..b90ae7ea53 100644 --- a/src/components/BrowserCell/BrowserCell.scss +++ b/src/components/BrowserCell/BrowserCell.scss @@ -12,8 +12,8 @@ cursor: default; color: #0E69A1; height: 30px; - // line-height: 22px; - padding: 5px 4px 0; + line-height: 20px; + padding: 5px; border-right: 1px solid #e3e3ea; } From 91bf24bf673d3e47fc655a24817b331bbeb1850c Mon Sep 17 00:00:00 2001 From: Manuel <5673677+mtrezza@users.noreply.github.com> Date: Tue, 17 Aug 2021 20:35:18 +0200 Subject: [PATCH 10/10] Update Pill.scss --- src/components/Pill/Pill.scss | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/components/Pill/Pill.scss b/src/components/Pill/Pill.scss index 029e28bcf8..95987e52a6 100644 --- a/src/components/Pill/Pill.scss +++ b/src/components/Pill/Pill.scss @@ -11,19 +11,17 @@ @include MonospaceFont; display: flex; justify-content: space-between; - // align-items: center; + align-items: center; color: #0E69A1; - // height: 20px; - line-height: 18px; + height: 20px; + line-height: 20px; border-radius: 10px; font-size: 11px; width: 100%; - // overflow: hidden; - // text-overflow: ellipsis; + overflow: hidden; + text-overflow: ellipsis; white-space: nowrap; - margin-bottom: 4px; & a { - margin-top: -1.5px; height: 20px; width: 20px; background: #d6e5f2;