Skip to content

Commit cccac55

Browse files
committed
Merge pull request #41 from ParsePlatform/peterjs.explitDisabledCheckbox
Add not allowed styles to bulk checkbox.
2 parents 1691ddd + 6e55cb4 commit cccac55

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ export default class DataBrowserHeaderBar extends React.Component {
1717
render() {
1818
let { headers, onResize, selected, selectAll, onAddColumn, updateOrdering, readonly, handleDragDrop } = this.props;
1919
let elements = [
20+
// Note: bulk checkbox is disabled as all rows are selected (not just visible ones due to current lazy loading implementation)
21+
// TODO: add bulk checking only visible rows
2022
<div key='check' className={[styles.wrap, styles.check].join(' ')}>
21-
{readonly ? null : <input type='checkbox' disabled={true} checked={false} onChange={(e) => selectAll(e.target.checked)} />}
23+
{readonly ? null : <input className={styles.disabled} type='checkbox' disabled={true} checked={false} onChange={(e) => selectAll(e.target.checked)} />}
2224
</div>
2325
];
2426

components/DataBrowserHeaderBar/DataBrowserHeaderBar.scss

+4
Original file line numberDiff line numberDiff line change
@@ -64,3 +64,7 @@
6464
margin: 0 -4px;
6565
cursor: ew-resize;
6666
}
67+
68+
.disabled {
69+
cursor: not-allowed;
70+
}

0 commit comments

Comments
 (0)