Add tests for application data sharing exceptions.

Author: richardjrossiii

Parse/Internal/ParseManager.m

@@ -113,10 +113,6 @@ - (instancetype)initWithConfiguration:(ParseClientConfiguration *)configuration
     return self;
 }
 
-///--------------------------------------
-#pragma mark - Offline Store
-///--------------------------------------
-
 - (void)startManaging {
     // Migrate any data if it's required.
     [self _migrateSandboxDataToApplicationGroupContainerIfNeeded];
@@ -131,6 +127,10 @@ - (void)startManaging {
     }
 }
 
+///--------------------------------------
+#pragma mark - Offline Store
+///--------------------------------------
+
 - (void)loadOfflineStoreWithOptions:(PFOfflineStoreOptions)options {
     dispatch_barrier_sync(_offlineStoreAccessQueue, ^{
         PFConsistencyAssert(!_offlineStore, @"Can't load offline store more than once.");

Parse/Parse.m

@@ -64,6 +64,10 @@ + (void)setApplicationId:(NSString *)applicationId clientKey:(NSString *)clientK
 }
 
 + (void)initializeWithConfiguration:(ParseClientConfiguration *)configuration {
+    PFConsistencyAssert(configuration.applicationId.length != 0,
+                        @"You must set your configuration's `applicationId` before calling %s!", __PRETTY_FUNCTION__);
+    PFConsistencyAssert(configuration.clientKey.length != 0,
+                        @"You must set your configuration's `clientKey` before calling %s!", __PRETTY_FUNCTION__);
     PFConsistencyAssert(![PFApplication currentApplication].extensionEnvironment ||
                         configuration.applicationGroupIdentifier == nil ||
                         configuration.containingApplicationBundleIdentifier != nil,

Parse/ParseClientConfiguration.m

@@ -24,7 +24,16 @@ @implementation ParseClientConfiguration
 ///--------------------------------------
 
 + (instancetype)emptyConfiguration {
-    return [super new];
+    return [[super alloc] initEmpty];
+}
+
+- (instancetype)initEmpty {
+    self = [super init];
+    if (!self) return nil;
+
+    _networkRetryAttempts = PFCommandRunningDefaultMaxAttemptsCount;
+
+    return self;
 }
 
 - (instancetype)initWithBlock:(void (^)(id<ParseMutableClientConfiguration>))configurationBlock {

Tests/Unit/ParseClientConfigurationTests.m

@@ -12,12 +12,27 @@
 #import "PFTestCase.h"
 #import "ParseClientConfiguration.h"
 #import "ParseClientConfiguration_Private.h"
+#import "PFExtensionDataSharingTestHelper.h"
 
-@interface ParseClientConfigurationTests : PFTestCase
+@interface ParseClientConfigurationTests : PFTestCase {
+    PFExtensionDataSharingTestHelper *_testHelper;
+}
 @end
 
 @implementation ParseClientConfigurationTests
 
+- (void)setUp {
+    [super setUp];
+
+    _testHelper = [[PFExtensionDataSharingTestHelper alloc] init];
+}
+
+- (void)tearDown {
+    _testHelper = nil;
+
+    [super tearDown];
+}
+
 - (void)testConfigurationWithBlock {
     ParseClientConfiguration *configuration = [ParseClientConfiguration configurationWithBlock:^(id<ParseMutableClientConfiguration> configuration) {
         configuration.applicationId = @"foo";
@@ -89,4 +104,23 @@ - (void)testCopy {
     XCTAssertEqual(configurationB.networkRetryAttempts, 1337);
 }
 
+- (void)testExtensionDataSharing {
+    ParseClientConfiguration *configuration = [ParseClientConfiguration emptyConfiguration];
+
+    // Innaccessible bundle identifiers should throw
+    XCTAssertThrows(configuration.applicationGroupIdentifier = @"someBundleIdentifier");
+
+    // Accessible bundle identifiers should not throw
+    _testHelper.swizzledGroupContainerDirectoryPath = YES;
+    XCTAssertNoThrow(configuration.applicationGroupIdentifier = @"someBundleIdentifier");
+
+    // In non-extension environment, setting containing identifier should throw.
+    XCTAssertThrows(configuration.containingApplicationBundleIdentifier = @"someContainer");
+
+    _testHelper.runningInExtensionEnvironment = YES;
+
+    // In extension environment this should succeed.
+    XCTAssertNoThrow(configuration.containingApplicationBundleIdentifier = @"someContainer");
+}
+
 @end