Merge pull request #46 from ParsePlatform/nlutsenko.underlyingError

Store original network error under NSUnderlyingError key.

Author: nlutsenko

Parse/Internal/Commands/CommandRunner/URLSession/Session/TaskDelegate/PFURLSessionFileDownloadTaskDelegate.m

@@ -82,6 +82,7 @@ - (void)_taskDidFinish {
         errorDictionary[@"code"] = @(kPFErrorConnectionFailed);
         errorDictionary[@"error"] = [self.error localizedDescription];
         errorDictionary[@"originalError"] = self.error;
+        errorDictionary[NSUnderlyingErrorKey] = self.error;
         errorDictionary[@"temporary"] = @(self.response.statusCode >= 500 || self.response.statusCode < 400);
         self.error = [PFErrorUtilities errorFromResult:errorDictionary];
     }

Parse/Internal/Commands/CommandRunner/URLSession/Session/TaskDelegate/PFURLSessionJSONDataTaskDelegate.m

@@ -54,6 +54,7 @@ - (void)_taskDidFinish {
         errorDictionary[@"code"] = @(kPFErrorConnectionFailed);
         errorDictionary[@"error"] = [self.error localizedDescription];
         errorDictionary[@"originalError"] = self.error;
+        errorDictionary[NSUnderlyingErrorKey] = self.error;
         errorDictionary[@"temporary"] = @(self.response.statusCode >= 500 || self.response.statusCode < 400);
         self.error = [PFErrorUtilities errorFromResult:errorDictionary];
         [super _taskDidFinish];

Tests/Unit/URLSessionDataTaskDelegateTests.m

@@ -130,6 +130,7 @@ - (void)testUnknownError {
     [delegate URLSession:mockedSession task:mockedTask didCompleteWithError:expectedError];
 
     XCTAssertEqualObjects(delegate.resultTask.error.userInfo[@"originalError"], expectedError);
+    XCTAssertEqualObjects(delegate.resultTask.error.userInfo[NSUnderlyingErrorKey], expectedError);
 }
 
 - (void)testJSONError {

Tests/Unit/URLSessionTests.m

@@ -244,6 +244,7 @@ - (void)testPerformDataRequestError {
     [[session performDataURLRequestAsync:mockedURLRequest forCommand:mockedCommand cancellationToken:nil]
      continueWithBlock:^id(BFTask *task) {
          XCTAssertEqualObjects(expectedError, task.error.userInfo[@"originalError"]);
+         XCTAssertEqualObjects(expectedError, task.error.userInfo[NSUnderlyingErrorKey]);
          [expectation fulfill];
          return nil;
      }];

Tests/Unit/URLSessionUploadTaskDelegateTests.m

@@ -205,6 +205,7 @@ - (void)testUnknownError {
     [delegate URLSession:mockedSession task:mockedTask didCompleteWithError:expectedError];
 
     XCTAssertEqualObjects(delegate.resultTask.error.userInfo[@"originalError"], expectedError);
+    XCTAssertEqualObjects(delegate.resultTask.error.userInfo[NSUnderlyingErrorKey], expectedError);
 }
 
 - (void)testJSONError {