Skip to content

Commit da25cb4

Browse files
committed
Make signUp more robust
* Revert current user's password on failure if that's how it originally was * Revert the current user's password on success
1 parent fa8ac07 commit da25cb4

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

Parse/src/main/java/com/parse/ParseUser.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -638,14 +638,19 @@ public Task<Void> then(Task<Void> task) throws Exception {
638638
synchronized (user.mutex) {
639639
if (oldUsername != null) {
640640
user.setUsername(oldUsername);
641+
} else {
642+
user.revert(KEY_USERNAME);
641643
}
642644
if (oldPassword != null) {
643645
user.setPassword(oldPassword);
646+
} else {
647+
user.revert(KEY_PASSWORD);
644648
}
645649
user.restoreAnonymity(anonymousData);
646650
}
647651
return task;
648652
} else { // Success
653+
user.revert(KEY_PASSWORD);
649654
revert(KEY_PASSWORD);
650655
}
651656

0 commit comments

Comments
 (0)